session: fix crash during client detach

This fixes a crash caused by client closing socket before adding worker.
During detach vpp tries to delete worker based on invalid worker index.

Type: fix

Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Change-Id: I3242bcbb116ef5fd1d4c449f5bcf907e4e2f8f30

1 files changed, 3 insertions, 1 deletions

diff --git a/src/vnet/session/session_api.c b/src/vnet/session/session_api.c
index 615e2ade59c..2502ef6a70a 100644
--- a/src/vnet/session/session_api.c
+++ b/src/vnet/session/session_api.c
@@ -1485,7 +1485,9 @@ sapi_socket_detach (app_namespace_t * app_ns, clib_socket_t * cs)
 
   /* Cleanup everything because app worker closed socket or crashed */
   handle = (app_ns_api_handle_t *) & cs->private_data;
-  app_wrk = app_worker_get (handle->aah_app_wrk_index);
+  app_wrk = app_worker_get_if_valid (handle->aah_app_wrk_index);
+  if (!app_wrk)
+    return;
 
   vnet_app_worker_add_del_args_t args = {
     .app_index = app_wrk->app_index,

path: root/src/vnet/session/session_api.c

---
# file: host_vars/10.30.51.74.yaml

hostname: "s64-t34-tg1"
grub:
  audit: "0"
  default_hugepagesz: "2M hugepagesz=1G hugepages=32 hugepagesz=2M hugepages=32768"
  hpet: "disable"
  intel_idle.max_cstate: "1"
  intel_iommu: "on"
  intel_pstate: "disable"
  iommu: "pt"
  isolcpus: "1-31,33-63,65-95,97-127"
  mce: "off"
  nmi_watchdog: "0"
  nohz_full: "1-31,33-63,65-95,97-127"
  nosoftlockup: true
  numa_balancing: "disable"
  processor.max_cstate: "1"
  rcu_nocbs: "1-31,33-63,65-95,97-127"
  tsc: "reliable"
sysctl:
  kernel:
    watchdog_cpumask: "0,32,64,96"
  vm:
    nr_hugepages: 32768
    max_map_count: 20000

inventory_ipmi_hostname: "10.30.50.74"
cpu_microarchitecture: "icelake"

intel_700_matrix: "dpdk22.07"
intel_800_matrix: "dpdk22.07"