diff options
| author |   Dave Wallace <dwallacelf@gmail.com> | 2017-10-24 01:32:41 -0400 |
|---|---|---|
| committer | Dave Wallace <dwallacelf@gmail.com> | 2017-10-24 01:32:41 -0400 |
| commit | 71612d61930e57e7c8ebf9e5647b15a4b23720b2 (patch) | |
| tree | 3c135af6d40442f5ae9f8397c62080e2b7e3f342 /src/vnet/span | |
| parent | 92b0275a364022af6ab828dfac83e38c0117cfe6 (diff) | |
Add extern to *_main global variable declarations in header files.
- Global variables declared in header files without
the use of the 'extern' keword will result in multiple
instances of the variable to be created by the compiler
-- one for each different source file in which the
the header file is included. This results in wasted
memory allocated in the BSS segments as well as
potentially introducing bugs in the application.
Change-Id: I6ef1790b60a0bd9dd3994f8510723decf258b0cc
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Diffstat (limited to 'src/vnet/span')
| -rw-r--r-- | src/vnet/span/span.c | 2 | ||||
| -rw-r--r-- | src/vnet/span/span.h | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/src/vnet/span/span.c b/src/vnet/span/span.c index 2fd9cd87dfb..b7292cf1e80 100644 --- a/src/vnet/span/span.c +++ b/src/vnet/span/span.c @@ -21,6 +21,8 @@ #include <vnet/span/span.h> +span_main_t span_main; + typedef enum { SPAN_DISABLE = 0, diff --git a/src/vnet/span/span.h b/src/vnet/span/span.h index 10de8272ab0..ebdb4980c77 100644 --- a/src/vnet/span/span.h +++ b/src/vnet/span/span.h @@ -55,7 +55,7 @@ typedef struct vnet_main_t *vnet_main; } span_main_t; -span_main_t span_main; +extern span_main_t span_main; typedef struct { |