diff options
| author |   Florin Coras <fcoras@cisco.com> | 2018-04-18 13:20:18 -0700 |
|---|---|---|
| committer |   Marco Varlese <marco.varlese@suse.de> | 2018-04-20 07:12:27 +0000 |
| commit | 00cd22d627325a4a2869bedac68d0c1dd4d8ade7 (patch) | |
| tree | 99b8a6b3f46435e12dae353169d65b3f5084e18c /src/vnet/tcp/tcp_output.c | |
| parent | 8e1039a8231cd1d817a24256c421b9fc512f45fa (diff) | |
tcp: improve stats
Change-Id: I9ab11ba9f958c679112eb22c8db39cb269a29dc7
Signed-off-by: Florin Coras <fcoras@cisco.com>
Diffstat (limited to 'src/vnet/tcp/tcp_output.c')
| -rw-r--r-- | src/vnet/tcp/tcp_output.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/vnet/tcp/tcp_output.c b/src/vnet/tcp/tcp_output.c index 53d8ab90dff..e16ea9e133c 100644 --- a/src/vnet/tcp/tcp_output.c +++ b/src/vnet/tcp/tcp_output.c @@ -1826,6 +1826,12 @@ tcp46_output_inline (vlib_main_t * vm, if (PREDICT_FALSE (vnet_buffer (b0)->tcp.flags & TCP_BUF_FLAG_DUPACK)) { + /* N.B. Should not filter burst of dupacks. Two issues: + * 1) dupacks open cwnd on remote peer when congested + * 2) acks leaving should have the latest rcv_wnd since the + * burst may have eaten up all of it, so only the old ones + * could be filtered. + */ if (!tcp_session_has_ooo_data (tc0)) { error0 = TCP_ERROR_FILTERED_DUPACKS; |