diff options
| author |   Florin Coras <fcoras@cisco.com> | 2018-11-05 11:06:53 -0800 |
|---|---|---|
| committer |   Marco Varlese <marco.varlese@suse.de> | 2018-11-06 08:10:22 +0000 |
| commit | 9ece3c03133309dda1f7f7f292bd071fa1ccb0f1 (patch) | |
| tree | d976d958c8ccba43506194c31ce65bd388902666 /src/vnet/tcp/tcp_output.c | |
| parent | 87ee947d0b053b33571c5e33617b138236bada59 (diff) | |
tcp: dequeue acked only once per burst
Avoid dequeuing acked bytes more than once per burst for a connection.
Although the fifos do not use locks, size decrements are atomic, so they
rely on locked instructions.
Change-Id: Id65f4ea40b2c10057461402dfd0393034e6472d5
Signed-off-by: Florin Coras <fcoras@cisco.com>
Diffstat (limited to 'src/vnet/tcp/tcp_output.c')
| -rw-r--r-- | src/vnet/tcp/tcp_output.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/vnet/tcp/tcp_output.c b/src/vnet/tcp/tcp_output.c index b15cf9b362b..29a919bd160 100644 --- a/src/vnet/tcp/tcp_output.c +++ b/src/vnet/tcp/tcp_output.c @@ -1308,7 +1308,7 @@ tcp_prepare_segment (tcp_worker_ctx_t * wrk, tcp_connection_t * tc, } } - tcp_get_free_buffer_index (wrk, &bi); + (void) tcp_get_free_buffer_index (wrk, &bi); ASSERT (bi != (u32) ~ 0); *b = vlib_get_buffer (vm, bi); data = tcp_init_buffer (vm, *b); @@ -1908,7 +1908,7 @@ send_unsent: /* RFC 6582: Send a new segment if permitted by the new value of cwnd. */ snd_space = tcp_available_cc_snd_space (tc); - if (snd_space < tc->snd_mss) + if (snd_space < tc->snd_mss || tc->snd_mss == 0) goto done; max_deq = session_tx_fifo_max_dequeue (&tc->connection); |