diff options
| author |   jaszha03 <jason.zhang2@arm.com> | 2019-06-12 16:01:19 -0500 |
|---|---|---|
| committer |   Dave Barach <openvpp@barachs.net> | 2019-07-30 16:22:03 +0000 |
| commit | f25e7cfa5c615e1972d5823b65ca579f951d68a5 (patch) | |
| tree | 47c4e91b45710d861081d1933e2e8cbe3f56fe42 /src/vnet | |
| parent | 6b03ab73116a7746f9480ea00c3924dcecb2799f (diff) | |
vppinfra: refactor use of CLIB_MEMORY_BARRIER ()
All instances of test_and_set locks used the following sequence
to release the locks:
CLIB_MEMORY_BARRIER ();
p->lock = 0; // p is a generic struct with a TAS lock
Use clib_atomic_release to generate more efficient assembly code.
Type: refactor
Change-Id: Idca3a38b1cf43578108bdd1afe83b6ebc17a4c68
Signed-off-by: Jason Zhang <jason.zhang2@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Lijian Zhang <Lijian.Zhang@arm.com>
Diffstat (limited to 'src/vnet')
| -rwxr-xr-x | src/vnet/classify/vnet_classify.c | 3 | ||||
| -rw-r--r-- | src/vnet/dns/dns.h | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/src/vnet/classify/vnet_classify.c b/src/vnet/classify/vnet_classify.c index 64549a6e0d5..f5e49491b25 100755 --- a/src/vnet/classify/vnet_classify.c +++ b/src/vnet/classify/vnet_classify.c @@ -640,8 +640,7 @@ expand_ok: vnet_classify_entry_free (t, v, old_log2_pages); unlock: - CLIB_MEMORY_BARRIER (); - t->writer_lock[0] = 0; + clib_atomic_release (&t->writer_lock[0]); return rv; } diff --git a/src/vnet/dns/dns.h b/src/vnet/dns/dns.h index 19de69cc248..d5029e521d6 100644 --- a/src/vnet/dns/dns.h +++ b/src/vnet/dns/dns.h @@ -206,8 +206,7 @@ dns_cache_unlock (dns_main_t * dm) { if (dm->cache_lock) { - CLIB_MEMORY_BARRIER (); - *dm->cache_lock = 0; + clib_atomic_release (dm->cache_lock); } } |