aboutsummaryrefslogtreecommitdiffstats
path: root/src/vpp-api/java/jvpp/gen/jvppgen/jvpp_callback_facade_gen.py
diff options
context:
space:
mode:
authorMarek Gradzki <mgradzki@cisco.com>2017-08-15 12:25:24 +0200
committerFlorin Coras <florin.coras@gmail.com>2017-08-16 01:31:00 +0000
commit5da27c260e538188b0b934f55db98dc29ff4a24a (patch)
treee31c77de62df830044afd182f5da6bb3e3dbf440 /src/vpp-api/java/jvpp/gen/jvppgen/jvpp_callback_facade_gen.py
parent24b170aac55d16cb3ff934d2f3d7983dc11cbe12 (diff)
jvpp: move JVppReply's id out of synchronized block
Should make Coverity stop thinking we try to synchronize reply.context. Change-Id: I97169e46b9c8f594836d6beb75b9f42dfc6e5bad Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Diffstat (limited to 'src/vpp-api/java/jvpp/gen/jvppgen/jvpp_callback_facade_gen.py')
-rw-r--r--src/vpp-api/java/jvpp/gen/jvppgen/jvpp_callback_facade_gen.py10
1 files changed, 6 insertions, 4 deletions
diff --git a/src/vpp-api/java/jvpp/gen/jvppgen/jvpp_callback_facade_gen.py b/src/vpp-api/java/jvpp/gen/jvppgen/jvpp_callback_facade_gen.py
index ac096a7163d..9aaa4c645f0 100644
--- a/src/vpp-api/java/jvpp/gen/jvppgen/jvpp_callback_facade_gen.py
+++ b/src/vpp-api/java/jvpp/gen/jvppgen/jvpp_callback_facade_gen.py
@@ -222,11 +222,12 @@ public final class CallbackJVpp${plugin_name}FacadeCallback implements $plugin_p
@Override
@SuppressWarnings("unchecked")
- public void onControlPingReply($base_package.$dto_package.ControlPingReply reply) {
+ public void onControlPingReply(final $base_package.$dto_package.ControlPingReply reply) {
$base_package.$callback_package.ControlPingCallback callback;
+ final int replyId = reply.context;
synchronized(requests) {
- callback = ($base_package.$callback_package.ControlPingCallback) requests.remove(reply.context);
+ callback = ($base_package.$callback_package.ControlPingCallback) requests.remove(replyId);
}
if(callback != null) {
@@ -241,11 +242,12 @@ $methods
jvpp_facade_callback_method_template = Template("""
@Override
@SuppressWarnings("unchecked")
- public void on$callback_dto($plugin_package.$dto_package.$callback_dto reply) {
+ public void on$callback_dto(final $plugin_package.$dto_package.$callback_dto reply) {
$plugin_package.$callback_package.$callback callback;
+ final int replyId = reply.context;
synchronized(requests) {
- callback = ($plugin_package.$callback_package.$callback) requests.remove(reply.context);
+ callback = ($plugin_package.$callback_package.$callback) requests.remove(replyId);
}
if(callback != null) {