diff options
author | Vratko Polak <vrpolak@cisco.com> | 2019-10-14 13:06:18 +0200 |
---|---|---|
committer | Ole Trøan <otroan@employees.org> | 2019-10-14 18:49:22 +0000 |
commit | 8921dc675458b238fc03c5aed53d3462bcdbdb3c (patch) | |
tree | e28e6149bc7cbb237a023a93d212db05ae13f059 /src/vpp-api | |
parent | db056acca08900d05ef806a6bab74ea30b262f0f (diff) |
papi: fix socket sendall calls
No point in checking the return value,
as .sendall() raises on error
(and the previous check was missing "not").
Type: fix
Change-Id: I9e07709ddd7093f91ffef87808abbab264b8aa5a
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Diffstat (limited to 'src/vpp-api')
-rw-r--r-- | src/vpp-api/python/vpp_papi/vpp_transport_socket.py | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/vpp-api/python/vpp_papi/vpp_transport_socket.py b/src/vpp-api/python/vpp_papi/vpp_transport_socket.py index 3c1ea326198..c146c7b9386 100644 --- a/src/vpp-api/python/vpp_papi/vpp_transport_socket.py +++ b/src/vpp-api/python/vpp_papi/vpp_transport_socket.py @@ -188,10 +188,12 @@ class VppTransport(object): # Send header header = self.header.pack(0, len(buf), 0) - if self.socket.sendall(header) is None: - raise VppTransportSocketIOError(1, 'Failed to send') - if self.socket.sendall(buf) is None: - raise VppTransportSocketIOError(1, 'Failed to send') + try: + self.socket.sendall(header) + self.socket.sendall(buf) + except socket.error as err: + raise VppTransportSocketIOError(1, 'Sendall error: {err!r}'.format( + err=err)) def _read_fixed(self, size): """Repeat receive until fixed size is read. Return empty on error.""" |