diff options
| author |   Dave Wallace <dwallacelf@gmail.com> | 2017-10-24 01:32:41 -0400 |
|---|---|---|
| committer | Dave Wallace <dwallacelf@gmail.com> | 2017-10-24 01:32:41 -0400 |
| commit | 71612d61930e57e7c8ebf9e5647b15a4b23720b2 (patch) | |
| tree | 3c135af6d40442f5ae9f8397c62080e2b7e3f342 /src/vpp | |
| parent | 92b0275a364022af6ab828dfac83e38c0117cfe6 (diff) | |
Add extern to *_main global variable declarations in header files.
- Global variables declared in header files without
the use of the 'extern' keword will result in multiple
instances of the variable to be created by the compiler
-- one for each different source file in which the
the header file is included. This results in wasted
memory allocated in the BSS segments as well as
potentially introducing bugs in the application.
Change-Id: I6ef1790b60a0bd9dd3994f8510723decf258b0cc
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Diffstat (limited to 'src/vpp')
| -rw-r--r-- | src/vpp/api/plugin.h | 2 | ||||
| -rw-r--r-- | src/vpp/stats/stats.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/vpp/api/plugin.h b/src/vpp/api/plugin.h index 559ec52f128..c69186287aa 100644 --- a/src/vpp/api/plugin.h +++ b/src/vpp/api/plugin.h @@ -45,7 +45,7 @@ typedef struct } plugin_main_t; -plugin_main_t vat_plugin_main; +extern plugin_main_t vat_plugin_main; int vat_plugin_init (vat_main_t * vam); int vat_load_new_plugins (plugin_main_t * pm); diff --git a/src/vpp/stats/stats.h b/src/vpp/stats/stats.h index 042bcb65801..452e3052a10 100644 --- a/src/vpp/stats/stats.h +++ b/src/vpp/stats/stats.h @@ -184,7 +184,7 @@ typedef struct api_main_t *api_main; } stats_main_t; -stats_main_t stats_main; +extern stats_main_t stats_main; void dslock (stats_main_t * sm, int release_hint, int tag); void dsunlock (stats_main_t * sm); |