diff options
| author |   Benoît Ganne <bganne@cisco.com> | 2019-12-16 15:49:47 +0100 |
|---|---|---|
| committer |   Andrew Yourtchenko <ayourtch@gmail.com> | 2020-08-12 07:43:14 +0000 |
| commit | a699926a0dde50586510cd697b4cafc6cc51ab9e (patch) | |
| tree | 9aaf25e1a8a97beffd0b657bedeeb0e7664faadb /src | |
| parent | d8e41e7810d453396c49321d28d0d73b3b50c09b (diff) | |
vlib: fix vector-as-C-string overflow
Type: fix
Change-Id: If0419ff1a82d45e5b3326973008e1b9feb290c5a
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit 62d9fda8e474f87459c6e24d13b09f7bfec146f3)
Diffstat (limited to 'src')
| -rw-r--r-- | src/vlib/cli.c | 4 | ||||
| -rw-r--r-- | src/vlib/node_cli.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/vlib/cli.c b/src/vlib/cli.c index ec27c481374..c1cab16fe01 100644 --- a/src/vlib/cli.c +++ b/src/vlib/cli.c @@ -639,7 +639,7 @@ vlib_cli_dispatch_sub_commands (vlib_main_t * vm, u32 c; } *ed; ed = ELOG_DATA (&vm->elog_main, e); - ed->c = elog_string (&vm->elog_main, c->path); + ed->c = elog_string (&vm->elog_main, "%v", c->path); } if (!c->is_mp_safe) @@ -665,7 +665,7 @@ vlib_cli_dispatch_sub_commands (vlib_main_t * vm, u32 c, err; } *ed; ed = ELOG_DATA (&vm->elog_main, e); - ed->c = elog_string (&vm->elog_main, c->path); + ed->c = elog_string (&vm->elog_main, "%v", c->path); if (c_error) { vec_add1 (c_error->what, 0); diff --git a/src/vlib/node_cli.c b/src/vlib/node_cli.c index 32c6c1a4ef9..bf18702d582 100644 --- a/src/vlib/node_cli.c +++ b/src/vlib/node_cli.c @@ -606,7 +606,7 @@ show_node (vlib_main_t * vm, unformat_input_t * input, if (n->sibling_of) s = format (s, ", sibling-of %s", n->sibling_of); - vlib_cli_output (vm, "node %s, type %s, state %U, index %d%v\n", + vlib_cli_output (vm, "node %v, type %s, state %U, index %d%v\n", n->name, type_str, format_vlib_node_state, vm, n, n->index, s); vec_reset_length (s); |