aboutsummaryrefslogtreecommitdiffstats
path: root/test/asf/test_vppinfra.py
diff options
context:
space:
mode:
authorVladislav Grishenko <themiron@yandex-team.ru>2023-02-14 12:34:29 +0500
committerDamjan Marion <dmarion@0xa5.net>2023-03-06 14:31:47 +0000
commita20afdc845f4e901f7d3e6974e59a0dc2e8bf427 (patch)
treedd2360ee691903cd058af8fda23008be46e3ea73 /test/asf/test_vppinfra.py
parent1ee334c6f86b3e814aca1443ec7dfccdfc34ab26 (diff)
vppinfra: fix clib_bitmap_will_expand() result inversion
Pool's pool_put_will_expand() calls clib_bitmap_will_expand(), so every put except ones that leads to free_bitmap reallocation will get false positive results and vice versa. Unfortunatelly there's no related test and existing bitmap tests are failing silently with false positive result as well. Fortunatelly neither clib_bitmap_will_expand() nor pool_put_will_expand() are being used by current vpp codebase. Type: fix Signed-off-by: Vladislav Grishenko <themiron@yandex-team.ru> Change-Id: Id5bb900cf6a1b1002d37670f5c415c74165b5421
Diffstat (limited to 'test/asf/test_vppinfra.py')
-rw-r--r--test/asf/test_vppinfra.py15
1 files changed, 6 insertions, 9 deletions
diff --git a/test/asf/test_vppinfra.py b/test/asf/test_vppinfra.py
index 9151eb12c4d..4b49628cf58 100644
--- a/test/asf/test_vppinfra.py
+++ b/test/asf/test_vppinfra.py
@@ -8,8 +8,6 @@ from asfframework import VppTestCase, VppTestRunner
class TestVppinfra(VppTestCase):
"""Vppinfra Unit Test Cases"""
- vpp_worker_count = 1
-
@classmethod
def setUpClass(cls):
super(TestVppinfra, cls).setUpClass()
@@ -25,16 +23,15 @@ class TestVppinfra(VppTestCase):
super(TestVppinfra, self).tearDown()
def test_bitmap_unittest(self):
- """Bitmap Code Coverage Test"""
+ """Bitmap unit tests"""
+
cmds = ["test bitmap"]
for cmd in cmds:
- r = self.vapi.cli_return_response(cmd)
- if r.retval != 0:
- if hasattr(r, "reply"):
- self.logger.info(cmd + " FAIL reply " + r.reply)
- else:
- self.logger.info(cmd + " FAIL retval " + str(r.retval))
+ error = self.vapi.cli(cmd)
+ if error:
+ self.logger.critical(error)
+ self.assertNotIn("failed", error)
if __name__ == "__main__":