summaryrefslogtreecommitdiffstats
path: root/test/hook.py
diff options
context:
space:
mode:
authorPaul Vinciguerra <pvinci@vinciconsulting.com>2018-11-28 11:34:21 -0800
committerOle Trøan <otroan@employees.org>2019-02-26 09:39:00 +0000
commit38a4ec7342c27e675cc049d923e0075655fd91fd (patch)
treea9d42c77514ad103a8c7249a6cf88dc6bb988221 /test/hook.py
parent2bbbea0f88f24bc96198e841a7e8b984bfab87b3 (diff)
make test: Add exception handling around subprocess.
This cleans up exception catching to identify oserrors. By raising the specific exception closer to the offending call, we get additional stack history and can add clearer error logging to assist in troubleshooting. Change-Id: I592e4d46844b822a816485bf54910f8daed92088 Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Diffstat (limited to 'test/hook.py')
-rw-r--r--test/hook.py21
1 files changed, 16 insertions, 5 deletions
diff --git a/test/hook.py b/test/hook.py
index cddb603e46e..d23604ba13f 100644
--- a/test/hook.py
+++ b/test/hook.py
@@ -84,17 +84,28 @@ class PollHook(Hook):
super(PollHook, self).__init__(test)
def on_crash(self, core_path):
- self.logger.error("Core file present, debug with: gdb %s %s" %
- (self.test.vpp_bin, core_path))
+ self.logger.error("Core file present, debug with: gdb %s %s",
+ self.testcase.vpp_bin, core_path)
check_core_path(self.logger, core_path)
- self.logger.error("Running `file %s':" % core_path)
+ self.logger.error("Running `file %s':", core_path)
try:
info = check_output(["file", core_path])
self.logger.error(info)
except CalledProcessError as e:
self.logger.error(
- "Could not run `file' utility on core-file, "
- "rc=%s" % e.returncode)
+ "Subprocess returned with error running `file' utility on "
+ "core-file, "
+ "rc=%s", e.returncode)
+ except OSError as e:
+ self.logger.error(
+ "Subprocess returned OS error running `file' utility on "
+ "core-file, "
+ "oserror=(%s) %s", e.errno, e.strerror)
+ except Exception as e:
+ self.logger.error(
+ "Subprocess returned unanticipated error running `file' "
+ "utility on core-file, "
+ "%s", e)
def poll_vpp(self):
"""