diff options
| author |   Paul Vinciguerra <pvinci@vinciconsulting.com> | 2019-03-06 15:11:28 -0800 |
|---|---|---|
| committer |   Ole Trøan <otroan@employees.org> | 2019-03-11 08:09:23 +0000 |
| commit | 9a6dafd569db0d0b5dc9d7b5b34b17e3f411a9ee (patch) | |
| tree | 3459a0c6df3fd09548daa9c315145dd2aaf03775 /test/test_bihash.py | |
| parent | f70cead5eb928954908de48300cc7a9c88430c0f (diff) | |
Tests: use self.assertNotIn().
Many tests use self.assertEqual(error.find("failed"), -1)
Use self.assertNotIn("failed", error) to provide more meaningful errors such as
AssertionError: 'Failed' not found in '' instead of 0 != -1.
Change-Id: I670acdc977b788b2cedf94cfeafc12097781463f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Diffstat (limited to 'test/test_bihash.py')
| -rw-r--r-- | test/test_bihash.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/test_bihash.py b/test/test_bihash.py index ff2a898dae3..6ccf6c25123 100644 --- a/test/test_bihash.py +++ b/test/test_bihash.py @@ -25,7 +25,7 @@ class TestBihash(VppTestCase): if error: self.logger.critical(error) - self.assertEqual(error.find("failed"), -1) + self.assertNotIn('failed', error) def test_bihash_thread(self): """ Bihash Thread Test """ @@ -34,7 +34,7 @@ class TestBihash(VppTestCase): if error: self.logger.critical(error) - self.assertEqual(error.find("failed"), -1) + self.assertNotIn('failed', error) if __name__ == '__main__': unittest.main(testRunner=VppTestRunner) |