diff options
| author |   Neale Ranns <neale@graphiant.com> | 2022-02-17 09:08:47 +0000 |
|---|---|---|
| committer |   Ole Tr�an <otroan@employees.org> | 2022-03-04 16:14:11 +0000 |
| commit | 5c6dd17a373a2c56e57f02426d66a79af7faa19c (patch) | |
| tree | 154930db914285fda1636eb47faef2b1275e0190 /test/test_ip4.py | |
| parent | bc91e86674d446e024a957318d42a3bbd3280bf1 (diff) | |
ip: rate-limit the sending of ICMP error messages
Type: improvement
For error conditions, such as TTL expired, dest unreach, etc, Rate limit the sending of ICMP error messages.
The rate limiting is done based on src,dst IP address of the received packet.
the rate limit has been chosen, somewhat arbitrarily, to be 1e-3. This is the same limit as the ARP throttling.
Signed-off-by: Neale Ranns <neale@graphiant.com>
Change-Id: I4a0b791cde8c941a9bf37de6aa5da56779d3cef4
Diffstat (limited to 'test/test_ip4.py')
| -rw-r--r-- | test/test_ip4.py | 33 |
1 files changed, 16 insertions, 17 deletions
diff --git a/test/test_ip4.py b/test/test_ip4.py index de2cac0619e..873a38a22be 100644 --- a/test/test_ip4.py +++ b/test/test_ip4.py @@ -1947,16 +1947,15 @@ class TestIPInput(VppTestCase): UDP(sport=1234, dport=1234) / Raw(b'\xa5' * 100)) - rx = self.send_and_expect(self.pg0, p_ttl * NUM_PKTS, self.pg0) + rxs = self.send_and_expect_some(self.pg0, p_ttl * NUM_PKTS, self.pg0) - rx = rx[0] - icmp = rx[ICMP] - - self.assertEqual(icmptypes[icmp.type], "time-exceeded") - self.assertEqual(icmpcodes[icmp.type][icmp.code], - "ttl-zero-during-transit") - self.assertEqual(icmp.src, self.pg0.remote_ip4) - self.assertEqual(icmp.dst, self.pg1.remote_ip4) + for rx in rxs: + icmp = rx[ICMP] + self.assertEqual(icmptypes[icmp.type], "time-exceeded") + self.assertEqual(icmpcodes[icmp.type][icmp.code], + "ttl-zero-during-transit") + self.assertEqual(icmp.src, self.pg0.remote_ip4) + self.assertEqual(icmp.dst, self.pg1.remote_ip4) # # MTU exceeded @@ -1971,15 +1970,15 @@ class TestIPInput(VppTestCase): self.vapi.sw_interface_set_mtu(self.pg1.sw_if_index, [1500, 0, 0, 0]) - rx = self.send_and_expect(self.pg0, p_mtu * NUM_PKTS, self.pg0) - rx = rx[0] - icmp = rx[ICMP] + rxs = self.send_and_expect_some(self.pg0, p_mtu * NUM_PKTS, self.pg0) - self.assertEqual(icmptypes[icmp.type], "dest-unreach") - self.assertEqual(icmpcodes[icmp.type][icmp.code], - "fragmentation-needed") - self.assertEqual(icmp.src, self.pg0.remote_ip4) - self.assertEqual(icmp.dst, self.pg1.remote_ip4) + for rx in rxs: + icmp = rx[ICMP] + self.assertEqual(icmptypes[icmp.type], "dest-unreach") + self.assertEqual(icmpcodes[icmp.type][icmp.code], + "fragmentation-needed") + self.assertEqual(icmp.src, self.pg0.remote_ip4) + self.assertEqual(icmp.dst, self.pg1.remote_ip4) self.vapi.sw_interface_set_mtu(self.pg1.sw_if_index, [2500, 0, 0, 0]) rx = self.send_and_expect(self.pg0, p_mtu * NUM_PKTS, self.pg1) |