diff options
| author |   Klement Sekera <klement.sekera@gmail.com> | 2022-04-26 19:02:15 +0200 |
|---|---|---|
| committer |   Ole Tr�an <otroan@employees.org> | 2022-05-10 18:52:08 +0000 |
| commit | d9b0c6fbf7aa5bd9af84264105b39c82028a4a29 (patch) | |
| tree | 4f786cfd8ebc2443cb11e11b74c8657204068898 /test/test_l2tp.py | |
| parent | f90348bcb4afd0af2611cefc43b17ef3042b511c (diff) | |
tests: replace pycodestyle with black
Drop pycodestyle for code style checking in favor of black. Black is
much faster, stable PEP8 compliant code style checker offering also
automatic formatting. It aims to be very stable and produce smallest
diffs. It's used by many small and big projects.
Running checkstyle with black takes a few seconds with a terse output.
Thus, test-checkstyle-diff is no longer necessary.
Expand scope of checkstyle to all python files in the repo, replacing
test-checkstyle with checkstyle-python.
Also, fixstyle-python is now available for automatic style formatting.
Note: python virtualenv has been consolidated in test/Makefile,
test/requirements*.txt which will eventually be moved to a central
location. This is required to simply the automated generation of
docker executor images in the CI.
Type: improvement
Change-Id: I022a326603485f58585e879ac0f697fceefbc9c8
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Diffstat (limited to 'test/test_l2tp.py')
| -rw-r--r-- | test/test_l2tp.py | 20 |
1 files changed, 12 insertions, 8 deletions
diff --git a/test/test_l2tp.py b/test/test_l2tp.py index 5a665238260..13fa02ecc2c 100644 --- a/test/test_l2tp.py +++ b/test/test_l2tp.py @@ -11,7 +11,7 @@ from framework import VppTestCase @tag_fixme_vpp_workers class TestL2tp(VppTestCase): - """ L2TP Test Case """ + """L2TP Test Case""" @classmethod def setUpClass(cls): @@ -22,28 +22,32 @@ class TestL2tp(VppTestCase): cls.pg0.config_ip6() def test_l2tp_decap_local(self): - """ L2TP don't accept packets unless configured """ + """L2TP don't accept packets unless configured""" - pkt = (Ether(dst=self.pg0.local_mac, src=self.pg0.remote_mac) / - IPv6(src=self.pg0.remote_ip6, dst=self.pg0.local_ip6, nh=115)) + pkt = Ether(dst=self.pg0.local_mac, src=self.pg0.remote_mac) / IPv6( + src=self.pg0.remote_ip6, dst=self.pg0.local_ip6, nh=115 + ) self.pg0.add_stream(pkt) self.pg_start() # l2tp should not accept packets err = self.statistics.get_counter( - '/err/l2tp-decap-local/l2tpv3 session not found')[0] + "/err/l2tp-decap-local/l2tpv3 session not found" + )[0] self.assertEqual(err, 0) err_count = err - self.vapi.l2tpv3_create_tunnel(client_address=self.pg0.local_ip6, - our_address=self.pg0.remote_ip6) + self.vapi.l2tpv3_create_tunnel( + client_address=self.pg0.local_ip6, our_address=self.pg0.remote_ip6 + ) self.pg0.add_stream(pkt) self.pg_start() # l2tp accepts packets err = self.statistics.get_counter( - '/err/l2tp-decap-local/l2tpv3 session not found')[0] + "/err/l2tp-decap-local/l2tpv3 session not found" + )[0] self.assertEqual(err, 1) err_count = err |