diff options
| author |   Paul Vinciguerra <pvinci@vinciconsulting.com> | 2019-03-06 15:11:28 -0800 |
|---|---|---|
| committer |   Ole Trøan <otroan@employees.org> | 2019-03-11 08:09:23 +0000 |
| commit | 9a6dafd569db0d0b5dc9d7b5b34b17e3f411a9ee (patch) | |
| tree | 3459a0c6df3fd09548daa9c315145dd2aaf03775 /test/test_nat.py | |
| parent | f70cead5eb928954908de48300cc7a9c88430c0f (diff) | |
Tests: use self.assertNotIn().
Many tests use self.assertEqual(error.find("failed"), -1)
Use self.assertNotIn("failed", error) to provide more meaningful errors such as
AssertionError: 'Failed' not found in '' instead of 0 != -1.
Change-Id: I670acdc977b788b2cedf94cfeafc12097781463f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Diffstat (limited to 'test/test_nat.py')
| -rw-r--r-- | test/test_nat.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/test_nat.py b/test/test_nat.py index e368fe032cc..0ef30267088 100644 --- a/test/test_nat.py +++ b/test/test_nat.py @@ -7285,9 +7285,9 @@ class TestNAT64(MethodHolder): self.assertTrue(pg1_found) features = self.vapi.cli("show interface features pg0") - self.assertNotEqual(features.find('nat64-in2out'), -1) + self.assertIn('nat64-in2out', features) features = self.vapi.cli("show interface features pg1") - self.assertNotEqual(features.find('nat64-out2in'), -1) + self.assertIn('nat64-out2in', features) self.vapi.nat64_add_del_interface(self.pg0.sw_if_index, is_add=0) self.vapi.nat64_add_del_interface(self.pg1.sw_if_index, is_add=0) |