diff options
author | Neale Ranns <neale@graphiant.com> | 2022-02-17 09:08:47 +0000 |
---|---|---|
committer | Ole Tr�an <otroan@employees.org> | 2022-03-04 16:14:11 +0000 |
commit | 5c6dd17a373a2c56e57f02426d66a79af7faa19c (patch) | |
tree | 154930db914285fda1636eb47faef2b1275e0190 /test/test_reassembly.py | |
parent | bc91e86674d446e024a957318d42a3bbd3280bf1 (diff) |
ip: rate-limit the sending of ICMP error messages
Type: improvement
For error conditions, such as TTL expired, dest unreach, etc, Rate limit the sending of ICMP error messages.
The rate limiting is done based on src,dst IP address of the received packet.
the rate limit has been chosen, somewhat arbitrarily, to be 1e-3. This is the same limit as the ARP throttling.
Signed-off-by: Neale Ranns <neale@graphiant.com>
Change-Id: I4a0b791cde8c941a9bf37de6aa5da56779d3cef4
Diffstat (limited to 'test/test_reassembly.py')
-rw-r--r-- | test/test_reassembly.py | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/test/test_reassembly.py b/test/test_reassembly.py index 2291c933833..4c7a7cd320b 100644 --- a/test/test_reassembly.py +++ b/test/test_reassembly.py @@ -1326,8 +1326,7 @@ class TestIPv6Reassembly(VppTestCase): packets = self.dst_if.get_capture( len(self.pkt_infos) - len(dropped_packet_indexes)) self.verify_capture(packets, dropped_packet_indexes) - pkts = self.src_if.get_capture( - expected_count=len(dropped_packet_indexes)) + pkts = self.src_if._get_capture(1) for icmp in pkts: self.assertIn(ICMPv6TimeExceeded, icmp) self.assertIn(IPv6ExtHdrFragment, icmp) @@ -1372,8 +1371,7 @@ class TestIPv6Reassembly(VppTestCase): packets = self.dst_if.get_capture( len(self.pkt_infos) - len(dropped_packet_indexes)) self.verify_capture(packets, dropped_packet_indexes) - pkts = self.src_if.get_capture( - expected_count=len(dropped_packet_indexes)) + pkts = self.src_if._get_capture(1) for icmp in pkts: self.assertIn(ICMPv6TimeExceeded, icmp) self.assertIn(IPv6ExtHdrFragment, icmp) |