summaryrefslogtreecommitdiffstats
path: root/test/test_sctp.py
diff options
context:
space:
mode:
authorPaul Vinciguerra <pvinci@vinciconsulting.com>2019-03-06 15:11:28 -0800
committerOle Trøan <otroan@employees.org>2019-03-11 08:09:23 +0000
commit9a6dafd569db0d0b5dc9d7b5b34b17e3f411a9ee (patch)
tree3459a0c6df3fd09548daa9c315145dd2aaf03775 /test/test_sctp.py
parentf70cead5eb928954908de48300cc7a9c88430c0f (diff)
Tests: use self.assertNotIn().
Many tests use self.assertEqual(error.find("failed"), -1) Use self.assertNotIn("failed", error) to provide more meaningful errors such as AssertionError: 'Failed' not found in '' instead of 0 != -1. Change-Id: I670acdc977b788b2cedf94cfeafc12097781463f Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Diffstat (limited to 'test/test_sctp.py')
-rw-r--r--test/test_sctp.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/test/test_sctp.py b/test/test_sctp.py
index d7efc8c9353..70201eba360 100644
--- a/test/test_sctp.py
+++ b/test/test_sctp.py
@@ -66,7 +66,7 @@ class TestSCTP(VppTestCase):
"no-echo uri " + uri)
if error:
self.logger.critical(error)
- self.assertEqual(error.find("failed"), -1)
+ self.assertNotIn("failed", error)
error = self.vapi.cli("test echo client mbytes 10 no-return " +
" appns 1" +
@@ -76,7 +76,7 @@ class TestSCTP(VppTestCase):
" uri " + uri)
if error:
self.logger.critical(error)
- self.assertEqual(error.find("failed"), -1)
+ self.assertNotIn("failed", error)
# Delete inter-table routes
ip_t01.remove_vpp_config()