summaryrefslogtreecommitdiffstats
path: root/test/test_session.py
diff options
context:
space:
mode:
authorPaul Vinciguerra <pvinci@vinciconsulting.com>2019-03-06 15:11:28 -0800
committerOle Trøan <otroan@employees.org>2019-03-11 08:09:23 +0000
commit9a6dafd569db0d0b5dc9d7b5b34b17e3f411a9ee (patch)
tree3459a0c6df3fd09548daa9c315145dd2aaf03775 /test/test_session.py
parentf70cead5eb928954908de48300cc7a9c88430c0f (diff)
Tests: use self.assertNotIn().
Many tests use self.assertEqual(error.find("failed"), -1) Use self.assertNotIn("failed", error) to provide more meaningful errors such as AssertionError: 'Failed' not found in '' instead of 0 != -1. Change-Id: I670acdc977b788b2cedf94cfeafc12097781463f Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Diffstat (limited to 'test/test_session.py')
-rw-r--r--test/test_session.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/test/test_session.py b/test/test_session.py
index 5f4f3f5cfba..afea5f6a90d 100644
--- a/test/test_session.py
+++ b/test/test_session.py
@@ -68,14 +68,14 @@ class TestSession(VppTestCase):
"private-segment-size 1m uri " + uri)
if error:
self.logger.critical(error)
- self.assertEqual(error.find("failed"), -1)
+ self.assertNotIn("failed", error)
error = self.vapi.cli("test echo client nclients 100 appns 1 " +
"no-output fifo-size 64 syn-timeout 2 " +
"private-segment-size 1m uri " + uri)
if error:
self.logger.critical(error)
- self.assertEqual(error.find("failed"), -1)
+ self.assertNotIn("failed", error)
if self.vpp_dead:
self.assert_equal(0)
@@ -98,7 +98,7 @@ class TestSessionUnitTests(VppTestCase):
if error:
self.logger.critical(error)
- self.assertEqual(error.find("failed"), -1)
+ self.assertNotIn("failed", error)
def tearDown(self):
super(TestSessionUnitTests, self).tearDown()