summaryrefslogtreecommitdiffstats
path: root/test/test_vhost.py
diff options
context:
space:
mode:
authorPaul Vinciguerra <pvinci@vinciconsulting.com>2019-03-06 15:11:28 -0800
committerOle Trøan <otroan@employees.org>2019-03-11 08:09:23 +0000
commit9a6dafd569db0d0b5dc9d7b5b34b17e3f411a9ee (patch)
tree3459a0c6df3fd09548daa9c315145dd2aaf03775 /test/test_vhost.py
parentf70cead5eb928954908de48300cc7a9c88430c0f (diff)
Tests: use self.assertNotIn().
Many tests use self.assertEqual(error.find("failed"), -1) Use self.assertNotIn("failed", error) to provide more meaningful errors such as AssertionError: 'Failed' not found in '' instead of 0 != -1. Change-Id: I670acdc977b788b2cedf94cfeafc12097781463f Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Diffstat (limited to 'test/test_vhost.py')
-rw-r--r--test/test_vhost.py10
1 files changed, 5 insertions, 5 deletions
diff --git a/test/test_vhost.py b/test/test_vhost.py
index 469fadaf2cd..9a938214060 100644
--- a/test/test_vhost.py
+++ b/test/test_vhost.py
@@ -35,8 +35,8 @@ class TesVhostInterface(VppTestCase):
# verify both interfaces in the show
ifs = self.vapi.cli("show interface")
- self.assertNotEqual(ifs.find('VirtualEthernet0/0/0'), -1)
- self.assertNotEqual(ifs.find('VirtualEthernet0/0/1'), -1)
+ self.assertIn('VirtualEthernet0/0/0', ifs)
+ self.assertIn('VirtualEthernet0/0/1', ifs)
# verify they are in the dump also
if_dump = self.vapi.sw_interface_vhost_user_dump()
@@ -51,10 +51,10 @@ class TesVhostInterface(VppTestCase):
ifs = self.vapi.cli("show interface")
# verify VirtualEthernet0/0/0 still in the show
- self.assertNotEqual(ifs.find('VirtualEthernet0/0/0'), -1)
+ self.assertIn('VirtualEthernet0/0/0', ifs)
# verify VirtualEthernet0/0/1 not in the show
- self.assertEqual(ifs.find('VirtualEthernet0/0/1'), -1)
+ self.assertNotIn('VirtualEthernet0/0/1', ifs)
# verify VirtualEthernet0/0/1 is not in the dump
if_dump = self.vapi.sw_interface_vhost_user_dump()
@@ -71,7 +71,7 @@ class TesVhostInterface(VppTestCase):
# verify VirtualEthernet0/0/0 not in the show
ifs = self.vapi.cli("show interface")
- self.assertEqual(ifs.find('VirtualEthernet0/0/0'), -1)
+ self.assertNotIn('VirtualEthernet0/0/0', ifs)
# verify VirtualEthernet0/0/0 is not in the dump
if_dump = self.vapi.sw_interface_vhost_user_dump()