summaryrefslogtreecommitdiffstats
path: root/test/vpp_pg_interface.py
diff options
context:
space:
mode:
authorKlement Sekera <ksekera@cisco.com>2016-12-18 15:49:54 +0100
committerDamjan Marion <dmarion.lists@gmail.com>2016-12-19 21:33:42 +0000
commit65cc8c0dbf04f2418200e682caeae9c1e7396e10 (patch)
tree2ab9014753fd24cd197a3c52d7fb00cc2959315b /test/vpp_pg_interface.py
parent72d0916b82901496bed2f0cebf0cfc9968d239d4 (diff)
make test: filter IPv6 RAs out by default
Most of the test cases are not interested in IPv6 Router Alerts, so change the default behaviour of get_capture to filter out these packets with the possibility of turning the filtering off, for test cases which are interested in the RAs. Change-Id: I0b5ee685f82c49cd32c6d6a4638eb3493d2988fc Signed-off-by: Klement Sekera <ksekera@cisco.com>
Diffstat (limited to 'test/vpp_pg_interface.py')
-rw-r--r--test/vpp_pg_interface.py34
1 files changed, 29 insertions, 5 deletions
diff --git a/test/vpp_pg_interface.py b/test/vpp_pg_interface.py
index 44bd1a2d520..634d7d3e14a 100644
--- a/test/vpp_pg_interface.py
+++ b/test/vpp_pg_interface.py
@@ -5,10 +5,22 @@ from vpp_interface import VppInterface
from scapy.layers.l2 import Ether, ARP
from scapy.layers.inet6 import IPv6, ICMPv6ND_NS, ICMPv6ND_NA,\
- ICMPv6NDOptSrcLLAddr, ICMPv6NDOptDstLLAddr
+ ICMPv6NDOptSrcLLAddr, ICMPv6NDOptDstLLAddr, ICMPv6ND_RA, RouterAlert, \
+ IPv6ExtHdrHopByHop
from util import ppp, ppc
+def is_ipv6_misc(p):
+ """ Is packet one of uninteresting IPv6 broadcasts? """
+ if p.haslayer(ICMPv6ND_RA):
+ return True
+ if p.haslayer(IPv6ExtHdrHopByHop):
+ for o in p[IPv6ExtHdrHopByHop].options:
+ if isinstance(o, RouterAlert):
+ return True
+ return False
+
+
class VppPGInterface(VppInterface):
"""
VPP packet-generator interface
@@ -118,15 +130,19 @@ class VppPGInterface(VppInterface):
# FIXME this should be an API, but no such exists atm
self.test.vapi.cli(self.input_cli)
- def get_capture(self, remark=None):
+ def get_capture(self, remark=None, filter_fn=is_ipv6_misc):
"""
Get captured packets
+ :param remark: remark printed into debug logs
+ :param filter_fn: filter applied to each packet, packets for which
+ the filter returns True are removed from capture
:returns: iterable packets
"""
try:
self.wait_for_capture_file()
output = rdpcap(self.out_path)
+ self.test.logger.debug("Capture has %s packets" % len(output.res))
except IOError: # TODO
self.test.logger.debug("File %s does not exist, probably because no"
" packets arrived" % self.out_path)
@@ -135,12 +151,20 @@ class VppPGInterface(VppInterface):
(self.name, remark))
else:
raise Exception("No packets captured on %s" % self.name)
+ before = len(output.res)
+ if filter_fn:
+ output.res = [p for p in output.res if not filter_fn(p)]
+ removed = len(output.res) - before
+ if removed:
+ self.test.logger.debug(
+ "Filtered out %s packets from capture (returning %s)" %
+ (removed, len(output.res)))
return output
def assert_nothing_captured(self, remark=None):
if os.path.isfile(self.out_path):
try:
- capture = self.get_capture()
+ capture = self.get_capture(remark=remark)
self.test.logger.error(
ppc("Unexpected packets captured:", capture))
except:
@@ -234,7 +258,7 @@ class VppPGInterface(VppInterface):
self.test.pg_start()
self.test.logger.info(self.test.vapi.cli("show trace"))
try:
- arp_reply = pg_interface.get_capture()
+ arp_reply = pg_interface.get_capture(filter_fn=None)
except:
self.test.logger.info("No ARP received on port %s" %
pg_interface.name)
@@ -274,7 +298,7 @@ class VppPGInterface(VppInterface):
pg_interface.enable_capture()
self.test.pg_start()
self.test.logger.info(self.test.vapi.cli("show trace"))
- replies = pg_interface.get_capture()
+ replies = pg_interface.get_capture(filter_fn=None)
if replies is None or len(replies) == 0:
self.test.logger.info(
"No NDP received on port %s" %