diff options
| author |   Klement Sekera <klement.sekera@gmail.com> | 2022-04-26 19:02:15 +0200 |
|---|---|---|
| committer |   Ole Tr�an <otroan@employees.org> | 2022-05-10 18:52:08 +0000 |
| commit | d9b0c6fbf7aa5bd9af84264105b39c82028a4a29 (patch) | |
| tree | 4f786cfd8ebc2443cb11e11b74c8657204068898 /test/vpp_pppoe_interface.py | |
| parent | f90348bcb4afd0af2611cefc43b17ef3042b511c (diff) | |
tests: replace pycodestyle with black
Drop pycodestyle for code style checking in favor of black. Black is
much faster, stable PEP8 compliant code style checker offering also
automatic formatting. It aims to be very stable and produce smallest
diffs. It's used by many small and big projects.
Running checkstyle with black takes a few seconds with a terse output.
Thus, test-checkstyle-diff is no longer necessary.
Expand scope of checkstyle to all python files in the repo, replacing
test-checkstyle with checkstyle-python.
Also, fixstyle-python is now available for automatic style formatting.
Note: python virtualenv has been consolidated in test/Makefile,
test/requirements*.txt which will eventually be moved to a central
location. This is required to simply the automated generation of
docker executor images in the CI.
Type: improvement
Change-Id: I022a326603485f58585e879ac0f697fceefbc9c8
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Diffstat (limited to 'test/vpp_pppoe_interface.py')
| -rw-r--r-- | test/vpp_pppoe_interface.py | 28 |
1 files changed, 14 insertions, 14 deletions
diff --git a/test/vpp_pppoe_interface.py b/test/vpp_pppoe_interface.py index 505ac4c6425..0d5516eab60 100644 --- a/test/vpp_pppoe_interface.py +++ b/test/vpp_pppoe_interface.py @@ -1,4 +1,3 @@ - from vpp_interface import VppInterface import socket from vpp_papi import mac_pton @@ -9,9 +8,8 @@ class VppPppoeInterface(VppInterface): VPP Pppoe interface """ - def __init__(self, test, client_ip, client_mac, - session_id, decap_vrf_id=0): - """ Create VPP PPPoE4 interface """ + def __init__(self, test, client_ip, client_mac, session_id, decap_vrf_id=0): + """Create VPP PPPoE4 interface""" super(VppPppoeInterface, self).__init__(test) self.client_ip = client_ip self.client_mac = client_mac @@ -21,9 +19,11 @@ class VppPppoeInterface(VppInterface): def add_vpp_config(self): r = self.test.vapi.pppoe_add_del_session( - self.client_ip, self.client_mac, - session_id=self.session_id, - decap_vrf_id=self.decap_vrf_id) + self.client_ip, + self.client_mac, + session_id=self.session_id, + decap_vrf_id=self.decap_vrf_id, + ) self.set_sw_if_index(r.sw_if_index) self.vpp_sw_if_index = r.sw_if_index self.generate_remote_hosts() @@ -31,12 +31,12 @@ class VppPppoeInterface(VppInterface): def remove_vpp_config(self): self.unconfig() self.test.vapi.pppoe_add_del_session( - self.client_ip, self.client_mac, - session_id=self.session_id, - decap_vrf_id=self.decap_vrf_id, - is_add=0) + self.client_ip, + self.client_mac, + session_id=self.session_id, + decap_vrf_id=self.decap_vrf_id, + is_add=0, + ) def set_unnumbered(self, swif_iface): - self.test.vapi.sw_interface_set_unnumbered( - swif_iface, - self.vpp_sw_if_index) + self.test.vapi.sw_interface_set_unnumbered(swif_iface, self.vpp_sw_if_index) |