BFD: improve ip header handling, fix assert

Instead of storing a pointer, store an offset within vlib_buffer marking
the start of the ip header (similar to storing start of ethernet
header). Handle negative timeout in the bfd process main loop.

Change-Id: I05a1ff3ac41da5bdc3b2ac6f9e03b3241994688b
Signed-off-by: Klement Sekera <ksekera@cisco.com>

2 files changed, 3 insertions, 0 deletions

diff --git a/test/framework.py b/test/framework.py
index aa4f2fdf8fc..e1f3ba54b57 100644
--- a/test/framework.py
+++ b/test/framework.py
@@ -278,6 +278,8 @@ class VppTestCase(unittest.TestCase):
 
     def setUp(self):
         """ Clear trace before running each test"""
+        if self.vpp_dead:
+            raise Exception("VPP is dead when setting up the test")
         self.vapi.cli("clear trace")
         # store the test instance inside the test class - so that objects
         # holding the class can access instance methods (like assertEqual)
diff --git a/test/test_bfd.py b/test/test_bfd.py
index 20d3aea5e0c..58f1264543c 100644
--- a/test/test_bfd.py
+++ b/test/test_bfd.py
@@ -128,6 +128,7 @@ class BFDTestCase(VppTestCase):
             raise
 
     def setUp(self):
+        super(BFDTestCase, self).setUp()
         self.vapi.want_bfd_events()
         self.vpp_session = VppBFDUDPSession(self, self.pg0, self.pg0.remote_ip4)
         self.vpp_session.add_vpp_config()