diff options
author | Neale Ranns <nranns@cisco.com> | 2020-09-23 11:25:21 +0000 |
---|---|---|
committer | Ole Tr�an <otroan@employees.org> | 2020-10-08 09:04:05 +0000 |
commit | 22eefd79a1817ce6d0da3b20412eb61ce718cbaf (patch) | |
tree | a3b4145fcd57f4284e1823329586ec73bdc80397 /test | |
parent | 47a3d9975fa3af7a7537b565d6511dadc0df61fb (diff) |
ip-neighbor: Grat ARPs from different subnet are dropped
Type: test
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Id07e8981a903f11f50fb494a93d01815382025e4
Diffstat (limited to 'test')
-rw-r--r-- | test/test_neighbor.py | 31 | ||||
-rw-r--r-- | test/vpp_neighbor.py | 3 |
2 files changed, 33 insertions, 1 deletions
diff --git a/test/test_neighbor.py b/test/test_neighbor.py index 1045f4ba1e9..dfefb151091 100644 --- a/test/test_neighbor.py +++ b/test/test_neighbor.py @@ -1435,6 +1435,7 @@ class ARPTestCase(VppTestCase): # Generate some hosts on the LAN # self.pg1.generate_remote_hosts(4) + self.pg2.generate_remote_hosts(4) # # And an ARP entry @@ -1526,6 +1527,36 @@ class ARPTestCase(VppTestCase): self.pg1.sw_if_index, self.pg1.remote_hosts[2].ip4)) + # + # IP address in different subnets are not learnt + # + self.pg2.configure_ipv4_neighbors() + + for op in ["is-at", "who-has"]: + p1 = [(Ether(dst="ff:ff:ff:ff:ff:ff", + src=self.pg2.remote_hosts[1].mac) / + ARP(op=op, + hwdst=self.pg2.local_mac, + hwsrc=self.pg2.remote_hosts[1].mac, + pdst=self.pg2.remote_hosts[1].ip4, + psrc=self.pg2.remote_hosts[1].ip4)), + (Ether(dst="ff:ff:ff:ff:ff:ff", + src=self.pg2.remote_hosts[1].mac) / + ARP(op=op, + hwdst="ff:ff:ff:ff:ff:ff", + hwsrc=self.pg2.remote_hosts[1].mac, + pdst=self.pg2.remote_hosts[1].ip4, + psrc=self.pg2.remote_hosts[1].ip4))] + + self.send_and_assert_no_replies(self.pg1, p1) + self.assertFalse(find_nbr(self, + self.pg1.sw_if_index, + self.pg2.remote_hosts[1].ip4)) + + # they are all dropped because the subnet's don't match + self.assertEqual(4, self.statistics.get_err_counter( + "/err/arp-reply/IP4 destination address not local to subnet")) + def test_arp_incomplete(self): """ Incomplete Entries """ diff --git a/test/vpp_neighbor.py b/test/vpp_neighbor.py index ffe87d93b58..6f5426180fb 100644 --- a/test/vpp_neighbor.py +++ b/test/vpp_neighbor.py @@ -20,7 +20,8 @@ def find_nbr(test, sw_if_index, nbr_addr, is_static=0, mac=None): af=ip_addr.vapi_af) for n in nbrs: - if ip_addr == n.neighbor.ip_address and \ + if sw_if_index == n.neighbor.sw_if_index and \ + ip_addr == n.neighbor.ip_address and \ is_static == (n.neighbor.flags & e.IP_API_NEIGHBOR_FLAG_STATIC): if mac: if mac == str(n.neighbor.mac_address): |