summaryrefslogtreecommitdiffstats
path: root/vnet/vnet/ipsec/ipsec_cli.c
diff options
context:
space:
mode:
authorDamjan Marion <damarion@cisco.com>2016-08-16 11:27:02 +0200
committerFlorin Coras <florin.coras@gmail.com>2016-08-17 08:21:42 +0000
commit3f54b18e055a606dd0ade78a370eebb758d8be7d (patch)
treea1e449d7f324401534130f377c83afb7efee8dea /vnet/vnet/ipsec/ipsec_cli.c
parent607de1a0638fa45db49295f9ed51a7f9a5e38706 (diff)
Fix coverity issues in IPSec code, fixes VPP-189
Change-Id: I4e43606884ebad9a84abda779b82417192727ef3 Signed-off-by: Damjan Marion <damarion@cisco.com>
Diffstat (limited to 'vnet/vnet/ipsec/ipsec_cli.c')
-rw-r--r--vnet/vnet/ipsec/ipsec_cli.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/vnet/vnet/ipsec/ipsec_cli.c b/vnet/vnet/ipsec/ipsec_cli.c
index f25547003b6..8b15110af0d 100644
--- a/vnet/vnet/ipsec/ipsec_cli.c
+++ b/vnet/vnet/ipsec/ipsec_cli.c
@@ -171,7 +171,7 @@ ipsec_spd_add_del_command_fn (vlib_main_t * vm,
vlib_cli_command_t * cmd)
{
unformat_input_t _line_input, *line_input = &_line_input;
- u32 spd_id;
+ u32 spd_id = ~0;
int is_add = ~0;
if (!unformat_user (input, unformat_line_input, line_input))
@@ -192,6 +192,9 @@ ipsec_spd_add_del_command_fn (vlib_main_t * vm,
unformat_free (line_input);
+ if (spd_id == ~0)
+ return clib_error_return (0, "please specify SPD ID");
+
ipsec_add_del_spd (vm, spd_id, is_add);
return 0;