diff options
| author |   Robert Varga <nite@hq.sk> | 2016-01-31 12:25:45 +0100 |
|---|---|---|
| committer |   Dave Wallace <dwallacelf@gmail.com> | 2016-02-01 03:00:39 +0000 |
| commit | 004da76d2b83276a1fccf1876494ba0038816c68 (patch) | |
| tree | 3d172effcdf0fb1cc9e722a0e8d5049a0460d268 /vpp-japi/japi/org/openvpp/vppjapi/vppIPv6Address.java | |
| parent | 52a3a4de071cae9fe8cad4227ab44627721ae175 (diff) | |
Make public fields final where possible
Class fields initialized via the constructor should be final.
Also mark leaking byte[] instances with a FIXME. API users consider them
immutable, but they are vulnerable to System.arrayCopy().
Also fixes constructor arguments so they do not use underscores, which
is prohibited by Java 9.
Change-Id: I393d55ed7234149cb3604bc92b2cb1d1207c55dc
Signed-off-by: Robert Varga <nite@hq.sk>
Diffstat (limited to 'vpp-japi/japi/org/openvpp/vppjapi/vppIPv6Address.java')
| -rw-r--r-- | vpp-japi/japi/org/openvpp/vppjapi/vppIPv6Address.java | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/vpp-japi/japi/org/openvpp/vppjapi/vppIPv6Address.java b/vpp-japi/japi/org/openvpp/vppjapi/vppIPv6Address.java index efaa89c2ad5..7bf10f23402 100644 --- a/vpp-japi/japi/org/openvpp/vppjapi/vppIPv6Address.java +++ b/vpp-japi/japi/org/openvpp/vppjapi/vppIPv6Address.java @@ -16,8 +16,9 @@ package org.openvpp.vppjapi; public class vppIPv6Address { - public byte[] ip; - public byte prefixLength; + // FIXME: this is dangerous + public final byte[] ip; + public final byte prefixLength; public vppIPv6Address(byte[] _ip, byte _prefixLength) { ip = _ip; |