aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-06-15Fix double-enqueued packet in interface-output dual-loop, fixes VPP-116Damjan Marion2-19/+42
When speculative enqueue fails and a buffer needs to be moved to a new node queue the original buffer is not correctly removed from the original queue so buffer get send for transmit and encryption at the same time. This issue will only be hit with the double loop so low throughput traffic like pings will not hit the issue. This code path is also only hit when the feature flag is enabled so will not be hit by normal traffic Patch also reorgnizes code to reduce number of branches in the interface output node loop. Change-Id: I3653400e58bdfd833e6c42823bab51586128b54b Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com> Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-06-15Reset new indirect adjacdncy template before using itDamjan Marion2-0/+4
Change-Id: Ia69ba39364d4dfa1403c8fbb77b7990226bbcb85 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-06-13VPP-117: Fix ip4 and ip6 lookup and rewrite tracesPierre Pfister2-68/+95
Previous patch was printing wrong data since rewrite node traces an ethernet packet while other ip nodes trace an IP packet. This patch introduces different tracing functions for: - lookup node (where the fib index is valid) - rewrite node (where an ethernet frame is available) - other ip nodes (only the ip header is traced) Change-Id: I5971a2e89ae8668f5aed4a410565a5f27e01fc22 Signed-off-by: Pierre Pfister <ppfister@cisco.com>
2016-06-09VPP-106: fix performance hit due to unprefetched data readDave Barach4-47/+17
Change-Id: I1325b60b6deadcb51631e178011a31ee70c06cc7 Signed-off-by: Dave Barach <dave@barachs.net>
2016-06-09VPP-117: Add trace to ip4 and ip6 lookup nodesPierre Pfister4-19/+84
The absence of trace in ip lookup nodes is misleading to many people. This patch adds ip lookup tracing and therefore contribute to worldwide happiness. In addition, this patch makes sure sw_if_index[VLIB_TX] is considered when tracing the fib_index value. In ip4/6-rewrite, the value corresponds to the tx interface index. The formatting function is therefore modified to take that case into account. Change-Id: I5915f0446a15c45e391eedfdfcedd9057aa6a237 Signed-off-by: Pierre Pfister <ppfister@cisco.com>
2016-06-09VPP-127 Removed spurious use of sudoEd Warnicke2-2/+2
Change-Id: I1eb18fc6379db30fb802e3b929931788f54e7dc2 Signed-off-by: Ed Warnicke <eaw@cisco.com>
2016-06-09VPP-115: Remove stale ACL CLIs which are not supportedJohn Lo2-39/+3
The old ACL CLIs still show up in CLI help which can confuse users. Change-Id: I9a3722d3d649c4370df6a09b2c07628e7e4aa0f4 Signed-off-by: John Lo <loj@cisco.com>
2016-06-09VPP-127: Make rpm/deb provide vpp group to access vpp-apiEd Warnicke4-0/+16
Change-Id: I005f971ec5bfbffc5ddd392ff5ae829186b2bf18 Signed-off-by: Ed Warnicke <eaw@cisco.com> (cherry picked from commit 1f9933d9f0c4615334f4af168dc063a7f1f2d649) Signed-off-by: Ed Warnicke <eaw@cisco.com>
2016-06-08VPP-129: Add build-root/scripts/csit-test-branch scriptEd Warnicke1-0/+2
This script returns the csit branch that should be used for testing and verification. Related to csit patch: https://gerrit.fd.io/r/#/c/1344/ Change-Id: I51e44e4ba4dc433056ac8a870f8b7c7f9518189b Signed-off-by: Ed Warnicke <eaw@cisco.com>
2016-06-08VPP-124: Fix rpms to work out of the box.Ed Warnicke3-1/+17
Currently, for vpp we are not building any rpms for dpdk or igb_uio. This is because uio_pci_generic as shipped with centos works with vpp. However, our vpp rpms do not install kernel module uio_pci_generic at start up and the /etc/vpp/startup.conf does not configure vpp to use uio_pci_generic. vpp rpms should do both, so that when the vpp rpm is installed and vpp started, it just works out of the box. This patch fixes the rpms to do so. Change-Id: Ib934b51f9271cded466d235aa4044bef75c35960 Signed-off-by: Ed Warnicke <eaw@cisco.com> (cherry picked from commit 40c66394280365ed6b1c5b8f569254f668f80cdb)
2016-06-07VPP-83: fix collateral damagev16.06-rc3Dave Barach1-0/+1
Accidentally removed pthread_mutex_unlock (&root_rp->mutex) in the dead client scan case. Oops. Bad idea. Change-Id: I488b7e39d01c267052785bd346e8846351db90a9 Signed-off-by: Dave Barach <dave@barachs.net>
2016-06-06ONE-18: Fix trailing garbage string in LISP status dump APIFilip Tehlar1-0/+2
Change-Id: I5cba5eae5a981e41df3f227834a079e10982537f Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2016-06-05VPP-112: linux kernel info missing from build logDave Wallace1-0/+9
Change-Id: I343418d409d682b00e74e41236382fdc6b3c780c Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2016-06-04VPP-113: BVI shall filter unicast DMAC for L2 to L3 forwadingJohn Lo5-15/+26
As BVI receive a packet with unicast DMAC from the BD, including unknown unicast flood packet, the packet should not be L3 forwarded unless its DMAC matches the MAC of the BVI. Change-Id: I46e18629c901062592c8ebe3a238c5cfdc1096b4 Signed-off-by: John Lo <loj@cisco.com>
2016-06-03VPP-100: Fix IP4 local handling of TCP/IP fragmented packetJohn Lo1-3/+3
Fix previous change that does not work on little endian machines. Use inline call ip4_is_fragment() which is endian neutral. Change-Id: I5a35d89d936650ab6c628dfc388b8c992a74a589 Signed-off-by: John Lo <loj@cisco.com>
2016-06-03VPP-91 fix sr tunnel add_del collision checkv16.06-rc2Chris Luke1-58/+85
The add_del function was not properly checking if a tunnel already existed; instead it was checking if the given tunnel name existed. If no tunnel name was given it flat out refused to add a tunnel even though that is optional. Cleanup the add/del parameter validation to "do what I expect" it to do: When adding a tunnel: - If a "name" is given, it must not exist. - The "key" is always checked, and must not exist. When deleting a tunnel: - If the "name" is given, and it exists, then use it. - If the "name" is not given, use the "key". - If the "name" and the "key" are given, then both must point to the same thing. Change-Id: I9b48ae0203f9664cf8af0f7dc49bf480ddec10d5 Signed-off-by: Chris Luke <chrisy@flirble.org> (cherry picked from commit e54436005341800f76a584299ef8bf99e8d66227)
2016-06-03VPP-92 Fixup some srv6 issuesChris Luke2-60/+70
Some small fixes to the srv6 code to bring it toward conformance with draft-previdi-6man-segment-routing-header-05. - The first segment needs to remain in the segment list. - The segment list template needs a space for the ultimate destination. - The ultimate destination needs to be inserted into that space when adding the SRH. Change-Id: I66db6912e0128da084f14ceca20918ef67ccff79 Signed-off-by: Chris Luke <chrisy@flirble.org> (cherry picked from commit 4b8b718ff9bbba3bea018505ac591bb737f68001)
2016-06-03VPP-107 Fix for mistake that breaks pkg-rpm inEd Warnicke1-0/+1
https://gerrit.fd.io/r/#/c/1338/ Change-Id: I8b7fffe24cbeb435b18faaada9ef1cea9fd93d39 Signed-off-by: Ed Warnicke <eaw@cisco.com>
2016-06-02VPP-106: Patch e40i driver to support VLAN sub-interfaceJohn Lo1-0/+41
Check packet for presence of VLAN tag in the MAC header and set the PKT_RX_VLAN_PKT flag to trigger sub-interface lookup in VPP ethernet-input node. Change-Id: Iadbfc59d08ef85efb936c88323a90194f3cd656f Signed-off-by: John Lo <loj@cisco.com>
2016-06-02VPP-100: Fix IPv4 local handling of IP fragmented packetsJohn Lo1-3/+7
Before VPP is enhenced to do IP reassembly of local packets, just set the protocol path to "experimental" for now so they will be error-punted as unknow IP protocol. Change-Id: I2ffefb0b4205357653ba24d80c722cafd5972fba Signed-off-by: John Lo <loj@cisco.com>
2016-06-01VPP-105 Map API SHM uid/gid name to numberChris Luke1-1/+53
When providing uid or gid for the API SHM, if non-numeric values are given look them up in the local system user database and if found use the values discovered. Change-Id: I95152f58646643bc44d2af4cbad6338901935c69 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-06-01VPP-98 Dedicated storage for VXLAN over IPv6 hash keysChris Luke3-53/+66
When creating VXLAN over IPv6 the code was using storage for the hash key that could later be moved. Since the key is larger than the word size this was being referenced as a pointer; when the storage moves that breaks the hash. Instead allocate dedicated storage for the key. This patch also includes other minor cleanups, including using clib_memcpy in places it should be used and some whitespace fixes. Change-Id: I579f2cb515853ef56dedcca350fcad08aa6111a9 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-06-01VPP-83 Allow non-privileged clients to use the vpp binary API.Dave Barach10-61/+108
Use the command line argument "api-segment { uid <nnn> gid <nnn> }" to configure shared memory segment file ownership. Defaults to uid = gid = 0. Shared-memory segments are explicitly set to 0770 mode, aka "rwxrwx---". Change-Id: Ic5d596b68139add61e7de6ace035c57dfd030111 Signed-off-by: Dave Barach <dave@barachs.net>
2016-05-31VPP-102: vHost reconnect to previously used sockets on VPP restartJohn Lo1-0/+8
Change-Id: Ida11bddb52268e0e8513b7b379eeed6103bd48f1 Signed-off-by: John Lo <loj@cisco.com>
2016-05-31Fix build-root/scripts/version to not have spurious ~Ed Warnicke1-3/+2
Change-Id: Id28f134e3a4aa19c5756014d53004501db0d0c88 Signed-off-by: Ed Warnicke <eaw@cisco.com>
2016-05-31VPP97: Flooding of pkts with multiple buffers in BD with BVI crashes VPPJohn Lo2-9/+3
The loopback interface should use vnet_interface_output_no_flatten so follow-on buffers of a jumbo packet do not get put on the output frame and be sent back to ethernet-input or l2-input node. The replication_recycle_callback() function should not assume follow-on buffers of a jumbo packet are on the buffer free list. Change-Id: Ide646a6d9b43e82782c0581ea3022a9e70f82582 Signed-off-by: John Lo <loj@cisco.com>
2016-05-30ONE-15: Fix duplicate locator, refactoring locatorAndrej Kozemcak3-246/+157
Check duplication locator and clean after locator when remove it. Refactoring locator_set code. Change-Id: Ib83cbcddc7a363a60fa5b6a366203d0dc0ea7ca6 Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
2016-05-28VPP-96 ENID driver update for rx of jumbo pkts using muliple mbuf'sJohn Lo4-2/+800
Change-Id: I0e985b079da3224f4886e3ee2cece4d046e291eb Signed-off-by: John Lo <loj@cisco.com>
2016-05-27VPP-95 VXLAN add_del API intermittent failureChris Luke2-3/+3
The VXLAN add_del API sometimes rejects calls with VNET_API_ERROR_SAME_SRC_DST when the two parameters are obviously different. This is because the API code is checking the "is_ip6" flag in a not-yet initialized area of memory leading to random results. Also fix help text for vxlan_add_del_tunnel in vat. This does not change the API; it repairs intermittent failure. Change-Id: I41863694f478c1f669078f82f69d8cca4841c989 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-05-25ONE-14: Fix crash when re-enable LispAndrej Kozemcak1-4/+9
Change-Id: Ib95338d7055dea9036eddb7dff5ca7ccbcb35639 Signed-off-by: Andrej Kozemcak <akozemca@cisco.com> (cherry picked from commit 94e34764b46a2babcaea6b309158524a7c1bb632)
2016-05-25VPP-89: Fix an issue in format_vxlan_gpe_tunnelHongjun Ni1-0/+4
Change-Id: Ie81e2eb918e441ddaa9e7ab57e8bb0129f0f4f8f Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
2016-05-24VPP-86: fix array copy in generated JNI codeMarek Gradzki4-22/+174
Change-Id: Ic67b3c0623d98c5ee3f1ffa1e1bd9cfb96b233bd Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2016-05-20VPP-77 Creating VXLAN over IPv6 via API failsChris Luke1-2/+2
Tunnel dst is incorrectly being set to the requested src address. Change-Id: I44e2ee475f0572e78d148951c5d4684e85e08ce7 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-05-16Add newline to the end of .gitreviewEd Warnicke1-1/+1
Change-Id: I9a5a97c4a42b8aebbb6ba132879b7843ca7cfacd Signed-off-by: Ed Warnicke <eaw@cisco.com>
2016-05-16Initial changes for stable/1606 branchv16.06-rc1Ed Warnicke2-1/+2
This patch adds an entry for the defaultbranch in .gitreview and also changes the generated jar file version to 16.06. Change-Id: I9acd35745eee7daa90d9abcc33e75b76c11af76e Signed-off-by: Ed Warnicke <eaw@cisco.com>
2016-05-16VPP-61 Patch2/2 Removing NSH from VPP for move to NSH_SFCKeith Burns (alagalah)10-1038/+5
Change-Id: I76359b621b2edc599cf2e9ee845d97293a5d46f7 Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
2016-05-16VPP-61 Patch1/2 - Remove NSH from VPPKeith Burns (alagalah)6-127/+0
- Had issues with original patch and CSIT, breaking into -- Makefile and API changes -- Follow up patch removing NSH directory Change-Id: I6c2f49a74d59b97ce4ea43799cc6f01f5cb1d5a2 Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
2016-05-16VPP-58: Fix build on AMD OpteronDamjan Marion1-1/+1
Change-Id: Ib3e10fd4c27dde4f90b8d156f0c8547787ad46e2 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-05-16Add build number to VPP version if BUILD_NUMBER var is setDamjan Marion1-2/+6
Change-Id: I73ecc12224fdfb08b7aa6118761b368577ce33d5 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-05-16Add configure policer APIMatus Fabian6-47/+253
JIRA: VPP-67 Change-Id: I04560d78e2eb131cd6cc31472b70b3d3e8fdd79a Signed-off-by: Matus Fabian <matfabia@cisco.com>
2016-05-16VPP-68: L2 Rewrite: Support for chained classify tablesPierre Pfister1-0/+18
The classifying capabilities are pretty limited if only a single table can be used. This patch adds support for chained classify tables to L2 Rewrite feature. Change-Id: Ib678fe2028f17b441adb75d85bf3e31185e42c59 Signed-off-by: Pierre Pfister <ppfister@cisco.com>
2016-05-16VPP-69: Create fib or bridge domain with arbitrary IDPierre Pfister6-3/+89
It appeared to me that it might be usefull to allow users to create fibs or bridge domains without a complete knowledge of the current used IDs. These changes define fib and bridge domain constructors when the provided ID is ~0. In such a case, an unused ID is used to create a new fib or bridge domain. Change-Id: Iaba69a023296e6d17bdde45980f9db84832a3995 Signed-off-by: Pierre Pfister <ppfister@cisco.com>
2016-05-16VPP-57 Add missing license headers in doc filesChris Luke8-0/+134
Change-Id: Icd1f8952f66d3cee027c59f3148c67f1839de306 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-05-16VPP-64: Fix top-level "make pkg-deb" which breaks if CDPATH is set in the user'sDave Wallace1-0/+9
bash environment. Change-Id: Ib13e6fdafa67175937e57fad4e75e553cb1e08a3 Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2016-05-16VPP-65: Fix top-level "make install-dep" to work behind a firewall /Dave Wallace1-4/+4
proxy-server on Ubuntu. Change-Id: I3f662455728adb81ca5a079540d8a9c615a5b977 Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2016-05-15ONE-13: Add CLI/API for LISP static remote mappingsFilip Tehlar7-1/+482
Change-Id: Ic4c717af9629541bac0a0e6c65d0157619c8f578 Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2016-05-15VPP-62 Add a doxy filter to enable vpe.api docChris Luke3-5/+67
This makes Doxygen think the API definitions are structs which is close enough to be able to document the API methods. It also has logic to create an indexed API page but that's disabled for now because it duplicates the "brief" text twice in the struct doc. Fixes a minor line numbering issue in filter_c.py. Change-Id: If380160b73e7c10d999b35a76f55d0e27cbc91cc Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-05-14VPP-63: clean up config scripts, remove specific hostnamesDave Barach37-59/+45
Change-Id: Ifb77256fa691b1a90045a10448835c09b764e74f Signed-off-by: Dave Barach <dave@barachs.net>
2016-05-13VPP-57 Add doxygen build dependenciesChris Luke1-4/+9
Change-Id: I764d8a440c050d753e0380e139f489d3085f17f4 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-05-13ONE-7: Fix map-request encapsulationFlorin Coras1-68/+81
We now try to find the first map-resolver IP we have a route to and decide the ip lookup node according to map-resolver IP. Change-Id: I68fc12861dc1e9a203ebf6caefd4f053a741a785 Signed-off-by: Florin Coras <fcoras@cisco.com>