summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-07-08VPP-189 Some bugfixes for issues reported by CoverityChris Luke2-14/+66
CID 130914 Buffer not null terminated CID 130916 Unchecked return value CID 130938 Unchecked return value from library CID 130939 Unchecked return value from library CID 130940 Unchecked return value from library CID 131042 Argument cannot be negative CID 131222 Resource leak CID 131223 Resource leak CID 131334 Double close CID 131335 Read from pointer after free CID 131211 Resource leak CID 131212 Resource leak Change-Id: Idd80b91f621278e0be15911f2ed4354dbe4fc7f2 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-07-08Allow DPDK per interface startup config to enable/disable VLAN strippingJohn Lo2-8/+27
The init of VIC/ENIC ports enable VLAN stripping of received packets by default, which is different to all other devices. The VLAN stripping of ENIC ports can be disabled by adding the per device DPDK config as "vlan-strip-offload off" such as: dpdk {... dev 0000:0c:00.0 {vlan-strip-offload off} ...} The per device config "vlan-strip-offload on" can be used for enabling VLAN stripping for other devices which support this function but is disabled by default. Change-Id: I9c81904a87c26868a07900b03677aeeb57f72372 Signed-off-by: John Lo <loj@cisco.com>
2016-07-08Reset IPFIX streams after configuration changeJuraj Sloboda1-0/+17
Reset IPFIX streams if reconfiguring IP addresses or collector port Change-Id: Idc914f90462572342d4ed02b538bb2d30b317931 Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
2016-07-08Set plugin path properly when using toplevel makefile to run/debug vppDamjan Marion1-8/+11
Change-Id: Ib6f7dd9d7e1d9f2f2108a8b89421149e4435d5ec Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-07-07Add configuration options for IPFIXJuraj Sloboda3-11/+52
Make Path MTU configurable Make template resend interval configurable Make collector port configurable Change-Id: Ia557916137995ea565f0ede12e169efe81eb0a5d Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
2016-07-07Use arbitrary FIB for IPFIXJuraj Sloboda3-8/+20
Change-Id: I85b3543a3f72a10e15c252e04ce2e4a390513ca9 Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
2016-07-07VPP-142 Recursive route sending traffic to wrong interfaceNeale6-185/+249
Indirect routes should always result in an indriect adjacency even when the route's next-hop is covered by a connceted, since the covering route may change and no tracking is in place. Some de-duplication of code for installing indirect routes via the CLI and API. Change-Id: I7a440ffba43ae3990b68cb407244c06bd0827534 Signed-off-by: Neale <nranns@cisco.com>
2016-07-07VPP-148 added bvi_mac flag to l2fib_add_del api call similarly to climarek zavodsky4-1/+10
Change-Id: I3b65e85d24ed37b6889af7e194fee45ec61b15a8 Signed-off-by: marek zavodsky <mazavods@gmail.com>
2016-07-07Fix bugs and do some optimization in IPFIX codeJuraj Sloboda2-6/+22
Change-Id: Iba8627062874eac63c584ec05343f4591f48c286 Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
2016-07-07Document more nodesDave Barach3-0/+142
Change-Id: Ib8ef0559aa0573bf1229e9c794d48520197f9c8a Signed-off-by: Dave Barach <dave@barachs.net>
2016-07-07Remove #if DPDK == 0, to eliminate a data structure size mismatchDave Barach1-2/+2
Otherwise, e.g. the ip4/6_main_t's change size between PLATFORM=vpp and PLATFORM=vpp_lite. That, in turn, makes it far easier to build broken plugins. Change-Id: Ic962d75b170eee698de29c4e29849ce73d27caad Signed-off-by: Dave Barach <dave@barachs.net>
2016-07-07Remove duplicate code buffer_func.hDamjan Marion1-4/+0
Change-Id: I57e442b1f3486c5e8caac9d2e288869ee10f37b8 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-07-07Fix deletion forwarding entries when deleting static remote mappingFilip Tehlar1-0/+3
Change-Id: I11207a0452cbccfb959ff426faefda4820463007 Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2016-07-07Retire support for DPDK 2.1.0 and olderDamjan Marion8-197/+2
Change-Id: I3c3427c61e32d4727360aa802950bb9ab44afd84 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-07-07Add some doxygen tagsDave Barach4-1/+176
Also add an index of node names Change-Id: Id65c2e607976d8bad73deb738035a471be077196 Signed-off-by: Dave Barach <dave@barachs.net> Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-07-07Add an option to dump details about specific LISP EID in API/CLIFilip Tehlar5-12/+162
Change-Id: Ie5e6751fd791e7ca728522632332abe442a1a75b Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2016-07-06Retire PLATFORM=virlDamjan Marion4-52/+2
Change-Id: Iaf9735258f456574534c1a581b983326badea171 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-07-06Add support for capturing packets on packet generator interfacesDamjan Marion8-53/+215
This patch introduces following changes: - 4 predefined pg/stream[0-3] interfaces are removed - Interface naming is changed form pg/streamX to pgX where X can be any u32 value - one pgX interface can handle multiple streams - keyword "source pgX" is added to "packet-generator add" command, X is 0 by default - new cli "packet-generator capture" is introduced - new cli "create packet-generator interface pgX" Change-Id: I768d075b9d4a34f0b5073debdc5dd4a0880c682c Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-07-06Netmap: Fix Netmap Polling IssueMohsin KAZMI1-7/+31
Previously, netmap node switched from interrupt to polling if worker threads are enabled even if there was no netmap interface running. Netmap input node consumed CPU cycles because of input node calls but these cycles were wasted as input node did not have any packet to process. This patch fixes issue stated above using more intelligent way of enabling or disabling polling based on interfaces count. But the pre-requisite condition for polling is, worker thread(s) should be enabled. Change-Id: I3a901823c7b040cce3393958981f439b9f290fe5 Signed-off-by: Mohsin KAZMI <sykazmi@cisco.com>
2016-07-06VPP-184 - Bad type translation in jvppJan Srnicek1-2/+2
Change-Id: I6dda9eb8d58a2bc9a1e4d6636688dfa1f8bb88c6 Signed-off-by: Jan Srnicek <jan.srnicek@pantheon.tech>
2016-07-06Bug fix for VPP-104 about not being able to down a sub-if if the super-if is upCalvin1-1/+3
Change-Id: I913c9807519aa10e515d12fcfbcbfc22b58f5839 Signed-off-by: Calvin <calvin.ference@gmail.com>
2016-07-06VPP-182: IPv4 static ARP entries should not be deleted on interface downJohn Lo1-19/+24
IPv4 static ARP entries should remain when interface is set admin-down and be reapplied on interface admin-up. Change-Id: Ic0051865154230c2561d6e6421b05d842f147ca7 Signed-off-by: John Lo <loj@cisco.com>
2016-07-06VPP-177: IPsec empty buffers allocation fixMatus Fabian2-2/+4
Change-Id: I6d224fe19f1e0dd7ad5659e0734bc96ba37337ff Signed-off-by: Matus Fabian <matfabia@cisco.com>
2016-07-05VPP-144: Fix that shows the empty segment field in sh sr tunnelCalvin1-1/+6
Change-Id: Idc71a48f2eab3b712f6953af8baf1a6ecd54dcaf Signed-off-by: Calvin <calvin.ference@gmail.com>
2016-07-05VPP-179 Fix adjacency reference-count botchesDave Barach2-2/+24
Change-Id: I3fe83a511064d73087c4526ef33cd7628f15b90f Signed-off-by: Dave Barach <dave@barachs.net>
2016-07-05ENIC driver patches to address various issuesJohn Lo10-0/+741
Also clear x-bit for old patch files 0013-xxx and 0014-xxx. Change-Id: I217fdbfb32cef1ae575c668270d3baf593e688c6 Signed-off-by: John Lo <loj@cisco.com>
2016-07-04LISP CP cleanup and refactoringFlorin Coras10-764/+1111
- avoid code duplication by using only one function for insertion/updating of remote mappings into map-cache. Static remote mappings are now inserted using this function as well and therefore the code does not try to build forwarding entries out of them now. - bring up lisp dp interfaces when a vni is bound to a vrf. - ensure eids are cleaned-up before parsing control plane messages - ensure map-requests are always sent to default fib - new API to insert lisp adjacencies as opposed to remote mappings which should be replaced post merged in CSIT - reorganize and group functions according to their purpose and use. No need to pre-declare internal functions now. - this does not touch locator-set logic Change-Id: Ibcfc0f2d9c1bc1c9eab6e83c1af1b4cf9302ac10 Signed-off-by: Florin Coras <fcoras@cisco.com>
2016-07-04VPP-174 IPsec API fixMatus Fabian1-7/+18
ipsec_sad_add_del_entry and ipsec_spd_add_del_entry parameters with IPv4 address are always 0.0.0.0 Change-Id: I75cb211ce9069596df4ef1d910e263d22940b9d8 Signed-off-by: Matus Fabian <matfabia@cisco.com>
2016-07-02Add gtags option to use ctags. Hidden option in MakefileKeith Burns (alagalah)1-0/+3
Change-Id: I6b01c1f2beec37d7aaad1ab9dab303835a9feb49 Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
2016-07-02Finish cleanup of .../plugins/{configure.ac, Makefile.am}Dave Barach6-87/+44
To add a new plugin subdirectory, add this to Makefile.am: if ENABLE_new_PLUGIN SUBDIRS += new-plugin endif and add this to configure.ac: PLUGIN(new) Change-Id: I770a6f4f8f964fd7318a912be486accf46514b59 Signed-off-by: Dave Barach <dave@barachs.net>
2016-07-02Enable PCI extended tags in the DPDK configDamjan Marion1-1/+3
This change should improve DPDK performance on 40G+ NICs with small packets. It also removes ITR setting for i40e devices, allowing driver to set default. Change-Id: I70761b155e48fb0281f7c231516d83027bd16ca2 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-07-01Simple ip4 NAT pluginDave Barach14-6/+2928
Change-Id: Iffe77bf2a05ced41474540ff54a842101aad7c41 Signed-off-by: Dave Barach <dave@barachs.net>
2016-07-01VPP-171: fix a set of hw interface recycling bugsDave Barach3-1/+27
Change-Id: I735292bb2176742acab2295f90956c57e6f7ec1c Signed-off-by: Dave Barach <dave@barachs.net>
2016-06-30VPP-163 "show ip6 interface" ignores many addressesChris Luke2-24/+61
The output of the CLI command "show ip6 interface" shows only the first link-local address and any globally-scoped addresses. It ignores all other valid address scopes. This patch reworks that routine to cover the three main address scopes ("link-local", "global" and "local") and anything else it finds is grouped under "other"). Rationale for this final grouping is that these other addresses fall under ranges currently either "reserved" or "multicast" in scope. Whilst it's good to show if these are present, they are not normally found as link addresses. DBGvpp# sh ip6 int tap-0 tap-0 is admin down Link-local address(es): fe80::e857:7fff:fe77:c1a9/64 Local unicast address(es): fd50:7389:246b:4321::2/64 Joined group address(es): ff02::1 ff02::2 ff02::16 ff02::1:ff77:c1a9 ff02::1:ff00:2 ... Change-Id: I1d750b3b39c54aa4eb75632d53089640601bcba5 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-06-30Fix buffer leak from L2 flooding replication processPierre Pfister1-0/+1
vlib_buffer_free_inline actually checks (b->flags & VLIB_BUFFER_RECYCLE) in order to decide whether to free the packet or not. Although the flag was correctly set in replication_prep, it is not removed by replication_recycle during last iteration. This patch just removes VLIB_BUFFER_RECYCLE when is_last is set. Change-Id: I2445ebce908d94d95535e706b40407b4f15906e4 Signed-off-by: Pierre Pfister <ppfister@cisco.com>
2016-06-30Fix wrong interger type when unformating value in VATFilip Tehlar1-4/+4
Since format string "%d" expects a 32 bit value using u8 type in unformat() results in buffer overflow. Change-Id: Idee5b588049d7573ddbde56c28030f9db3758493 Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2016-06-30Fix clang buildDamjan Marion3-8/+8
Change-Id: I678d7e0a7c91c7daf9feb3ec23a633b96fab56a7 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-06-29Fix the spelling of the word "suppress".Chris Luke7-24/+26
The spelling mistake where "suppress" is written as "surpress" was sufficiently common and annoyed me enough to fix it. For backwards compatibility, the CLI and API test tool both still accept the erroneous spelling. Change-Id: I82104ae9d8c2c9d6e3396ba0d72cb1dc133081d1 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-06-29Add support for ethernet address in LISP APIFilip Tehlar4-98/+183
Change-Id: I9f1522f55bdd11602784a421fd850b839a1070e6 Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2016-06-29Don't re-write adjacency with same information.Keith Burns (alagalah)1-9/+17
This will cause FIB counters to appear to be reset. This is an implementation of a patch from Dave Barach. Change-Id: I19b9953d42dfb92ec22af6a855e2e519ae7c3bdc Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
2016-06-29Decouple worker thread code from dpdk, enable worker threads in vpp_liteDamjan Marion12-654/+593
Change-Id: I28616f1a89f2da95484438ec1a1db64845f15ef6 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-06-29VPP-158: VPP crashes in IKEv2 code when running multithreadedMatthew Smith6-148/+222
Change tunnel interface creation to be done from the main thread instead of a worker thread by calling vl_api_rpc_call_main_thread. Make per-thread copies of volatile elements in ikev2_main. Change-Id: I4cda8aaa392a04c2aea2d50a52a07933cf40c016 Signed-off-by: Matthew Smith <mgsmith@netgate.com>
2016-06-28VPP-48 Fixes for ip4/6 ttl checks and icmp responsesChris Luke6-72/+244
This patch fixes a few minor things: - Previously ip[46]_input was rejecting packets with an input TTL (hop limit) of one; this was not correct behavior. Packets that are bound for this device can validly have a TTL of one. - ip[46]_forward was not generating an ICMP TTL expired message if the act of decrementing the TTL caused it to become zero. This was not previously an issue because ip[46]_input was filtering packets where this could happen. - udp_local was not generating ICMP Port Unreachable messages if UDP packets arrived for a port that is not listened to. This is typically the signal that "traceroute" uses to terminate its search. Together these fixes mean that traceroute probes transiting a VPP node, or are targetted toward a VPP node, now work as expected. Change-Id: I84bb940883f7a18435f29f4518fb0445b989a3e3 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-06-28Fix native build on non x86_64 systemsDamjan Marion3-0/+13
Change-Id: Iab9f6793112f19a5b54a555623d84099aa8bb03e Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-06-28Reduce ring size for dpdk NICs and overtal mem footprintDamjan Marion3-7/+7
Size of interface descriptor rings have direct impact on Last Level Cache utilization, and can significantly affect performance. So generally having smaller ring size is good idea as long as there is enough buffer in the ring to accomodate line rate. Here we are reducing rings sizes to 1024 which is still bigger than lab verified 512 buffers per ring. Indirectly, this also affects memory footprint, as we can have smaller buffer allocation, which is now 16384 (previously it was 32768) This patch also fixes issue with i40e vector PMD which was leaking buffers when previous default ring sizes were set. Change-Id: I58fb40586304b2f0cb5de9a444055da3cd3acb53 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-06-27Add support for classify table/session read to jvpp:Marek Gradzki2-26/+110
* provides length information for variable length arrays in classify table/sessione reply messages * provides jvpp example for reading classify tables/sessions Change-Id: I47f8fca5c849ec874d4e23f28177e310689db522 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2016-06-27Plugins: Clean up the plugin directory so that each plugin has its ownOle Troan97-151/+485
directory and GNU autotools setup. Change-Id: I6c59d1297389c9413db0c0b9bdf3b759080bf1b8 Signed-off-by: Ole Troan <ot@cisco.com>
2016-06-27More janitorial workDave Barach21-138/+98
Install vpp api header files in /usr/include/vpp-api, instead of /usr/include/api. Someone will eventually complain if we continue with the status quo. Generate /usr/bin/vpp_plugin_configure, to correctly configure standalone plugin compilation against header files installed from the dev package. If a plugin's CFLAGS don't precisely match the installed vpp engine binary, subtle misbehavior can and will occur. Example: the ip4/ip6 main_t structure size / member offsets depend on DPDK=[0|1]. Screw that one up, and your brand-new configurable ip feature will mysteriously fail to appear, even though the plugin loads perfectly. Change-Id: I20c97fe1042808a79935863209d995c31953b98c Signed-off-by: Dave Barach <dave@barachs.net>
2016-06-27VPP-108 : API calls to read classify table and sessionsPavel Kotucek5-5/+651
Added new API calls to read - classify table ids as array - classify table ids for specified interface - classsify table info and to dump sessions of specified classify table. Change-Id: I089604fa98eea92866495089d76c2330ae7d850c Signed-off-by: Pavel Kotucek <pavel.kotucek@pantheon.tech>
2016-06-27Add MAC address support to LISP map-cacheFilip Tehlar5-17/+131
Change-Id: I80f05a222cb0f728ad2460efe33955e781b6849f Signed-off-by: Filip Tehlar <ftehlar@cisco.com>