summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-09-21dpdk: fix wrong tx ring size calculationsDamjan Marion4-27/+22
At many places code was using constant ring size od 4096 which was defined in macro DPDK_TX_RING_SIZE. As we support differnet ring size and default value s now 1024, we need to remove DPDK_TX_RING_SIZE and use value stored in device structure. For that reason dpdk_device_t.nb_tx_desc is moved to first cacheline. Change-Id: I2c2ac11f0f5e8ae779d34f9a9104eaf2921ec34c Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-09-20dpdk: move number of sub-interfaces to 2nd cacheline, introduce flagDamjan Marion3-20/+32
This saves 2 bytes from the 1st cacheline. Change-Id: I691a3a0ee07ec2db4ae85b96b451ef53ad8c9458 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-09-20dpdk: use flags for identifying interface typesDamjan Marion8-42/+36
This will allow us to handle some more complex situations like in case when hqos needs to be enabled only for some PMDs. Change-Id: I5421a8d4cf29b8394b9e956cc4e39737dd07dbbb Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-09-20Use SSE instructions for matching tagged frames by ethertypeDamjan Marion3-8/+29
This change improves performance in l2 scenarios for about 1-2%. Change-Id: Ie35ed8ad70a3b95dd78c0d158c485a10dabaf0eb Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-09-20VPP-419 add thread-safety to LLDP featureKlement Sekera2-30/+90
Change-Id: I3b1153a64674c2caef71c968739ecca6512e9929 Signed-off-by: Klement Sekera <ksekera@cisco.com>
2016-09-20fd closed twiceEyal Bari4-5/+8
fd close()ed after call to unix_file_del of same fd Change-Id: Ia8bf77b72b6cea7c70e004199ce11a33b6260720 Signed-off-by: Eyal Bari <ebari@cisco.com>
2016-09-20Added volatile to local variables needed by setjmpEyal Bari1-2/+2
Function vlib_main uses nonlocal control transfer (setjmp, longjmp), local variables might be mapped to cpu registers which might be different when longjmp'ing back to it. Added volatile to keep those variables on the stack. to fix vpp crash when exiting via SIGTERM. Change-Id: I03e836966c68a966a84d635bc1f7b3a3c252f3ea Signed-off-by: Eyal Bari <ebari@cisco.com>
2016-09-20VPP-282: Document changes for vnet/vnet/ethernetBilly McFall3-32/+146
Change-Id: Ie75f43516fdd76ba3720f65f38d66f14749e3e2d Signed-off-by: Billy McFall <bmcfall@redhat.com>
2016-09-20VPP-189: fix coverity issue in api_format.cFilip Tehlar2-1/+9
Change-Id: Ib16fd69abe93c1afb2ee1d38144763f57888585c Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2016-09-20VPP-348 Return empty DumpReply instead of nullMaros Marsalek5-44/+98
Change-Id: If44f8d37649e5a9d5033ec2c0ab7452397e22691 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
2016-09-20VPP-413 DTOs generated by JVpp improvements:Maros Marsalek12-145/+275
- hashCode & equals - toString Change-Id: I5f8bc8868c216862a307dcc8f6b423f0ce29e7b5 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
2016-09-20vhost-user: announce VIRTIO_F_VERSION_1Damjan Marion2-2/+4
On some setups with QEMU 2.7.0 and xenial guests following error message is reported in guest dmesg: [ 0.895944] virtio_net virtio3: virtio: device uses modern interface but does not have VIRTIO_F_VERSION_1 Change-Id: I5a0b3beffe75c9b0344d377098d94923b2ad7ae9 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-09-20Update CSIT tests 160912 -> 160919Jan1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: Ibcc937f68311a9809cc31965633f2d21f111e2c7 Signed-off-by: Jan <jgelety@cisco.com>
2016-09-20Add structure to some of the documentation; VPP-223Chris Luke8-8/+24
Moves the random .md files, when rendered by Doxygen, into a config examples tree. We may later flesh this out into a more complete user documentation section. Change-Id: If423b82f1047f1c84f90876a786313054b5f7c77 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-09-19Add support for transparent ethernet bridging to GREDavid Hotham10-32/+109
Change-Id: Iaa3cefe223eb48b128893029a17e092b72a5157c Signed-off-by: David Hotham <david.hotham@metaswitch.com>
2016-09-19Cloned buffer refcount was set to 0Christophe Fontaine1-0/+1
The cloned buffer returned by rte_mempool_get_bulk had a refcount set to 0. This triggered an assert in drop-punt node. Change-Id: I77f53abd72dcdbf5dd512a05e13fe6d3fd569843 Signed-off-by: Christophe Fontaine <christophe.fontaine@qosmos.com>
2016-09-15VPP-306: Document changes for vnet/vnet/vxlanBilly McFall2-1/+76
Change-Id: I1ec4a80ee431758998716014e3fb6f80a5b9c168 Signed-off-by: Billy McFall <bmcfall@redhat.com>
2016-09-14VPP-407 fix coverity warningKlement Sekera1-5/+0
Change-Id: Ic3e5df2d272c2b31fbe875e1c09db0edac4813b8 Signed-off-by: Klement Sekera <ksekera@cisco.com>
2016-09-14VPP-408: fix coverity warning in run_ping_ip46_address()Andrew Yourtchenko1-1/+9
CID 147141: Security best practices violations (DC.WEAK_CRYPTO) /vnet/vnet/ip/ping.c: 496 in run_ping_ip46_address() 490 ping_main_t *pm = &ping_main; 491 uword curr_proc = vlib_current_process (vm); 492 u32 n_replies = 0; 493 u32 n_requests = 0; 494 ping_run_t *pr = 0; 495 u32 ping_run_index = 0; CID 147141: Security best practices violations (DC.WEAK_CRYPTO) "rand" should not be used for security related applications, as linear congruential algorithms are too easy to break. 496 u16 icmp_id = rand (); 497 while (hash_get (pm->ping_run_by_icmp_id, icmp_id)) 498 { 499 vlib_cli_output (vm, "ICMP ID collision at %d, incrementing", icmp_id); 500 icmp_id++; 501 } Change-Id: I822350c03afce0b2dd35f37e27f55df82ca3443f Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2016-09-14Add vlan-strip-offload help into startup.confAlex Popovsky1-0/+4
Change-Id: Icb240ce9c62e9a2e2ff18107729cffb8e4884a0c Signed-off-by: Alex Popovsky <apopovsk@cisco.com>
2016-09-13VPP-404: IKEv2 profile auth rsa-sig cert-file fixedMatus Fabian2-1/+2
Change-Id: Iaeca4a86eb96096d6840d38c16d60641e9179662 Signed-off-by: Matus Fabian <matfabia@cisco.com>
2016-09-13l2_output: reset bit after mapping is createdDamjan Marion1-0/+3
Change-Id: I894d71b397e7451d4e596b10258933287b7e965f Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-09-13VPP-344 Add LLDP featureKlement Sekera9-0/+1851
Change-Id: Iac96773e7f9028c0f09c3388893e69f67177439d Signed-off-by: Klement Sekera <ksekera@cisco.com>
2016-09-13Implement IPv6/IPv4 ping.Andrew Yourtchenko3-0/+874
Change-Id: Id53797c795c17fbacce3659c945f5126dc9dee86 Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2016-09-13Add some help into startup.confDamjan Marion2-0/+56
Change-Id: I84e9d7c3ccd32814c3eebf1cef0a4887c75812a8 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-09-13VPP-292 Document vnet/vnet/lisp-gpeFlorin Coras7-49/+485
Change-Id: I5b282964330f4c14f7991453ee02c455a8d367ea Signed-off-by: Florin Coras <fcoras@cisco.com>
2016-09-13VPP-376: Refactor LISP dump API + VATFilip Tehlar7-1041/+377
- refactor VAT so it won't cache data - remove unused filter flag from locator dump API call - json structure changed for locator and EID table dump calls - remote mapping VAT cli now accepts string for negative mapping action Change-Id: I776fb50659aaa7e98ad93715d282a83f78287344 Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2016-09-13VPP-288: Documentation changes via doxygen for vnet/vnet/l2.Billy McFall14-53/+564
Change-Id: I55b552fd054610c993d14078ce048c8c4b676104 Signed-off-by: Billy McFall <bmcfall@redhat.com>
2016-09-13Python API: Re-adding rudimentary variable length array pack support.Ole Troan3-24/+40
Fixed bug in message-id mapping with non-consequtive APIs. Change-Id: Icd6073e4655f7ce5432816861ae58915e5b336af Signed-off-by: Ole Troan <ot@cisco.com>
2016-09-13Use the correct thread stack alignment constraint, VPP-401Dave Barach1-2/+6
Change-Id: Ia7837dfaa9ed200145aeea19177fe549ab4bd087 Signed-off-by: Dave Barach <dave@barachs.net>
2016-09-13Update CSIT tests 160904 -> 160912Jan1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I7a8024378dee33c89b58835af1b7de020fac3e5e Signed-off-by: Jan <jgelety@cisco.com>
2016-09-12Provide vpp-plugins rpm packagingEd Warnicke1-0/+31
Change-Id: Ifbd99818ead5f38c5f8ad3ecdb36b24a9fa59798 Signed-off-by: Ed Warnicke <eaw@cisco.com>
2016-09-12MAP: Doxyfying CLI macros - VPP-165Ole Troan1-48/+158
Change-Id: Iee203bf24e8c68e1367d12f297bf31019cc44c5c Signed-off-by: Ole Troan <ot@cisco.com>
2016-09-12af_packet: allocate per-worker list of free buffersDamjan Marion3-8/+15
Change-Id: I7850f04787fa7ce10c0ae8adefa166c91420f02d Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-09-12DPDK virtio patch: Enable indirect descriptor featuresPierre Pfister1-0/+34
http://dpdk.org/dev/patchwork/patch/15610/ This change only includes patch for DPDK 16.07 as DPDK 16.04 doesn't seem to compile for me. Change-Id: I18d84456ef6a15aa308d5e14673a24cb4a7b6909 Signed-off-by: Pierre Pfister <ppfister@cisco.com>
2016-09-12VPP-392 properly pass flags from vnet_hw_interface_set_flags_helper toKlement Sekera1-2/+1
vnet_main->hw_interface_link_up_down_functions Change-Id: I7aacaebade695e8fec8306426f693f287b605ed8 Signed-off-by: Klement Sekera <ksekera@cisco.com>
2016-09-11Move CLI examples from wiki to code - VPP-165Keith Burns (alagalah)6-4/+243
Change-Id: I50ad0d79a6ffaf0a51848abf2c5ed57e83c8640f Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
2016-09-10VPP-367: Peg vpp and vpp-plugins to depend on specific versionsEd Warnicke1-2/+2
vpp now depends on the version of vpp-lib it was built with vpp-plugins now depends on the version of vpp it was built with Change-Id: Idf706f94d3a35bdf51930badf61cac288855873d Signed-off-by: Ed Warnicke <eaw@cisco.com>
2016-09-09Check for zero-sized Graphvix config file on Ubuntu; VPP-396Chris Luke1-1/+2
- The previous change only accounted for a missing Graphviz config file; apparently it can be zero-sized too. Change-Id: Ic6957d10cdc7cb7b9da72d2b2a0f8913100870c5 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-09-09On Ubuntu check for graphviz system configChris Luke1-0/+3
- Sometimes it seems Ubuntu doesn't always set up the Graphviz handler config. If it's missing, generate it. Change-Id: I2c1e566817de8415f8b360c6f967cd76307a2a52 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-09-07Fix bugs in IPFIX code discovered by coverityJuraj Sloboda5-37/+39
Change-Id: Ibe6ccb99c3c29c14efb34191f209a2f6a14293f7 Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
2016-09-07Fix Coverity issue in trace_util.c (REVERSE_INULL), thanks to Damjan for ↵Vengada Govindan1-6/+7
highlighting this. Change-Id: I22b1dc800624042e043e7632179f6281a6ccaafc Signed-off-by: Vengada Govindan <venggovi@cisco.com>
2016-09-07VPP-346 Improve Doxygen include path mechanismChris Luke2-23/+55
- If present, include the directories where API header files are generated into. - Improve extraction of include paths from CPP - Generalize the file/directory exclusion This reduces some of the "warning" chatter from Doxygen. Change-Id: I7ac02bff1639fe63f11263176020b0f040255017 Signed-off-by: Chris Luke <chrisy@flirble.org>
2016-09-07VPP-388 Improve IP header lookup in ipsec_outputFlorin Coras1-7/+7
Change-Id: I5df0067c9ce56d7a15a991b82d4761924d91758b Signed-off-by: Florin Coras <fcoras@cisco.com>
2016-09-07Fix MTU size for the bonded interfaceSteve Shin1-0/+12
Configure the MTU/L3 packet size of the bonded interface as the lowest value of the slave intefaces Change-Id: I34fb4c2156e8ad3d9bf45efe332405d53f72867c Signed-off-by: Steve Shin <jonshin@cisco.com>
2016-09-07VPP-390: include *.so symlinks in vpp-libEd Warnicke1-0/+2
Currently, vpp-lib rpm includes symlinks for *.so.0 -> *.so.0.0.0 but not *.so -> *.so.0.0.0 This causes linker issues in cases where vpp-lib and vpp-devel rpms are installed and sources are built that rely on libraries in vpp-lib. Example: libtool: link: gcc -shared -fPIC -DPIC jvpp/.libs/libjvpp_nsh_la-jvpp_nsh.o -lvlibmemoryclient -lvlibapi -lsvm -lvppinfra -lpthread -lm -lrt -ljvpp_common -L/usr/lib64 -O2 -Wl,-soname -Wl,libjvpp_nsh.so.0 -o .libs/libjvpp_nsh.so.0.0.0 /usr/bin/ld: cannot find -lvlibmemoryclient /usr/bin/ld: cannot find -lvlibapi /usr/bin/ld: cannot find -lsvm /usr/bin/ld: cannot find -lvppinfra collect2: error: ld returned 1 exit status Change-Id: Ic8eebc696f973ea348be0b43e7cfb289efbe44fe Signed-off-by: Ed Warnicke <eaw@cisco.com>
2016-09-07VPP-382: Add ipsec tunnel interface to sw_interface_dumpMatus Fabian1-0/+6
Change-Id: I9e49c9b6deedb750269da04e3332a3b0742d382c Signed-off-by: Matus Fabian <matfabia@cisco.com>
2016-09-07VPP-387: Fixed ipsec-input traceMatus Fabian1-20/+31
Change-Id: I0a687c5d5f745a6c82a58c8e20b987180704a685 Signed-off-by: Matus Fabian <matfabia@cisco.com>
2016-09-07Vhost-User: Implement Indirect DescriptorsPierre Pfister2-94/+182
One of the main issue with virtio is the small queue size. VPP can quickly fill the queue before Linux could empty it, resulting in packet losses. Virtio indirect descriptors double the number of packet which may fit in the virtio queue (From 128 to 256 with standard qemu which hardcodes queue size to 256). Linux will not use such descriptors if the virtio MRG feature is enabled. You may add mrg_rxbuff=off option to qemu commandline when starting the VM such as to disable this feature. This way, Linux will use indirect buffers to receive packets. But it seems that Linux never uses indirect buffers to send packets. This patch also includes some optimization modifications. Change-Id: I26940d41ce6b7e3a08d5516018a8c46c5316ce1c Signed-off-by: Pierre Pfister <ppfister@cisco.com>
2016-09-07checkstyle: improve speed by checking only recently changed filesDamjan Marion2-3/+25
This change makes checkstyle much faster by checking only recently changed files. It only checks files changed in last commit and files which are localy modified. Old behavior is preserved by specifying argument "--full" when invoking script. In addition "make checkstyle" and "make "fixstyle" actions are added to the top-level Makefile. Change-Id: I7d86225bd282f32ee508e7f52692a3778ac8dcda Signed-off-by: Damjan Marion <damarion@cisco.com>