summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-09-30misc: 20.09 Release NotesAndrew Yourtchenko1-1/+655
Type: docs Change-Id: I1b12f1d14a1a68504767c01ceac0eed115fb7ba6 Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
2020-09-30virtio: fix modern device queue notifyMohsin Kazmi5-22/+53
QUEUE_SELECT and QUEUE_NOTIFY_OFF registers are shared between all workers operating on the same device and operations are not atomic Type: fix Change-Id: Ie017b1bfc7e3b6b4e59029f45db78eeffd9f3aeb Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com> (cherry picked from commit 162a296756f3dbead55079e4670973d859df1ef9)
2020-09-30virtio: fix txq lockingBenoît Ganne3-2/+23
Initialize txq lock only if some txq are shared and check if another worker is already operating on the txq before processing gro timeouts in input node. Type: fix Change-Id: I89dab6c0e6eb6a7aa621fa1548b0a2c76e6c7581 Signed-off-by: Benoît Ganne <bganne@cisco.com> (cherry picked from commit b6b484d01adb8ab2ef5a50d5a3d6f3f097df2e0c)
2020-09-30tap: do not use strlen on vectorVladimir Isaev1-2/+1
sanitizer complains about strlen on hi->name in tap_dump_ifs. hi->name is a vector which is not null-terminated, so use vec_len. Type: fix Signed-off-by: Vladimir Isaev <visaev@netgate.com> Change-Id: Icdd5f65369bb51b0c4a9cd86c24899e6febd837c (cherry picked from commit 84f3d9fba4e1715237a41f0978430193363187c7)
2020-09-30virtio: fix the gro enable/disable on tx-vringsMohsin Kazmi5-23/+39
Type: fix Change-Id: I96c30baaf34fe7b0cd899966a507501e58cde934 Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com> (cherry picked from commit 1017a1d360cc1c38e2aee4b5f19ff1f2869a8cd9)
2020-09-30ikev2: fix false positive NAT detectionFilip Tehlar1-18/+13
Type: fix Change-Id: Id7f865f537c55d00a784eec51624ba28e903a083 Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2020-09-29ikev2: fix memory leaksBenoît Ganne2-3/+21
Type: fix Change-Id: I5be19a4923b37e2636621d36155178ac348ee41c Signed-off-by: Benoît Ganne <bganne@cisco.com> (cherry picked from commit a8af7cf253c4e8ab9ba1a2cfed50f6236fea3a62)
2020-09-28build: remove OS distros which are EOLDave Wallace1-11/+0
Type: fix Signed-off-by: Dave Wallace <dwallacelf@gmail.com> Change-Id: If80ff6bfbd42779a663af1e7dcfff80d75f47f1e
2020-09-28dpdk: Revert "call the meson-based build instead of Makefiles"Andrew Yourtchenko2-220/+271
This reverts commit 73903d7e8a6141237637b2011386c7ee6ac969ee. After discussion with Damjan, the change is more risky than it seemed, so revert. Type: fix Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com> Change-Id: Idee82806cd4a12a92540f904397d259b531770d1 Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2020-09-28dpdk: Revert "prevent linking dpdk against libbsd"Andrew Yourtchenko1-16/+1
This reverts commit 7a7601795171665eb71461c705f3fbb4b6c6f1ad. After discussion with Damjan, the change is more risky than it seemed, so revert. Type: fix Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com> Change-Id: I67defb01a0bebb8ff4231c27690b694f608fcb8e
2020-09-25misc: documentation fixesAndrew Yourtchenko2-4/+3
Change-Id: Id7ae7bbc53e89777892b973008baa93f1a083aac Type: docs Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2020-09-25bfd: add missing unlockKlement Sekera1-0/+1
Thanks to Martin Sustrik for spotting the bug introduced by a316744 and submitting the fix. Type: fix Signed-off-by: Klement Sekera <ksekera@cisco.com> Change-Id: I4984fc32503b0c7b6db3543834dfbbfed2a1f23c
2020-09-24wireguard: fix uninitialized peer index in handoffFlorin Coras1-1/+1
Type: fix Signed-off-by: Florin Coras <fcoras@cisco.com> Change-Id: I41513b9aa6ca0db1fb9392a15e5ac329a635ebfa
2020-09-24wireguard: add handoff nodeArtem Glazychev18-448/+889
All timer and control plane functions happen from main thread Type: fix Change-Id: I4fc333c644485cd17e6f426493feef91688d9b24 Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> (cherry picked from commit 8eb69407c8075e101b773d5a27ea21bd3fc906d7)
2020-09-24build: fix missing openssl package on debian-10Dave Wallace1-0/+1
- libssl-dev missing on debian-10 breaks 'make install-ext-deps' Type: fix Signed-off-by: Dave Wallace <dwallacelf@gmail.com> Change-Id: Ib6a6f120147e8ae0dcfead6fae9f0a7a3434d687 (cherry picked from commit 17569cbeb25c7eba9cd818bea98448b11b05532c)
2020-09-24vppinfra: allow handoff to main threadDamjan Marion1-18/+16
Type: improvement Change-Id: If2e907967c9b75997b581ff0c058bd5c15e823f5 Signed-off-by: Damjan Marion <damarion@cisco.com> (cherry picked from commit f6e6c788070e1421bbe7b10d449d9b65918ba561)
2020-09-23avf: wrong argument passed to avf_log_errSteven Luong1-1/+1
Type: fix Signed-off-by: Steven Luong <sluong@cisco.com> Change-Id: Ica4601c9d17e182cbc348989a9f75ab1cb18b78a (cherry picked from commit ba3a20082d8e17388bfeca6c2b422e3a11a4eb69)
2020-09-23build: fix fts.py to run on debian-9/python3.5Dave Wallace1-15/+16
Type: fix Change-Id: I1404e73dd2ee62b51746e9f4760c7c3ca3b5989e Signed-off-by: Dave Wallace <dwallacelf@gmail.com> (cherry picked from commit a079844cf01eea8a7085c2c03226ceb3d942838a)
2020-09-23dpdk: prevent linking dpdk against libbsdMohammed Hawari1-1/+16
If libbsd is detected by the DPDK build system, DPDK does not provide implementations for strlcpy and dynamically link against the one provided by libbsd. When the DPDK plugin is loaded by VPP, a crash occurs because libbsd is not loaded by VPP. Type: fix Change-Id: Ib691bbe27edcf0f6f0a3d39952e439027cef72cb Signed-off-by: Mohammed Hawari <mohammed@hawari.fr> (cherry picked from commit 1f799bc3cb7a3826395e544cafe587174393e2f0)
2020-09-23vppapigen: crcchecker: harmonize the in_progress markingAndrew Yourtchenko2-6/+44
The format for deprecation is "option deprecated" now, so harmonize the in-progress marking to logically be "option in_progress" At the same time recognize the legacy/erroneous types of marking, print the warning. Change-Id: If418dfadd69ffb112550164d63d13420e51cefd7 Type: fix Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com> (cherry picked from commit 6a3d4cc9a11efbe73a1cda35a64c619eebde0b24)
2020-09-23build: allow for rc3/rc4 style tagsAndrew Yourtchenko1-1/+1
Historically, there was only rc1/rc2 tags, fix in case we tag rc3/rc4 during longer release windows. Type: fix Change-Id: I4243a1c03663a877f96a06d647e89adb74abd977 Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com> (cherry picked from commit bc31247c921d9bad94f2d4aeca9041aee518e7a6)
2020-09-23dpdk: call the meson-based build instead of MakefilesMohammed Hawari2-271/+220
Type: feature Signed-off-by: Mohammed Hawari <mohammed@hawari.fr> Change-Id: I576d92605da6d43e9b9f12238b18a518a0d69385 (cherry picked from commit 4c4633cad1019d9aa28669ddfedc612f768d71a8)
2020-09-23vxlan-gbp: Mark APIs as in-progressNeale Ranns1-0/+5
Type: fix The GBP plugin that uses this module is also in-ptogress, hence so is this module. Signed-off-by: Neale Ranns <nranns@cisco.com> Change-Id: I3cb5dd124afac05da013d92d67b2abf6cdf9b769 (cherry picked from commit b468773aa4164bf52e0751fdf780f67248037cc0)
2020-09-22crypto: revert crypto set handler all APIYulong Pei1-36/+3
This reverts commit 8c91b2ae2b32d428ef35605707788fe064621cb3, but keep a comment fix. Type: fix Signed-off-by: Yulong Pei <yulong.pei@intel.com> Change-Id: Ia66941bf18d3efac96f41bdf905d877cfb3ab211 (cherry picked from commit 6816c3b3df8c91a319cca56784dca07f842ef178)
2020-09-22build: remove opensuse build infraDave Wallace13-470/+9
- VPP on opensuse has not been supported for several releases. Type: fix Signed-off-by: Dave Wallace <dwallacelf@gmail.com> Change-Id: I2b5316ad5c20a843b8936f4ceb473f932a5338d9 (cherry picked from commit bc35f469c89daf0126937580b6972516b5007d3a)
2020-09-22build: missing deb pkg on ubuntu-20.04Dave Wallace1-1/+1
- The vpp build on the ubuntu-20.04 executor failed due to the package 'dh-python' not getting installed by 'make install-dep' Type: fix Signed-off-by: Dave Wallace <dwallacelf@gmail.com> Change-Id: Id9307ad1b4e34c413d90258c6bde2aa5afafec63 (cherry picked from commit 5cc11b1210910d6e56025d87688a52111f730469)
2020-09-22build: touch files when extracting rpm tarballsDave Wallace1-2/+5
Type: fix - Long story short, intermittently centos jobs have been failing with clock skew issues. When someone commits a patch on a machine with the date ahead of UTC, then clock skew will be encountered when extracting the RPM source tarball. See [0] and [1] for details. - Replace 'make bootstrap' with 'make install-dep' in RPM package build specfile. [0] https://unix.stackexchange.com/questions/164807/does-git-archive-use-the-wrong-file-timestamp [1] https://git.fd.io/vpp/tree/Makefile#n380 Change-Id: Iebfb9eb2e26c1f2e4488e871da86d0c60b9f4048 Signed-off-by: Dave Wallace <dwallacelf@gmail.com> (cherry picked from commit 27b50fea143f2d45613ef982870cd2052e21fb0f)
2020-09-16vmxnet3: gso fixesSteven Luong4-13/+29
outbound: wrong header len computation gso size and header length need to be set in the first segment of the chain inbound: EOP may have zero length descriptor to terminate the chain missing endian conversion for ethertype Type: fix Signed-off-by: Steven Luong <sluong@cisco.com> Change-Id: Iaa003c0e9af3ead4df6c6c0d5772a179d2ff15c4 (cherry picked from commit 007abe751f2ee86528d0ccc005a3da1c90850868)
2020-09-16vppapigen: crcchecker: report in-progress messagesv20.09-rc2Andrew Yourtchenko1-0/+6
in-progress messages do not give any API stability guarantees, by design, to allow easy iteration. Provide an easy way to know which messages are in-progress. If as a user you see "in-progress" message that you want to use in production, please contact the feature owner and discuss the path to removing the "in-progress" status before that. Change-Id: I27729995e26a70af373e642b871dbb5cc5526959 Type: improvement Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com> (cherry picked from commit 8b0cd69d31a50e7f4a454d45e903c6cdaf23fbfe)
2020-09-16crypto: Crypto set handler API to support set all as CLIYulong Pei2-4/+37
Type: improvement Signed-off-by: Yulong Pei <yulong.pei@intel.com> Change-Id: I43556f8c76c7aae64d9c927e1fda3c1774d7e49d (cherry picked from commit 8c91b2ae2b32d428ef35605707788fe064621cb3)
2020-09-16avf: change promisc mode from the avf process nodeDamjan Marion2-7/+26
Avoid situations where promisc mode is chaged while avf process is suspended in the middle of adminq operation. Type: fix Change-Id: Ia1fc6551e83218b5938630ad3a15d4f3f0ceceff Signed-off-by: Damjan Marion <damarion@cisco.com> (cherry picked from commit 160a2a9a8c5c4e054dcc0e8ebeb3de7654718582)
2020-09-16avf: fix race between avf and cli/api processDamjan Marion6-35/+43
device pool my grow during suspemd which will cause crash in avf process after it exits from suspend. Type: fix Change-Id: I51fec90088c909cfbaaca6c245272a28c0827ca0 Signed-off-by: Damjan Marion <damarion@cisco.com> (cherry picked from commit 171d6aceb039a7f0b0d67c837ff74359dae01ae4)
2020-09-16api: clean up use of deprecated flagOle Troan7-20/+20
The syntax of the deprecated flag has evolved. Clean up usage to be "option deprecated;". Type: fix Signed-off-by: Ole Troan <ot@cisco.com> Change-Id: If2b639f275eb8db58b36c457f9245fe35a4d8cb1 (cherry picked from commit f916414b383afd37ec78509ee613df8878160406)
2020-09-16vppapigen: crcchecker: report deprecated messagesAndrew Yourtchenko1-5/+15
Report if the messages were marked as deprecated, but not yet deleted. Useful for building the release notes and comparing between the releases. Also, put the dict_compare() call into the report(), since latter always consumes the output of the former. Change-Id: Iceab3e94ff66da931a4669b612026bd162dd5d1a Type: improvement Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com> (cherry picked from commit 62bd50de97cd90cc09559a09fe46f98211279a1e)
2020-09-16avf: add assert to ensure that adminq is used only from avf processDamjan Marion2-0/+12
Type: improvement Change-Id: Ib64c9b8207776986656e5a26c13a221edc6cc950 Signed-off-by: Damjan Marion <damarion@cisco.com> (cherry picked from commit 698eeb126d01427313949241b961c27347db8c72)
2020-09-16wireguard: Fix for tunnel encapNeale Ranns7-89/+468
Type: fix add UT for sneding handshale init and transport packets Signed-off-by: Neale Ranns <nranns@cisco.com> Change-Id: Iab1ed8864c666d5a0ae0b2364a9ca4de3c8770dc (cherry picked from commit d75a2d12c431fcffba2a2b4d59f18c9cec483ed9)
2020-09-16lisp: fix vat crash with one_add_del_local_eid apiOnong Tayeng1-1/+1
VAT crashes when the one_add_del_local_eid api is invoked with mac address as eid. Type: fix Signed-off-by: Onong Tayeng <otayeng@cisco.com> Change-Id: I29e246f6cad4b350fec52d54e94dbed586d488c4 (cherry picked from commit 5f473c0efc9e0ff068273520b058b8ac498dc597)
2020-09-16lisp: fix help msg of show eid-table commandOnong Tayeng2-4/+4
The lisp|one show eid-table command's help msg does not display the available options. This patch fixes that. show lisp eid-table [local|remote|eid <eid>] show one eid-table [local|remote|eid <eid>] Type: fix Signed-off-by: Onong Tayeng <otayeng@cisco.com> Change-Id: Id39148db2ff291a7fe859830c1488b69ccd15c05 (cherry picked from commit b418c397dc8c870c6561ea1d7565067333db9df4)
2020-09-16lisp: fix spelling mistake in option nameOnong Tayeng1-1/+1
In the vat help msg for one_add_del_l2_arp_entry the IP address option is misspelled as "ip4 <ip4>" when it should have been "ip <ip4>". Type: fix Signed-off-by: Onong Tayeng <otayeng@cisco.com> Change-Id: Id4058a3ddfdb78b840d7e5a3c330e67b393f5d3b (cherry picked from commit 8c6ba2957c985a1670e9fca6bc869008e6722364)
2020-09-16lisp: fix lisp|one_eid_table_dump's local|remote options in vatOnong Tayeng1-1/+1
The local|remote options to vat's lisp|one_eid_table_dump api command does not print the eid details instead it produces the following error messages: Filter error, unknown filter: 1 Filter error, unknown filter: 2 Type: fix Signed-off-by: Onong Tayeng <otayeng@cisco.com> Change-Id: I000c290b400dbf39bd883d57115923167092c9bd (cherry picked from commit 2237cc8ce1e0eb7222a34bb30bdeb2f3f1df9a81)
2020-09-16avf: fix race between avf process node and avf_delete_if(...)Damjan Marion4-18/+34
It may happen that process node is suspended while it waits for response from adminq and during that time CLI or API process can call avf_delete_if. When avf process node resumes, it may happen that device is not there anymeore. This patch delegates interface deletion to process node, so CLI/API process just sends signal instead of deleting device instance itself. Type: fix Change-Id: I7f12e12df3071650f6e60ad7eb5af23b7acfe335 Signed-off-by: Damjan Marion <damarion@cisco.com> (cherry picked from commit 66bb7dd64ee2377103e18b96f1e6bf6405de44b5)
2020-09-16nat: Fix next feature for ED with multiple workersVladimir Isaev3-2/+25
Multiple (> 1) workers leads to handoff node being enabled. This node pops next feature index to nat.arc_next to make sure that packet will be pushed to the next feature in the arc. But node nat44-ed-in2out-output also pops next feature and changes arc_next. So actual next feature will be skipped in that case. It leads to all nat44-ed-in2out packets being dropped if we have multiple workers (handoff node enabled). To resolve this a new node was added (nat-pre-in2out-output) to fill arc_next in single worker case and multiple worker case is already handled by handoff node. Type: fix Signed-off-by: Vladimir Isaev <visaev@netgate.com> Change-Id: I9dfba68f00164d2d5ab867224871811bef4411ed (cherry picked from commit 8fb4d10dc208fb3f284fe79e838343797cb2d813)
2020-09-16nat: endian mismatchFilip Varga1-7/+13
Type: fix Change-Id: Icf6ce0ddb5fe9d078503e9d9ff7e7b26423f53f8 Signed-off-by: Filip Varga <fivarga@cisco.com> (cherry picked from commit 2fe25370ba0deed78c1240fa6788c5b5f14d6f97)
2020-09-16quic: Clean quic_crypto_setup_cipherNathan Skrzypczak1-16/+13
Type: fix Change-Id: I4c19636c2be8a577c6cba272708cb04bcc24785b Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com> (cherry picked from commit 8847749269ffd591c7fb6c290b4a311f186fb7c5)
2020-09-16lisp: fix crash with arp and packet trace onOnong Tayeng2-3/+7
With packet trace on, VPP crashes when an arp packet arrives. This patch fixes the crash and also ensures that the packet trace displays the eid info. Type: fix Signed-off-by: Onong Tayeng <otayeng@cisco.com> Change-Id: Iaad09a5e2b33e931ab9bd7bc3d4573b5ed5e4bfd (cherry picked from commit a3960a8b74de5cef51db2c7575f8f2d71a013d0a)
2020-09-16wireguard: fix handshake procedureArtem Glazychev2-12/+17
Type: fix Change-Id: I96e8c5c9c792b1d9aefd39ce3e240d220827b7d1 Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> (cherry picked from commit cf527882e2fe49eda108cd63af175431222beebe)
2020-09-16wireguard: increase FIB source priorityNeale Ranns1-2/+7
Type: fix Signed-off-by: Neale Ranns <nranns@cisco.com> Change-Id: Icc1c458474d357c7d9b3b4df1897500de0c314a1 (cherry picked from commit a26b0d11e91e9abca6220e50f0240ab6ae09c6d3)
2020-09-15crypto: Crypto SW Scheduler Coverity WarningsNeale Ranns1-1/+1
Type: fix Signed-off-by: Neale Ranns <nranns@cisco.com> Change-Id: I7f98d0c7847ecc40b90b78e5ae83f320575be310 (cherry picked from commit 69f77a3a3cca70876bd27c84b5ae932ca942d8de)
2020-09-15crypto-native: fix issues detected by coiverityDamjan Marion2-3/+11
Type: fix Change-Id: Id61aa407eeeb4d44cf47ed39283a0c79ed3abbee Signed-off-by: Damjan Marion <damarion@cisco.com> (cherry picked from commit 139a6ae0dd460a6b8a5884e65cfd96f0c409f69e)
2020-09-15build: fix the the build on centos/rhel 8Yichen Wang2-2/+2
1. Remove uncessary runtime dependency; 2. Add missing build dependency; 3. Fix runtime dependency for api-python3 RPM; Type: make Change-Id: I2700f1a15112effba8d1527aca6467158f81f486 Signed-off-by: Yichen Wang <yicwang@cisco.com> (cherry picked from commit 466872f0896139b34ef8ccf12f7fcc0093d7cb19)