aboutsummaryrefslogtreecommitdiffstats
path: root/build-root
AgeCommit message (Collapse)AuthorFilesLines
2017-02-24Fixed QAT device binding and device unbinding when vpp package is removedRadu Nicolau2-2/+2
Change-Id: I35ad6a42093cad0945df1df09a39c63c4560dce6 Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
2017-02-22VPP-635: CLI Memory leak with invalid parameterBilly McFall1-4/+15
In the CLI parsing, below is a common pattern: /* Get a line of input. */ if (!unformat_user (input, unformat_line_input, line_input)) return 0; while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT) { if (unformat (line_input, "x")) x = 1; : else return clib_error_return (0, "unknown input `%U'", format_unformat_error, line_input); } unformat_free (line_input); The 'else' returns if an unknown string is encountered. There a memory leak because the 'unformat_free(line_input)' is not called. There is a large number of instances of this pattern. Replaced the previous pattern with: /* Get a line of input. */ if (!unformat_user (input, unformat_line_input, line_input)) return 0; while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT) { if (unformat (line_input, "x")) x = 1; : else { error = clib_error_return (0, "unknown input `%U'", format_unformat_error, line_input); goto done: } } /* ...Remaining code... */ done: unformat_free (line_input); return error; } In multiple files, 'unformat_free (line_input);' was never called, so there was a memory leak whether an invalid string was entered or not. Also, there were multiple instance where: error = clib_error_return (0, "unknown input `%U'", format_unformat_error, line_input); used 'input' as the last parameter instead of 'line_input'. The result is that output did not contain the substring in error, instead just an empty string. Fixed all of those as well. There are a lot of file, and very mind numbing work, so tried to keep it to a pattern to avoid mistakes. Change-Id: I8902f0c32a47dd7fb3bb3471a89818571702f1d2 Signed-off-by: Billy McFall <bmcfall@redhat.com> Signed-off-by: Dave Barach <dave@barachs.net>
2017-02-20Update CSIT tests 170213 -> 170220Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I815b3ef67f1664f72f68984087413f4c4985f694 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-02-14Update CSIT tests 170129 -> 170213Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I43cc99ea3ad6266b4792a7721968de89b7328306 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-02-10Update plugin templatesDave Barach3-118/+106
Disguise the string "fd.io coding-style blah blah blah" to avoid spurious checkstyle failures on the emacs lisp code. DGMS. Change-Id: I6b88d9588dff7d67c6e509052ae4f32529684de7 Signed-off-by: Dave Barach <dave@barachs.net>
2017-02-04dpdk: move to uio_pci_genericDamjan Marion3-5/+5
Change-Id: I3d8b7947ae6d721e9b514a59a7d2de49aed419b5 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-02-02Refactor fragile msg macro W and W2 to not burry return control flow.Jon Loeliger1-1/+3
Instead, have them accept and assign a return paramter leaving the return control flow up to the caller. Clean up otherwise misleading returns present even after "NOT REACHED" comments. Change-Id: I0861921f73ab65d55b95eabd27514f0129152723 Signed-off-by: Jon Loeliger <jdl@netgate.com>
2017-02-02Localize the timeout variable within the W message macro.Jon Loeliger1-2/+1
Rather than rely on an unbound variable, explicitly introduce the timeout variable within the 'do { ... } while (0)' construct as a block-local variable. Change-Id: I6e78635290f9b5ab3f56b7f116c5fa762c88c9e9 Signed-off-by: Jon Loeliger <jdl@netgate.com>
2017-02-02Convert message macro S to accept a message pointer parameter;Jon Loeliger1-2/+2
Rather than blindly assume an unbound, fixed message parameter explicilty pass it as a paramter to the S() macro. Change-Id: Ieea1f1815cadd2eec7d9240408d69acdc3caa49a Signed-off-by: Jon Loeliger <jdl@netgate.com>
2017-02-02Convert M() and M2() macros to honor their second, mp, parameter.Jon Loeliger1-2/+2
Now that all the M() and M2() uses properly supply a message pointer as second parameter, fix the macros to use it. Change-Id: I0b8f4848416c3fa2e06755ad6ea7171b7c546124 Signed-off-by: Jon Loeliger <jdl@netgate.com>
2017-02-02Ensure all M() and M2() second parameters are the message pointer.Jon Loeliger1-1/+1
Rather than maintain (?) an unused second parameter, t, and pull an unbound message pointer, mp, out of context, explicitly list the message pointer as the second parameter. Change-Id: I92143efda6211cdf6b935470f8c71579742a6b64 Signed-off-by: Jon Loeliger <jdl@netgate.com>
2017-02-02Update default Vagrant box to Ubuntu 16.04, VPP-616Dave Wallace3-12/+22
- Make puppetlabs/ubuntu-16.04-64-nocm the default box - Enable x11 forwarding - Install x11-utils required for emacs to work over X11 - Refactor run.sh - Add VPP_VAGRANT_POST_BUILD environment variable to allow selection of installing VPP or run "make test". - Fix dependencies in src/vppapigen.am Change-Id: I0ec054fdc83feb71ca8396df53ed02bf82ecd7e7 Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2017-01-31Prep work for Coverity upload processing via JenkinsDave Barach1-0/+53
Change-Id: I2575d780d19e12ddf8a77e5596e5d7cc3dbf4233 Signed-off-by: Dave Barach <dave@barachs.net>
2017-01-31Update CSIT tests 170122 -> 170129Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I8293091fda82de587cba0b3bd2f8490d74c001a5 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-01-27package only the vpp binaries (rpm)Gabriel Ganne1-1/+1
The first install regexp of the vpp.spec file was too permissive and included dpdk binaries. Should fix rpm packaging error: Installed (but unpackaged) file(s) found: /usr/bin/dpdk-pdump /usr/bin/dpdk-pmdinfo /usr/bin/dpdk-procinfo /usr/bin/testpmd Change-Id: Ic905307cf07b9eeadf8125aaa3e1922dcc6269b3 Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
2017-01-25Update CSIT tests 170108 -> 170122Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I5abf9026318a7a8b4cd56c0044b7f0061ff41f58 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-01-20Add dpdk development packagingDamjan Marion6-54/+2
Change-Id: I6aa2a6709241d99ce734c29e47487eb456907351 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-17vagrant: stop rsync from wiping changes from /vppPadraig Connolly1-15/+18
*Fixes issue where any changes to the vpp directory withing vagrant are wiped if user reboots the vagrant vm *Rsync will now only run if provisioning hasn't occured before Change-Id: Ic29eb1321fba33e82df4075e7a95c96fa2e6739f Signed-off-by: Padraig Connolly <padraig.connolly@intel.com>
2017-01-17fix rpm warnings for defattr directory of lua/*Gabriel Ganne1-1/+1
eg. Processing files: vpp-api-lua-17.04-rc0~119_g3bd11d78.x86_64 warning: %defattr doesn't define directory mode so file mode defined in %defattr is used for directory: ... Change-Id: Ifd205b6effce6160cf6f7bdbd959e484099ff619 Signed-off-by: Gabriel Ganne <gabriel.ganne@qosmos.com>
2017-01-13Fix remove-rpath script, take 2Damjan Marion1-1/+1
Change-Id: If0fc5adb495b243dc9d7bfb8112ffee79ca1335e Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-13Fix remove-rpath scriptDamjan Marion1-1/+1
Change-Id: Ieb9ca2c5ac64dbb73de1b3dd701bb794c91aeae5 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-13vppctl: new bash completion for vppctl commandsPadraig Connolly1-0/+6
Bash completion for vppctl *vppctl_completion uses generated list vppctl-cmd-list to provide bash completion *List of commands generated using grep, then moved by vpp packaging *Once vpp package installed restart bash to use Change-Id: I3b25e55a432c395af421231cf7c37c2e243fee61 Signed-off-by: Padraig Connolly <padraig.connolly@intel.com>
2017-01-11Remove unnecessary build macro to fix slow builds.Thomas F Herbert1-4/+0
JIRA: VPP-588 Change-Id: I05bcba3158edb4aee12ead82a30c611fddd29352 Signed-off-by: Thomas F Herbert <therbert@redhat.com>
2017-01-11Makefile.am cleanupDamjan Marion2-41/+1
- remove unused stuff - add --quiet flag to libtool - avoid building some tests programs when tests are not enabled Change-Id: Ie34aeec1a598ad811256a00354f66cfddae9d0b9 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-10Revert "vppctl: bash completion for vppctl commands"Damjan Marion2-8/+1
This patch is causing build failures This reverts commit d995c757f05f78aa759b0a65c0a7e38088e690a9. Change-Id: I0c8d5a4208135d77aaa3a6a470d26140f7b74733 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-09vppctl: bash completion for vppctl commandsPadraig Connolly2-1/+8
Added bash completion that will include all commands from build time *Script takes list of commands generated by doxygen-siphon-list *Configured doxygen-siphon makefile to generate just cli commands *List of cli commands put in /usr/share/vpp *Stopped siphon using doxygen bootstrap, uses main bootstrap instead *Added rpm/deb check for installation of packages, separate from bootstrap *NOTE: Once you have installed the vpp .deb/.rpm package you will have to restart bash Change-Id: Ie503e80d5177481f6e7dbe59378f2e0d76f29152 Signed-off-by: Padraig Connolly <padraig.connolly@intel.com>
2017-01-09Update CSIT tests 170101 -> 170108Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I58f1ea5f05a80874a16831bc7d23875d46610daa Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-01-04rename vpp python's api debian scriptsGabriel Ganne2-0/+0
python's api has been renamed from *vpp-python-api* -> *vpp-api-python* deb scripts need to follow the package name in order to be called Change-Id: I0c9ec45cc3d478c3b90aa75bcd2b8a9f7809cbc9 Signed-off-by: Gabriel Ganne <gabriel.ganne@qosmos.com>
2017-01-03fix version.h generation for out-of-tree buildsDamjan Marion1-54/+1
Change-Id: Ic882f5aec74858a36533ed8cd61a7726947dceef Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-03Do not require external vppapigen when not cross-compilingDamjan Marion1-1/+0
Change-Id: I80b8348ed4efd53d292c37a1ff69c13ee4741986 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-03deb: fix issues in debian/control, silence some warningsDamjan Marion2-7/+12
Change-Id: I135646dbc641b1ff517fc137f8c653f7f3fe60fe Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-03vpp-python-api deb packaging - use easy_install to install the python apiroot2-0/+13
Change-Id: I67963d5a6ec324b13c50f8f6c51ed3c715b4c145 Signed-off-by: Gabriel Ganne <gabriel.ganne@qosmos.com>
2017-01-02Update CSIT tests 161218 -> 170101Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I58f631e9319e55e5dd23516776fcbb9e9798a489 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-01-02Update emacs plugin generator skeletonDave Barach5-76/+27
Generated code compiles with the new build scheme, works, etc. Change-Id: I147aa5fa580a71ef25615b02277870867e475042 Signed-off-by: Dave Barach <dave@barachs.net>
2017-01-01Move java,lua api and remaining plugins to src/Damjan Marion10-32/+90
Change-Id: I1c3b87e886603678368428ae56a6bd3327cbc90d Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-12-28Reorganize source tree to use single autotools instanceDamjan Marion7-17/+29
Change-Id: I7b51f88292e057c6443b12224486f2d0c9f8ae23 Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-12-21vagrant: Fixing sudo related vagrant errorsRay Kinsella1-5/+8
The dpkg sudo trigger appears to want to run interactively despite the noninteractive debconf setting. This is a problem upstream for vagrant also, see. https://github.com/hashicorp/terraform/issues/9763 Incorporating the recommended fix to Vagrantfile from upstream https://github.com/hashicorp/terraform/pull/9783 Change-Id: I8da8522fc9e80fc3bd268b347a786054ad019170 Signed-off-by: Ray Kinsella <ray.kinsella@intel.com>
2016-12-21vagrant: updated Vagrantfile to use rsyncRay Kinsella2-58/+16
Replacing problematic nfs & git clone, with a simplier rsync. Change-Id: I26a95bd81b7fbf6ea0179cd62361e0902f2d22ed Signed-off-by: Ray Kinsella <ray.kinsella@intel.com>
2016-12-21fix sample-plugin rpm packagingGabriel Ganne1-2/+2
Change-Id: I0f4d029fe16d1d272c8bbd5c380ba70a646ddb20 Signed-off-by: Gabriel Ganne <gabriel.ganne@qosmos.com>
2016-12-20Remove RPATH from binaries before creating .deb and .rpm packagesDamjan Marion4-2/+32
Change-Id: I684d4eabac03e049524204864c985e14eea8d92e Signed-off-by: Damjan Marion <damarion@cisco.com>
2016-12-19Update CSIT tests 161211 -> 161218Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I2942502803e1fc6edaf35fc08dee4e7848594f96 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2016-12-12Update CSIT tests 161204 -> 161211Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I141dad311139d2b819352fab6038d440f76c7fc2 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2016-12-09python api rpm packaging - json files are not executablesGabriel Ganne1-2/+2
Change-Id: If8231aad2b95cf9e06cd8c95978e6a3128cdf084 Signed-off-by: Gabriel Ganne <gabriel.ganne@qosmos.com>
2016-12-08vpp-python-api packaging - use easy_install to install the python apiGabriel Ganne1-7/+10
adds python-setuptools as dependency Change-Id: I186f5d4353ee7667377fb6b0486d16a1571bdf09 Signed-off-by: Gabriel Ganne <gabriel.ganne@qosmos.com>
2016-12-05Update CSIT tests 161128 -> 161204Jan1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I84bfb828403a32087de3341f27c3e9a04292ca8b Signed-off-by: Jan <jgelety@cisco.com>
2016-12-02API: Packaging of JSON files.Ole Troan4-2/+37
Change-Id: If041b6faf1a091d4758b514f0a8cd800ee0e6a89 Signed-off-by: Ole Troan <ot@cisco.com> Signed-off-by: Ole Troan <otroan@ot-vpp.cisco.com> Signed-off-by: Ole Troan <ot@cisco.com>
2016-12-01"Update CSIT tests 161120 -> 161128""Peter Mikus1-1/+1
This reverts commit b5388a5319ad7da519280afccbdf63f61833122b. Change-Id: I07160d08e469417933b3da3466ce856ab673e955 Signed-off-by: Peter Mikus <pmikus@cisco.com>
2016-12-01Revert "Update CSIT tests 161120 -> 161128"Ed Warnicke1-1/+1
This revert is to probe to see if CSIT tests are being broken by this patch. This reverts gerrit https://gerrit.fd.io/r/#/c/3985/ This reverts commit f8c94313a3ec2e3dfdf7b308516cce315f69f548. Change-Id: I6e1a7285ab077823a5d0350b8eda6bb26609f70c Signed-off-by: Ed Warnicke <eaw@cisco.com>
2016-11-29Update CSIT tests 161120 -> 161128Jan1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: Ib0325dde7bd9f9769660d9c5c72f0fda5e752eaf Signed-off-by: Jan <jgelety@cisco.com>
2016-11-21Add client-side msg_name_and_crc -> msg_index tableDave Barach1-18/+31
vppapigen now generates per-message crcs. Verified that whitespace and real changes in message A don't change the crc for message B, etc. Fixed the sample and flowperpkt plugins to participate. Others need the same treatment. They don't build due to python/java language binding build issues. To use the scheme: Client connects as usual. Then call: u32 vl_api_get_msg_index(char * name_and_crc) name_and_crc is a string like: "flowperpkt_tx_interface_add_del_753301f3", aka the message name with _%08x <expected crc> appended. Try these vpp-api-test commands to play with it: vat# dump_msg_api_table <snip> [366]: punt_reply_cca27fbe [367]: ipsec_spd_dump_5e9ae88e [368]: ipsec_spd_details_6f7821b0 [369]: sample_macswap_enable_disable_0f2813e2 [370]: sample_macswap_enable_disable_reply_476738e5 [371]: flowperpkt_tx_interface_add_del_753301f3 [372]: flowperpkt_tx_interface_add_del_reply_d47e6e0b vat# get_msg_id sample_macswap_enable_disable_reply_476738e5 'sample_macswap_enable_disable_reply_476738e5' has message index 370 vat# get_msg_id sample_macswap_enable_disable_reply_476738e3 'sample_macswap_enable_disable_reply_476738e3' not found CRCs may vary, etc. vppapigen is used to build a set of JSON representations of each API file from vpp-api/Makefile.am and that is in turn used by each language binding (Java, Python, Lua). Change-Id: I3d64582e779dac5f20cddec79c562c288d8fd9c6 Signed-off-by: Dave Barach <dave@barachs.net> Signed-off-by: Ole Troan <ot@cisco.com>