summaryrefslogtreecommitdiffstats
path: root/build-root
AgeCommit message (Collapse)AuthorFilesLines
2017-06-24make: Fix parallel building with some container platforms (VPP-880)Chris Luke1-10/+7
With some Linux container platforms /proc/cpuinfo reads as an empty file. (Aside: stat on /proc/cpuinfo always indicates a length of zero bytes, regardless of its content). This has the effect that the make '-j' parameter being passed the unhelpful value of '0' both in build-root/Makefile and dpdk/Makefile. Make complains with the error: make: the '-j' option requires a positive integer argument This patch checks for '0' and replaces it with '2' as a reasonable number of jobs to run in parallel when the CPU count isn't known (and assumed to be one). It also makes the value determination consistent between VPP and DPDK (2*ncpu). Change-Id: I78b89420114a825fab4d339e4f9291d486b7b9c8 Signed-off-by: Chris Luke <chrisy@flirble.org>
2017-06-22Update CSIT tests 170612 -> 170622Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I5645ebfaa32599797e4edf83b2281270ea4a8376 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-06-12Update CSIT tests 170605 -> 170612Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I0e19f085153ca00ddb46e016cff742b42eca15a0 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-06-06Update CSIT tests 170529 -> 170605Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I49396105470609422f28a49211012fcd9f252587 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-06-02Update CSIT tests 170518 -> 170529Peter Mikus1-1/+1
Change-Id: I33de2948019683961b5ab576db2c3303c8d2bd5e Signed-off-by: Peter Mikus <pmikus@cisco.com>
2017-05-31Revert "Update CSIT tests 170518 -> 170529"Dave Wallace1-1/+1
This reverts commit 9757325c52c223d85abfad834b071077365d4808. Change-Id: I3bee0fe7d48be723334f2bd9fffd3240658b9e71 Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2017-05-29Relocate Coverity scriptsChris Luke2-89/+0
- Move Coverity scripts from build-root/scripts to extras/scripts - Update coverity-build with new path and add some comments Change-Id: I1be8069fb574aaacbac9b7f2c9c80b9aad1790ec Signed-off-by: Chris Luke <chrisy@flirble.org>
2017-05-29Update CSIT tests 170518 -> 170529Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I66357690f41e23dd1b924cc50a951a6c3696e071 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-05-24Simple script to 'git blame' on new Coverity issuesChris Luke1-0/+36
- Pass an email in to stdin and the script produces output similar to: Hi, Please find the latest report on new defect(s) introduced to fd.io VPP found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 167726: Resource leaks (RESOURCE_LEAK) /src/vnet/devices/af_packet/device.c: 215 in af_packet_interface_admin_up_down() ________________________________________________________________________________________________________ *** CID 167726: Resource leaks (RESOURCE_LEAK) /src/vnet/devices/af_packet/device.c: 215 in af_packet_interface_admin_up_down() >>> CID 167726: Resource leaks (RESOURCE_LEAK) >>> Handle variable "fd" going out of scope leaks the handle. 00a9dcad vnet/vnet/devices/af_packet/device.c (Damjan Marion 2016-08-17 209) af_packet_if_t *apif = 00a9dcad vnet/vnet/devices/af_packet/device.c (Damjan Marion 2016-08-17 210) pool_elt_at_index (apm->interfaces, hw->dev_instance); 83cc4e14 vnet/vnet/devices/af_packet/device.c (Alpesh Patel 2016-04-05 211) u32 hw_flags; c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 212) int rv, fd = socket (AF_UNIX, SOCK_DGRAM, 0); c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 213) struct ifreq ifr; c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 214) c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 215) /* if interface is a bridge ignore */ c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 216) if (apif->host_if_index < 0) 2038ad01 src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-05-18 217) goto error; /* no error */ c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 218) c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 219) /* use host_if_index in case host name has changed */ c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 220) ifr.ifr_ifindex = apif->host_if_index; ** CID 167725: Error handling issues (NEGATIVE_RETURNS) /src/vnet/devices/af_packet/device.c: 252 in af_packet_interface_admin_up_down() ________________________________________________________________________________________________________ *** CID 167725: Error handling issues (NEGATIVE_RETURNS) /src/vnet/devices/af_packet/device.c: 252 in af_packet_interface_admin_up_down() >>> CID 167725: Error handling issues (NEGATIVE_RETURNS) >>> "fd" is passed to a parameter that cannot be negative. c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 246) } c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 247) c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 248) if ((rv = ioctl (fd, SIOCSIFFLAGS, &ifr)) < 0) c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 249) { c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 250) clib_unix_warning ("af_packet_%s error: %d", c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 251) apif->is_admin_up ? "up" : "down", rv); 2038ad01 src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-05-18 252) goto error; c855b73f src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-04-21 253) } 83cc4e14 vnet/vnet/devices/af_packet/device.c (Alpesh Patel 2016-04-05 254) 00a9dcad vnet/vnet/devices/af_packet/device.c (Damjan Marion 2016-08-17 255) vnet_hw_interface_set_flags (vnm, hw_if_index, hw_flags); 83cc4e14 vnet/vnet/devices/af_packet/device.c (Alpesh Patel 2016-04-05 256) 2038ad01 src/vnet/devices/af_packet/device.c (Ray Kinsella 2017-05-18 257) error: Change-Id: I9756c16ea24e7520704155ae1f6c5f132087e3bc Signed-off-by: Chris Luke <chrisy@flirble.org>
2017-05-18Update CSIT tests 170504 -> 170518Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I916427584df514088f2d8cbcc3483c397ca4d6f5 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-05-15move to CSIT 170504Neale Ranns1-1/+1
Change-Id: I8b636ff57b6e6c3f4cfd2d77d930524559046dd9 Signed-off-by: Neale Ranns <nranns@cisco.com>
2017-04-26Move scripts to extras/Damjan Marion3-133/+0
Change-Id: I2abd6367915d4652fcf45025bd251046f3f206ab Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-04-24Move emacs stuff to extras/Damjan Marion27-3251/+1
Change-Id: Ibbb7d8500e9064215cf912bd00bdf72a748f8a27 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-04-20Move vagrant stuff to extras/Damjan Marion11-401/+1
Change-Id: I7e3d6ecc3f23d862004c273e23e36e234ceb6015 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-04-20Extend ebuild to specify "configure" subdir, enable verify for sample-pluginDamjan Marion1-2/+4
Change-Id: I2056e5d19bc3713e7a13e015dabf3b2431800973 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-04-19Fix "make dist" to include version number, docouple it from rpm packagingDamjan Marion3-343/+0
Change-Id: If2f9976d668089026c97b897cf449bff09050631 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-04-03Update CSIT tests 170313 -> 170403Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I4bf32bc12c7417f7c19b23287a2b2899eb8fb02d Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-03-27Python API: Fixup of debian package after cFFI changes.Ole Troan4-15/+8
Change-Id: I4c2a1a818f28d4c6cf52af45f3b7dbfa41d77ccb Signed-off-by: Ole Troan <ot@cisco.com>
2017-03-17Python API: Fix RPM packaging (again).Ole Troan1-4/+6
Change-Id: I5c510cde1227a131ddda58d090cd5dbf112ce1fb Signed-off-by: Ole Troan <ot@cisco.com>
2017-03-15Python API: Change from cPython to CFFI.Ole Troan1-9/+3
Change-Id: I03e52466fb3f909ae52b8fba601168f3eadbd972 Signed-off-by: Ole Troan <ot@cisco.com>
2017-03-14Update CSIT tests 170302 -> 170313Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I1a312a4a3085930c0019ec6832cb9f482174eea3 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-03-04Fix duplicate binary API registration messages / bugsDave Barach1-2/+2
Changed vat_api_hookup(...) to <plugin-name>_api_hookup, change to static functions. Fixed the related emacs-lisp plugin skeleton. Change-Id: Id14f8fc3138751f469d48fecb26175e938f5f028 Signed-off-by: Dave Barach <dave@barachs.net>
2017-03-02Update CSIT tests 170220 -> 170302Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: Ia8078ae23e0e6fb701e141fd0701fb82987743d7 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-02-24Fixed QAT device binding and device unbinding when vpp package is removedRadu Nicolau2-2/+2
Change-Id: I35ad6a42093cad0945df1df09a39c63c4560dce6 Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
2017-02-22VPP-635: CLI Memory leak with invalid parameterBilly McFall1-4/+15
In the CLI parsing, below is a common pattern: /* Get a line of input. */ if (!unformat_user (input, unformat_line_input, line_input)) return 0; while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT) { if (unformat (line_input, "x")) x = 1; : else return clib_error_return (0, "unknown input `%U'", format_unformat_error, line_input); } unformat_free (line_input); The 'else' returns if an unknown string is encountered. There a memory leak because the 'unformat_free(line_input)' is not called. There is a large number of instances of this pattern. Replaced the previous pattern with: /* Get a line of input. */ if (!unformat_user (input, unformat_line_input, line_input)) return 0; while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT) { if (unformat (line_input, "x")) x = 1; : else { error = clib_error_return (0, "unknown input `%U'", format_unformat_error, line_input); goto done: } } /* ...Remaining code... */ done: unformat_free (line_input); return error; } In multiple files, 'unformat_free (line_input);' was never called, so there was a memory leak whether an invalid string was entered or not. Also, there were multiple instance where: error = clib_error_return (0, "unknown input `%U'", format_unformat_error, line_input); used 'input' as the last parameter instead of 'line_input'. The result is that output did not contain the substring in error, instead just an empty string. Fixed all of those as well. There are a lot of file, and very mind numbing work, so tried to keep it to a pattern to avoid mistakes. Change-Id: I8902f0c32a47dd7fb3bb3471a89818571702f1d2 Signed-off-by: Billy McFall <bmcfall@redhat.com> Signed-off-by: Dave Barach <dave@barachs.net>
2017-02-20Update CSIT tests 170213 -> 170220Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I815b3ef67f1664f72f68984087413f4c4985f694 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-02-14Update CSIT tests 170129 -> 170213Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I43cc99ea3ad6266b4792a7721968de89b7328306 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-02-10Update plugin templatesDave Barach3-118/+106
Disguise the string "fd.io coding-style blah blah blah" to avoid spurious checkstyle failures on the emacs lisp code. DGMS. Change-Id: I6b88d9588dff7d67c6e509052ae4f32529684de7 Signed-off-by: Dave Barach <dave@barachs.net>
2017-02-04dpdk: move to uio_pci_genericDamjan Marion3-5/+5
Change-Id: I3d8b7947ae6d721e9b514a59a7d2de49aed419b5 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-02-02Refactor fragile msg macro W and W2 to not burry return control flow.Jon Loeliger1-1/+3
Instead, have them accept and assign a return paramter leaving the return control flow up to the caller. Clean up otherwise misleading returns present even after "NOT REACHED" comments. Change-Id: I0861921f73ab65d55b95eabd27514f0129152723 Signed-off-by: Jon Loeliger <jdl@netgate.com>
2017-02-02Localize the timeout variable within the W message macro.Jon Loeliger1-2/+1
Rather than rely on an unbound variable, explicitly introduce the timeout variable within the 'do { ... } while (0)' construct as a block-local variable. Change-Id: I6e78635290f9b5ab3f56b7f116c5fa762c88c9e9 Signed-off-by: Jon Loeliger <jdl@netgate.com>
2017-02-02Convert message macro S to accept a message pointer parameter;Jon Loeliger1-2/+2
Rather than blindly assume an unbound, fixed message parameter explicilty pass it as a paramter to the S() macro. Change-Id: Ieea1f1815cadd2eec7d9240408d69acdc3caa49a Signed-off-by: Jon Loeliger <jdl@netgate.com>
2017-02-02Convert M() and M2() macros to honor their second, mp, parameter.Jon Loeliger1-2/+2
Now that all the M() and M2() uses properly supply a message pointer as second parameter, fix the macros to use it. Change-Id: I0b8f4848416c3fa2e06755ad6ea7171b7c546124 Signed-off-by: Jon Loeliger <jdl@netgate.com>
2017-02-02Ensure all M() and M2() second parameters are the message pointer.Jon Loeliger1-1/+1
Rather than maintain (?) an unused second parameter, t, and pull an unbound message pointer, mp, out of context, explicitly list the message pointer as the second parameter. Change-Id: I92143efda6211cdf6b935470f8c71579742a6b64 Signed-off-by: Jon Loeliger <jdl@netgate.com>
2017-02-02Update default Vagrant box to Ubuntu 16.04, VPP-616Dave Wallace3-12/+22
- Make puppetlabs/ubuntu-16.04-64-nocm the default box - Enable x11 forwarding - Install x11-utils required for emacs to work over X11 - Refactor run.sh - Add VPP_VAGRANT_POST_BUILD environment variable to allow selection of installing VPP or run "make test". - Fix dependencies in src/vppapigen.am Change-Id: I0ec054fdc83feb71ca8396df53ed02bf82ecd7e7 Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2017-01-31Prep work for Coverity upload processing via JenkinsDave Barach1-0/+53
Change-Id: I2575d780d19e12ddf8a77e5596e5d7cc3dbf4233 Signed-off-by: Dave Barach <dave@barachs.net>
2017-01-31Update CSIT tests 170122 -> 170129Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I8293091fda82de587cba0b3bd2f8490d74c001a5 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-01-27package only the vpp binaries (rpm)Gabriel Ganne1-1/+1
The first install regexp of the vpp.spec file was too permissive and included dpdk binaries. Should fix rpm packaging error: Installed (but unpackaged) file(s) found: /usr/bin/dpdk-pdump /usr/bin/dpdk-pmdinfo /usr/bin/dpdk-procinfo /usr/bin/testpmd Change-Id: Ic905307cf07b9eeadf8125aaa3e1922dcc6269b3 Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
2017-01-25Update CSIT tests 170108 -> 170122Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I5abf9026318a7a8b4cd56c0044b7f0061ff41f58 Signed-off-by: Jan Gelety <jgelety@cisco.com>
2017-01-20Add dpdk development packagingDamjan Marion6-54/+2
Change-Id: I6aa2a6709241d99ce734c29e47487eb456907351 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-17vagrant: stop rsync from wiping changes from /vppPadraig Connolly1-15/+18
*Fixes issue where any changes to the vpp directory withing vagrant are wiped if user reboots the vagrant vm *Rsync will now only run if provisioning hasn't occured before Change-Id: Ic29eb1321fba33e82df4075e7a95c96fa2e6739f Signed-off-by: Padraig Connolly <padraig.connolly@intel.com>
2017-01-17fix rpm warnings for defattr directory of lua/*Gabriel Ganne1-1/+1
eg. Processing files: vpp-api-lua-17.04-rc0~119_g3bd11d78.x86_64 warning: %defattr doesn't define directory mode so file mode defined in %defattr is used for directory: ... Change-Id: Ifd205b6effce6160cf6f7bdbd959e484099ff619 Signed-off-by: Gabriel Ganne <gabriel.ganne@qosmos.com>
2017-01-13Fix remove-rpath script, take 2Damjan Marion1-1/+1
Change-Id: If0fc5adb495b243dc9d7bfb8112ffee79ca1335e Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-13Fix remove-rpath scriptDamjan Marion1-1/+1
Change-Id: Ieb9ca2c5ac64dbb73de1b3dd701bb794c91aeae5 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-13vppctl: new bash completion for vppctl commandsPadraig Connolly1-0/+6
Bash completion for vppctl *vppctl_completion uses generated list vppctl-cmd-list to provide bash completion *List of commands generated using grep, then moved by vpp packaging *Once vpp package installed restart bash to use Change-Id: I3b25e55a432c395af421231cf7c37c2e243fee61 Signed-off-by: Padraig Connolly <padraig.connolly@intel.com>
2017-01-11Remove unnecessary build macro to fix slow builds.Thomas F Herbert1-4/+0
JIRA: VPP-588 Change-Id: I05bcba3158edb4aee12ead82a30c611fddd29352 Signed-off-by: Thomas F Herbert <therbert@redhat.com>
2017-01-11Makefile.am cleanupDamjan Marion2-41/+1
- remove unused stuff - add --quiet flag to libtool - avoid building some tests programs when tests are not enabled Change-Id: Ie34aeec1a598ad811256a00354f66cfddae9d0b9 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-10Revert "vppctl: bash completion for vppctl commands"Damjan Marion2-8/+1
This patch is causing build failures This reverts commit d995c757f05f78aa759b0a65c0a7e38088e690a9. Change-Id: I0c8d5a4208135d77aaa3a6a470d26140f7b74733 Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-01-09vppctl: bash completion for vppctl commandsPadraig Connolly2-1/+8
Added bash completion that will include all commands from build time *Script takes list of commands generated by doxygen-siphon-list *Configured doxygen-siphon makefile to generate just cli commands *List of cli commands put in /usr/share/vpp *Stopped siphon using doxygen bootstrap, uses main bootstrap instead *Added rpm/deb check for installation of packages, separate from bootstrap *NOTE: Once you have installed the vpp .deb/.rpm package you will have to restart bash Change-Id: Ie503e80d5177481f6e7dbe59378f2e0d76f29152 Signed-off-by: Padraig Connolly <padraig.connolly@intel.com>
2017-01-09Update CSIT tests 170101 -> 170108Jan Gelety1-1/+1
- update of CSIT operational branch to be used for VPP-patch test Change-Id: I58f1ea5f05a80874a16831bc7d23875d46610daa Signed-off-by: Jan Gelety <jgelety@cisco.com>