aboutsummaryrefslogtreecommitdiffstats
path: root/resources/libraries/bash/entry/tox/README.txt
diff options
context:
space:
mode:
authorVratko Polak <vrpolak@cisco.com>2024-04-17 17:24:24 +0200
committerVratko Polak <vrpolak@cisco.com>2024-04-17 17:24:24 +0200
commitac6f1de626b8a21c88a625cf77dd922d2214d867 (patch)
treee273fab03c26c782cc9e35328ac9842ff0e3e4fc /resources/libraries/bash/entry/tox/README.txt
parentb3c5215bba37bd6555231da8c40ae90d9fc570c9 (diff)
feat(tox): add copyright year fixer script
It uses rather simple sed commands, but seems to work well enough. + Improve readme. + Shortened comments about why 3 lines. Change-Id: I50b395dfeb586f671f7c4c82f22369de90b351ec Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Diffstat (limited to 'resources/libraries/bash/entry/tox/README.txt')
-rw-r--r--resources/libraries/bash/entry/tox/README.txt14
1 files changed, 8 insertions, 6 deletions
diff --git a/resources/libraries/bash/entry/tox/README.txt b/resources/libraries/bash/entry/tox/README.txt
index e13b60209e..9ce21e93d0 100644
--- a/resources/libraries/bash/entry/tox/README.txt
+++ b/resources/libraries/bash/entry/tox/README.txt
@@ -1,4 +1,4 @@
-# Copyright (c) 2022 Cisco and/or its affiliates.
+# Copyright (c) 2024 Cisco and/or its affiliates.
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at:
@@ -14,6 +14,13 @@
This directory contains tox scripts and other files they need.
Generally, a tox script is either a checker (suitable for automated verify)
or a fixer (manually started, risky as uncommitted edits can be lost).
+
+In the tox verify job we want to avoid running fixers,
+as they can affect what other checkers see
+(e.g. autogen fixer could add more too long lines).
+That is why we keep fixers separate from checkers in principle,
+even for fairly safe tasks (e.g. bumping copyright years).
+
Each tox script is assumed to be run from tox,
when working directory is set to ${CSIT_DIR}.
@@ -26,14 +33,9 @@ Each checker script should:
+ Only the output suitable for automated processing by an external caller
should be written to stdout.
++ The level of "less verbose" depends on check and state of codebase.
-+ TODO: Should we carefully document which files are
- whitelisted/blacklisted for a particulat check?
Each fixer script should:
+ Perform edits on current filesystem
+ Not assume git is clean (there may be uncommitted edits).
+ Use "git diff HEAD~" to get both comitted and uncomitted edits to analyze.
+ Output whatever it wants (possibly nothing).
-
-TODO: Should checkers be named differently than fixers?
- E.g. both scripts and tox environments start with fix_?