feat: Due to the deep modifications related to names and packet format,

this task cover a large part of the codebase and involves several changes:

- the library provides a name data structure (hicn_name_t ), which is composed
  of a name prefix (hicn_name_prefix_t) and a name suffix (hicn_name_suffix_t),
  and it has been extended to provide all support functions required for name
  manipulation, including common prefix computation, as required for the Longest
  Prefix Match (LPM)in the forwarder, in addition to Exact Prefix Match (EPM).
- all code has been rewritten to use this data structure instead of having for
  instance the forwarder define its own name class (used to be Name and NameBitVector)
  the code has been refactored to minimize name allocations and copies, one remaining
  aspect is the difference of name storage between PIT and CS entries (respectively
  in the PIT entry, and in the message buffer), which causes the packet cache
  index to be updated when a PIT entry is converted into a CS entry. By storing
  the name in the PIT/CS entry everytime, we might save on this operation).
- hicn-light FIB has been rewritten : code has been refactored and should now be
  shorter and documented; unit tests have been drafted but more would be required
  to cover all cases and match the algorithms to add/remove nodes, as specified in the doc.
  all protocol details and hICN header formats are now abstracted by the library
  for the forwarder (and thus header.h and  protocols/*.h have been removed from
  public includes, and replaced by packet.h providing protocol agnostic packet
  level functions, completely replacing the compat.h header that used to provide
  similar functions.
- this works by exposing a opaque buffer to the application (a kind of socket buffer)
  which is used by the lib to cache the packet format and offsets of the different
  layers in the buffer and provider efficient operations (the packet format is
  either defined for packet construction, or guessed at ingress, and this structure
  is updated accordingly only once).

Co-authored-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Signed-off-by: Luca Muscariello <muscariello@ieee.org>
Change-Id: I31e321897f85f0267fe8ba4720363c180564492f

3 files changed, 15 insertions, 25 deletions

diff --git a/ctrl/facemgr/includes/hicn/facemgr/api.h b/ctrl/facemgr/includes/hicn/facemgr/api.h
index 3fe049c06..582be0e78 100644
--- a/ctrl/facemgr/includes/hicn/facemgr/api.h
+++ b/ctrl/facemgr/includes/hicn/facemgr/api.h
@@ -44,7 +44,7 @@ typedef int (*facemgr_cb_t)(void *loop, facemgr_cb_type_t type, void *data);
 
 typedef struct {
   uint16_t local_port;
-  ip_address_t remote_addr;
+  hicn_ip_address_t remote_addr;
   uint16_t remote_port;
 } facemgr_overlay_setting_t;
 
diff --git a/ctrl/facemgr/includes/hicn/facemgr/cfg.h b/ctrl/facemgr/includes/hicn/facemgr/cfg.h
index bbbe81825..57d8f35bc 100644
--- a/ctrl/facemgr/includes/hicn/facemgr/cfg.h
+++ b/ctrl/facemgr/includes/hicn/facemgr/cfg.h
@@ -76,8 +76,9 @@ int facemgr_cfg_rule_set_ipv6(facemgr_cfg_rule_t* cfg_rule, bool status);
 int facemgr_cfg_rule_unset_ipv6(facemgr_cfg_rule_t* cfg_rule);
 
 int facemgr_cfg_rule_set_overlay(facemgr_cfg_rule_t* rule, int family,
-                                 ip_address_t* local_addr, uint16_t local_port,
-                                 ip_address_t* remote_addr,
+                                 hicn_ip_address_t* local_addr,
+                                 uint16_t local_port,
+                                 hicn_ip_address_t* remote_addr,
                                  uint16_t remote_port);
 int facemgr_rule_unset_overlay(facemgr_cfg_rule_t* rule, int family);
 
@@ -93,8 +94,9 @@ int facemgr_cfg_set_ipv6(facemgr_cfg_t* cfg, bool status);
 int facemgr_cfg_unset_ipv6(facemgr_cfg_t* cfg);
 
 int facemgr_cfg_set_overlay(facemgr_cfg_t* cfg, int family,
-                            ip_address_t* local_addr, uint16_t local_port,
-                            ip_address_t* remote_addr, uint16_t remote_port);
+                            hicn_ip_address_t* local_addr, uint16_t local_port,
+                            hicn_ip_address_t* remote_addr,
+                            uint16_t remote_port);
 int facemgr_cfg_unset_overlay(facemgr_cfg_t* cfg, int family);
 
 int facemgr_cfg_add_rule(facemgr_cfg_t* cfg, facemgr_cfg_rule_t* rule);
@@ -128,7 +130,7 @@ int facemgr_cfg_get_ipv6(const facemgr_cfg_t* cfg, const netdevice_t* netdevice,
 int facemgr_cfg_get_overlay_local_addr(const facemgr_cfg_t* cfg,
                                        const netdevice_t* netdevice,
                                        netdevice_type_t netdevice_type,
-                                       int family, ip_address_t* addr);
+                                       int family, hicn_ip_address_t* addr);
 int facemgr_cfg_get_overlay_local_port(const facemgr_cfg_t* cfg,
                                        const netdevice_t* netdevice,
                                        netdevice_type_t netdevice_type,
@@ -136,7 +138,7 @@ int facemgr_cfg_get_overlay_local_port(const facemgr_cfg_t* cfg,
 int facemgr_cfg_get_overlay_remote_addr(const facemgr_cfg_t* cfg,
                                         const netdevice_t* netdevice,
                                         netdevice_type_t netdevice_type,
-                                        int family, ip_address_t* addr);
+                                        int family, hicn_ip_address_t* addr);
 int facemgr_cfg_get_overlay_remote_port(const facemgr_cfg_t* cfg,
                                         const netdevice_t* netdevice,
                                         netdevice_type_t netdevice_type,
@@ -154,11 +156,13 @@ int facemgr_cfg_rule_get_ignore(const facemgr_cfg_rule_t* cfg_rule,
 int facemgr_cfg_rule_get_ipv4(const facemgr_cfg_rule_t* cfg_rule, bool* status);
 int facemgr_cfg_rule_get_ipv6(const facemgr_cfg_rule_t* cfg_rule, bool* status);
 int facemgr_cfg_rule_get_overlay_local_addr(const facemgr_cfg_rule_t* rule,
-                                            int family, ip_address_t* addr);
+                                            int family,
+                                            hicn_ip_address_t* addr);
 int facemgr_cfg_rule_get_overlay_local_port(const facemgr_cfg_rule_t* rule,
                                             int family, uint16_t* port);
 int facemgr_cfg_rule_get_overlay_remote_addr(const facemgr_cfg_rule_t* rule,
-                                             int family, ip_address_t* addr);
+                                             int family,
+                                             hicn_ip_address_t* addr);
 int facemgr_cfg_rule_get_overlay_remote_port(const facemgr_cfg_rule_t* rule,
                                              int family, uint16_t* port);
 
diff --git a/ctrl/facemgr/includes/hicn/facemgr/facelet.h b/ctrl/facemgr/includes/hicn/facemgr/facelet.h
index d9c986731..9b04832b3 100644
--- a/ctrl/facemgr/includes/hicn/facemgr/facelet.h
+++ b/ctrl/facemgr/includes/hicn/facemgr/facelet.h
@@ -168,32 +168,18 @@ extern const char* facelet_attr_status_str_short[];
 
 /* Facelet attribute */
 
-#ifdef WITH_POLICY
 #define foreach_facelet_attr          \
   _(netdevice_type_t, netdevice_type) \
   _(netdevice_t, netdevice)           \
   _(int, family)                      \
-  _(ip_address_t, local_addr)         \
+  _(hicn_ip_address_t, local_addr)    \
   _(u16, local_port)                  \
-  _(ip_address_t, remote_addr)        \
+  _(hicn_ip_address_t, remote_addr)   \
   _(u16, remote_port)                 \
   _(face_state_t, admin_state)        \
   _(face_state_t, state)              \
   _(u32, priority)                    \
   _(facemgr_face_type_t, face_type)
-#else
-#define foreach_facelet_attr          \
-  _(netdevice_type_t, netdevice_type) \
-  _(netdevice_t, netdevice)           \
-  _(int, family)                      \
-  _(ip_address_t, local_addr)         \
-  _(u16, local_port)                  \
-  _(ip_address_t, remote_addr)        \
-  _(u16, remote_port)                 \
-  _(face_state_t, admin_state)        \
-  _(face_state_t, state)              \
-  _(facemgr_face_type_t, face_type)
-#endif /* WITH_POLICY */
 
 #define foreach_facelet_event \
   _(UNDEFINED)                \