feat: Due to the deep modifications related to names and packet format,

this task cover a large part of the codebase and involves several changes:

- the library provides a name data structure (hicn_name_t ), which is composed
  of a name prefix (hicn_name_prefix_t) and a name suffix (hicn_name_suffix_t),
  and it has been extended to provide all support functions required for name
  manipulation, including common prefix computation, as required for the Longest
  Prefix Match (LPM)in the forwarder, in addition to Exact Prefix Match (EPM).
- all code has been rewritten to use this data structure instead of having for
  instance the forwarder define its own name class (used to be Name and NameBitVector)
  the code has been refactored to minimize name allocations and copies, one remaining
  aspect is the difference of name storage between PIT and CS entries (respectively
  in the PIT entry, and in the message buffer), which causes the packet cache
  index to be updated when a PIT entry is converted into a CS entry. By storing
  the name in the PIT/CS entry everytime, we might save on this operation).
- hicn-light FIB has been rewritten : code has been refactored and should now be
  shorter and documented; unit tests have been drafted but more would be required
  to cover all cases and match the algorithms to add/remove nodes, as specified in the doc.
  all protocol details and hICN header formats are now abstracted by the library
  for the forwarder (and thus header.h and  protocols/*.h have been removed from
  public includes, and replaced by packet.h providing protocol agnostic packet
  level functions, completely replacing the compat.h header that used to provide
  similar functions.
- this works by exposing a opaque buffer to the application (a kind of socket buffer)
  which is used by the lib to cache the packet format and offsets of the different
  layers in the buffer and provider efficient operations (the packet format is
  either defined for packet construction, or guessed at ingress, and this structure
  is updated accordingly only once).

Co-authored-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Signed-off-by: Luca Muscariello <muscariello@ieee.org>
Change-Id: I31e321897f85f0267fe8ba4720363c180564492f

1 files changed, 9 insertions, 8 deletions

diff --git a/ctrl/facemgr/src/interfaces/bonjour/bonjour.c b/ctrl/facemgr/src/interfaces/bonjour/bonjour.c
index 90f18c299..e7de5d648 100644
--- a/ctrl/facemgr/src/interfaces/bonjour/bonjour.c
+++ b/ctrl/facemgr/src/interfaces/bonjour/bonjour.c
@@ -211,8 +211,8 @@ static mdns_string_t ipv6_address_to_string(char* buffer, size_t capacity,
   return str;
 }
 
-static mdns_string_t ip_address_to_string(char* buffer, size_t capacity,
-                                          const struct sockaddr* addr) {
+static mdns_string_t hicn_ip_address_to_string(char* buffer, size_t capacity,
+                                               const struct sockaddr* addr) {
   if (addr->sa_family == AF_INET6)
     return ipv6_address_to_string(buffer, capacity,
                                   (const struct sockaddr_in6*)addr);
@@ -220,7 +220,8 @@ static mdns_string_t ip_address_to_string(char* buffer, size_t capacity,
                                 (const struct sockaddr_in*)addr);
 }
 
-int ip_address_set_sockaddr(ip_address_t* ip_address, struct sockaddr* sa) {
+int hicn_ip_address_set_sockaddr(hicn_ip_address_t* ip_address,
+                                 struct sockaddr* sa) {
   switch (sa->sa_family) {
     case AF_INET:
       ip_address->v4.as_inaddr = ((struct sockaddr_in*)sa)->sin_addr;
@@ -245,7 +246,7 @@ static int callback(const struct sockaddr* from, mdns_entry_type_t entry,
   struct sockaddr_storage addr;
 
   mdns_string_t fromaddrstr =
-      ip_address_to_string(addrbuffer, sizeof(addrbuffer), from);
+      hicn_ip_address_to_string(addrbuffer, sizeof(addrbuffer), from);
   const char* entrytype =
       (entry == MDNS_ENTRYTYPE_ANSWER)
           ? "answer"
@@ -253,10 +254,10 @@ static int callback(const struct sockaddr* from, mdns_entry_type_t entry,
 
   switch (type) {
     case MDNS_RECORDTYPE_A: {
-      ip_address_t ip_address;
+      hicn_ip_address_t ip_address;
       mdns_record_parse_a(data, size, offset, length,
                           (struct sockaddr_in*)&addr);
-      ip_address_set_sockaddr(&ip_address, (struct sockaddr*)&addr);
+      hicn_ip_address_set_sockaddr(&ip_address, (struct sockaddr*)&addr);
 
       mdns_string_t addrstr = ipv4_address_to_string(
           namebuffer, sizeof(namebuffer), (struct sockaddr_in*)&addr);
@@ -276,10 +277,10 @@ static int callback(const struct sockaddr* from, mdns_entry_type_t entry,
     }
 
     case MDNS_RECORDTYPE_AAAA: {
-      ip_address_t ip_address;
+      hicn_ip_address_t ip_address;
       mdns_record_parse_aaaa(data, size, offset, length,
                              (struct sockaddr_in6*)&addr);
-      ip_address_set_sockaddr(&ip_address, (struct sockaddr*)&addr);
+      hicn_ip_address_set_sockaddr(&ip_address, (struct sockaddr*)&addr);
 
       mdns_string_t addrstr = ipv6_address_to_string(
           namebuffer, sizeof(namebuffer), (struct sockaddr_in6*)&addr);