diff options
| author |   jaszha03 <jason.zhang2@arm.com> | 2019-07-11 20:47:24 +0000 |
|---|---|---|
| committer |   Dave Barach <openvpp@barachs.net> | 2019-07-31 13:53:55 +0000 |
| commit | 5cdde5c25a0e71d923a6d56e5c94e058887f95d8 (patch) | |
| tree | c54eeb5a91ce67417806fabd1fca8d287993e71d /src/plugins/lb/lb.h | |
| parent | 9a4e631890a70978d414b4937cb94b50cfd778e6 (diff) | |
vppinfra: refactor test_and_set spinlocks to use clib_spinlock_t
Spinlock performance improved when implemented with compare_and_exchange
instead of test_and_set. All instances of test_and_set locks were refactored
to use clib_spinlock_t when possible. Some locks e.g. ssvm synchronize
between processes rather than threads, so they cannot directly use
clib_spinlock_t.
Type: refactor
Change-Id: Ia16b5d4cd49209b2b57b8df6c94615c28b11bb60
Signed-off-by: Jason Zhang <jason.zhang2@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Lijian Zhang <Lijian.Zhang@arm.com>
Diffstat (limited to 'src/plugins/lb/lb.h')
| -rw-r--r-- | src/plugins/lb/lb.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/plugins/lb/lb.h b/src/plugins/lb/lb.h index d09ac632be6..9899eab1fc8 100644 --- a/src/plugins/lb/lb.h +++ b/src/plugins/lb/lb.h @@ -41,6 +41,7 @@ #include <vppinfra/bihash_8_8.h> #include <vppinfra/bihash_24_8.h> #include <lb/lbhash.h> +#include <vppinfra/lock.h> #define LB_DEFAULT_PER_CPU_STICKY_BUCKETS 1 << 10 #define LB_DEFAULT_FLOW_TIMEOUT 40 @@ -561,7 +562,7 @@ typedef struct { */ u16 msg_id_base; - volatile u32 *writer_lock; + clib_spinlock_t writer_lock; /* convenience */ vlib_main_t *vlib_main; |