diff options
| author |   Filip Varga <filipvarga89@gmail.com> | 2022-11-23 10:47:56 -0800 |
|---|---|---|
| committer |   Matthew Smith <mgsmith@netgate.com> | 2022-12-09 18:24:08 +0000 |
| commit | 36c7e7cb34ba611e020be9f7ad4a93f9e6a8496d (patch) | |
| tree | c372c8bef2ebef51d952802becf5ef2f5c14f2bc /src/plugins/nat/nat44-ed | |
| parent | c62ddb61a5963102bc9fed2f3cfc567d38caf741 (diff) | |
nat: fixed return values of enable/disable call
NAT44 enable/disable return status was used
instead of appropriate VNET_API_ERROR_ code.
Type: fix
Signed-off-by: Filip Varga <filipvarga89@gmail.com>
Change-Id: If944866bf3061afdc91284c0ad475135e529bdc4
Diffstat (limited to 'src/plugins/nat/nat44-ed')
| -rw-r--r-- | src/plugins/nat/nat44-ed/nat44_ed.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/plugins/nat/nat44-ed/nat44_ed.c b/src/plugins/nat/nat44-ed/nat44_ed.c index 133c39e28c3..348fff2619d 100644 --- a/src/plugins/nat/nat44-ed/nat44_ed.c +++ b/src/plugins/nat/nat44-ed/nat44_ed.c @@ -59,7 +59,7 @@ static_always_inline void nat_validate_interface_counters (snat_main_t *sm, if (PREDICT_FALSE (sm->enabled)) \ { \ nat_log_err ("plugin enabled"); \ - return 1; \ + return VNET_API_ERROR_FEATURE_ALREADY_ENABLED; \ } \ } \ while (0) @@ -71,7 +71,7 @@ static_always_inline void nat_validate_interface_counters (snat_main_t *sm, if (PREDICT_FALSE (!sm->enabled)) \ { \ nat_log_err ("plugin disabled"); \ - return 1; \ + return VNET_API_ERROR_FEATURE_ALREADY_DISABLED; \ } \ } \ while (0) @@ -2626,19 +2626,19 @@ nat44_plugin_disable () rc = nat44_ed_del_static_mappings (); if (rc) - error = 1; + error = VNET_API_ERROR_BUG; rc = nat44_ed_del_addresses (); if (rc) - error = 1; + error = VNET_API_ERROR_BUG; rc = nat44_ed_del_interfaces (); if (rc) - error = 1; + error = VNET_API_ERROR_BUG; rc = nat44_ed_del_output_interfaces (); if (rc) - error = 1; + error = VNET_API_ERROR_BUG; nat44_ed_del_vrf_tables (); |