diff options
| author |   Dave Barach <dave@barachs.net> | 2020-02-17 09:13:26 -0500 |
|---|---|---|
| committer |   Florin Coras <florin.coras@gmail.com> | 2020-02-17 17:18:18 +0000 |
| commit | 47d41ad62c5d6008e72d2e9c137cf8f49ca86353 (patch) | |
| tree | a21f871a26f97c6a47fbfbae4b4d67f27c6036f5 /src/vnet/session/application_worker.c | |
| parent | a316744bc5e003d0fa4c8aff82c619b300115f02 (diff) | |
misc: fix coverity warnings
Add an ALWAYS_ASSERT (...) macro, to (a) shut up coverity, and (b)
check the indicated condition in production images.
As in:
p = hash_get(...);
ALWAYS_ASSERT(p) /* was ASSERT(p) */
elt = pool_elt_at_index(pool, p[0]);
This may not be the best way to handle a specific case, but failure to
check return values at all followed by e.g. a pointer dereference
isn't ok.
Type: fix
Ticket: VPP-1837
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ia97c641cefcfb7ea7d77ea5a55ed4afea0345acb
Diffstat (limited to 'src/vnet/session/application_worker.c')
| -rw-r--r-- | src/vnet/session/application_worker.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vnet/session/application_worker.c b/src/vnet/session/application_worker.c index 1db6baab74e..0b67d2922bf 100644 --- a/src/vnet/session/application_worker.c +++ b/src/vnet/session/application_worker.c @@ -468,7 +468,7 @@ app_worker_get_listen_segment_manager (app_worker_t * app, { uword *smp; smp = hash_get (app->listeners_table, listen_session_get_handle (listener)); - ASSERT (smp != 0); + ALWAYS_ASSERT (smp != 0); return segment_manager_get (*smp); } |