diff options
| author |   Florin Coras <fcoras@cisco.com> | 2024-03-09 15:51:50 -0800 |
|---|---|---|
| committer |   Florin Coras <florin.coras@gmail.com> | 2024-03-10 00:13:01 +0000 |
| commit | 236534136d5824bd29fd9842262b05e48111b2b2 (patch) | |
| tree | 9d59d6e95ab00ea41cffcef201fea5cc32956a85 /src/vnet/session/transport.c | |
| parent | 91bfe5b658b14acdbecf7a0f357bfafaf1124c66 (diff) | |
session: use no for ports in transport port allocator
Type: improvement
Change-Id: Ia1d8aaa3c51938cfa15dd09102471f52ebe67a3d
Signed-off-by: Florin Coras <fcoras@cisco.com>
Diffstat (limited to 'src/vnet/session/transport.c')
| -rw-r--r-- | src/vnet/session/transport.c | 22 |
1 files changed, 14 insertions, 8 deletions
diff --git a/src/vnet/session/transport.c b/src/vnet/session/transport.c index e6eb9d7ee3b..1c2a9261d3c 100644 --- a/src/vnet/session/transport.c +++ b/src/vnet/session/transport.c @@ -528,11 +528,13 @@ transport_release_local_endpoint (u8 proto, ip46_address_t *lcl_ip, u16 port) u32 lepi; lepi = transport_endpoint_lookup (&tm->local_endpoints_table, proto, lcl_ip, - clib_net_to_host_u16 (port)); + port); if (lepi == ENDPOINT_INVALID_INDEX) return -1; - lep = pool_elt_at_index (tm->local_endpoints, lepi); + /* First worker may be cleaning up ports so avoid touching free bitmap */ + lep = &tm->local_endpoints[lepi]; + ASSERT (lep->refcnt >= 1); /* Local endpoint no longer in use, program cleanup */ if (!clib_atomic_sub_fetch (&lep->refcnt, 1)) @@ -583,7 +585,7 @@ transport_share_local_endpoint (u8 proto, ip46_address_t * lcl_ip, u16 port) * used to allocate and free ports. So, pool has only one writer and * potentially many readers. Listeners are allocated with barrier */ lepi = transport_endpoint_lookup (&tm->local_endpoints_table, proto, lcl_ip, - clib_net_to_host_u16 (port)); + port); if (lepi != ENDPOINT_INVALID_INDEX) { lep = pool_elt_at_index (tm->local_endpoints, lepi); @@ -594,6 +596,8 @@ transport_share_local_endpoint (u8 proto, ip46_address_t * lcl_ip, u16 port) /** * Allocate local port and add if successful add entry to local endpoint * table to mark the pair as used. + * + * @return port in net order or -1 if port cannot be allocated */ int transport_alloc_local_port (u8 proto, ip46_address_t *lcl_addr, @@ -619,7 +623,10 @@ transport_alloc_local_port (u8 proto, ip46_address_t *lcl_addr, { port = random_u32 (&tm->port_allocator_seed) & PORT_MASK; if (PREDICT_TRUE (port >= min && port < max)) - break; + { + port = clib_host_to_net_u16 (port); + break; + } } if (!transport_endpoint_mark_used (proto, lcl_addr, port)) @@ -733,10 +740,9 @@ transport_alloc_local_endpoint (u8 proto, transport_endpoint_cfg_t * rmt_cfg, } else { - port = clib_net_to_host_u16 (rmt_cfg->peer.port); - *lcl_port = port; + *lcl_port = rmt_cfg->peer.port; - if (!transport_endpoint_mark_used (proto, lcl_addr, port)) + if (!transport_endpoint_mark_used (proto, lcl_addr, rmt_cfg->peer.port)) return 0; /* IP:port pair already in use, check if 6-tuple available */ @@ -746,7 +752,7 @@ transport_alloc_local_endpoint (u8 proto, transport_endpoint_cfg_t * rmt_cfg, return SESSION_E_PORTINUSE; /* 6-tuple is available so increment lcl endpoint refcount */ - transport_share_local_endpoint (proto, lcl_addr, port); + transport_share_local_endpoint (proto, lcl_addr, rmt_cfg->peer.port); return 0; } |