diff options
| author |   Florin Coras <fcoras@cisco.com> | 2022-01-06 11:58:24 -0800 |
|---|---|---|
| committer | Florin Coras <fcoras@cisco.com> | 2022-01-06 16:38:24 -0800 |
| commit | c8144356338995a277593bc08315d3b1ddcc8cb3 (patch) | |
| tree | 4eed6c04bf1e924e9d7312efe20af34db429c88b /src/vnet/tcp/tcp.c | |
| parent | ed5be47009aca45008ba9d44e76ac51ec1f7f156 (diff) | |
tcp: update snd_congestion only during congestion
If running without sacks, if snd_una does not cover snd_congestion fast
recovery can be missed but the two heuristics from RFC6582 should avoid
that.
Also snd_congestion was used as a means of inferring if the connection
recently exited congestion while setting the persist timer but that does
not always work correctly if not congested.
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I94d4ac738cdd4f7f23f62e97dd63059de1cd4af9
Diffstat (limited to 'src/vnet/tcp/tcp.c')
| -rw-r--r-- | src/vnet/tcp/tcp.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/vnet/tcp/tcp.c b/src/vnet/tcp/tcp.c index 3d3cc886024..ffe5c895cc9 100644 --- a/src/vnet/tcp/tcp.c +++ b/src/vnet/tcp/tcp.c @@ -71,6 +71,10 @@ tcp_add_del_adjacency (tcp_connection_t * tc, u8 is_add) static void tcp_cc_init (tcp_connection_t * tc) { + /* As per RFC 6582 initialize "recover" to iss */ + if (tcp_opts_sack_permitted (&tc->rcv_opts)) + tc->snd_congestion = tc->iss; + tc->cc_algo->init (tc); } |