diff options
| author |   Paul Vinciguerra <pvinci@vinciconsulting.com> | 2019-03-06 11:58:06 -0800 |
|---|---|---|
| committer |   Ole Trøan <otroan@employees.org> | 2019-03-07 22:29:44 +0000 |
| commit | eaea421e1fefedc47325f970475c5d48c899433c (patch) | |
| tree | d325f642804865b6a57bf75f8ba2897bd438a8a2 /test/test_reassembly.py | |
| parent | ea2450fa2d1e8ba0295ea9861a404796100dad1e (diff) | |
Tests: Refactor payload_to_info()
All callers of payload_to_info were required to wrap payload with str().
Refactor to call scapy's payload.load for raw payloads or specify the
specific fieldname.
Change-Id: I1c80599d4df8dc129dbb8274733afaad406d5bcf
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Diffstat (limited to 'test/test_reassembly.py')
| -rw-r--r-- | test/test_reassembly.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/test_reassembly.py b/test/test_reassembly.py index aee67b185cc..8004f362f3d 100644 --- a/test/test_reassembly.py +++ b/test/test_reassembly.py @@ -52,7 +52,7 @@ class TestIPReassemblyMixin(object): self.logger.debug(ppp("Got packet:", packet)) ip = packet[scapy_ip_family] udp = packet[UDP] - payload_info = self.payload_to_info(str(packet[Raw])) + payload_info = self.payload_to_info(packet[Raw]) packet_index = payload_info.index self.assertTrue( packet_index not in dropped_packet_indexes, @@ -899,7 +899,7 @@ class TestIPv4ReassemblyLocalNode(VppTestCase): self.logger.debug(ppp("Got packet:", packet)) ip = packet[IP] icmp = packet[ICMP] - payload_info = self.payload_to_info(str(packet[Raw])) + payload_info = self.payload_to_info(packet[Raw]) packet_index = payload_info.index if packet_index in seen: raise Exception(ppp("Duplicate packet received", packet)) @@ -997,7 +997,7 @@ class TestFIFReassembly(VppTestCase): self.logger.debug(ppp("Got packet:", packet)) ip = packet[ip_class] udp = packet[UDP] - payload_info = self.payload_to_info(str(packet[Raw])) + payload_info = self.payload_to_info(packet[Raw]) packet_index = payload_info.index self.assertTrue( packet_index not in dropped_packet_indexes, |