aboutsummaryrefslogtreecommitdiffstats
path: root/test/test_syslog.py
diff options
context:
space:
mode:
authorPaul Vinciguerra <pvinci@vinciconsulting.com>2019-01-14 08:51:17 -0800
committerNeale Ranns <nranns@cisco.com>2019-01-18 11:27:00 +0000
commitd75320988853736b3d497ccb3f054bc8cc27b207 (patch)
tree79701c10fa5b7d41efb31e0b45fb133eae21f519 /test/test_syslog.py
parentd870ce441272d7057c8cb2b8f9731ebe41a17f0a (diff)
VTL: Don't swallow exceptions from syslog_rfc5424_parser
Change-Id: I4e93073ceb7b75476e847ae8d56301770c8b264f Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Diffstat (limited to 'test/test_syslog.py')
-rw-r--r--test/test_syslog.py12
1 files changed, 7 insertions, 5 deletions
diff --git a/test/test_syslog.py b/test/test_syslog.py
index b407bdf6a55..ddc771bc349 100644
--- a/test/test_syslog.py
+++ b/test/test_syslog.py
@@ -18,7 +18,7 @@ class TestSyslog(VppTestCase):
super(TestSyslog, cls).setUpClass()
try:
- cls.create_pg_interfaces(range(1))
+ cls.pg0, = cls.create_pg_interfaces(range(1))
cls.pg0.admin_up()
cls.pg0.config_ip4()
cls.pg0.resolve_arp()
@@ -35,7 +35,7 @@ class TestSyslog(VppTestCase):
:param facility: facility value
:param severity: severity level
:param appname: application name that originate message
- :param msgid: message indetifier
+ :param msgid: message identifier
:param sd: structured data (optional)
:param msg: free-form message (optional)
"""
@@ -71,7 +71,7 @@ class TestSyslog(VppTestCase):
:param facility: facility value
:param severity: severity level
:param appname: application name that originate message
- :param msgid: message indetifier
+ :param msgid: message identifier
:param sd: structured data (optional)
:param msg: free-form message (optional)
"""
@@ -80,6 +80,10 @@ class TestSyslog(VppTestCase):
sd = {}
try:
message = SyslogMessage.parse(message)
+ except ParseError as e:
+ self.logger.error(e)
+ raise
+ else:
self.assertEqual(message.facility, facility)
self.assertEqual(message.severity, severity)
self.assertEqual(message.appname, appname)
@@ -88,8 +92,6 @@ class TestSyslog(VppTestCase):
self.assertEqual(message.sd, sd)
self.assertEqual(message.version, 1)
self.assertEqual(message.hostname, self.pg0.local_ip4)
- except ParseError as e:
- self.logger.error(e)
def test_syslog(self):
""" Syslog Protocol test """