diff options
| author |   Paul Vinciguerra <pvinci@vinciconsulting.com> | 2019-03-06 15:11:28 -0800 |
|---|---|---|
| committer |   Ole Trøan <otroan@employees.org> | 2019-03-11 08:09:23 +0000 |
| commit | 9a6dafd569db0d0b5dc9d7b5b34b17e3f411a9ee (patch) | |
| tree | 3459a0c6df3fd09548daa9c315145dd2aaf03775 /test/test_tcp.py | |
| parent | f70cead5eb928954908de48300cc7a9c88430c0f (diff) | |
Tests: use self.assertNotIn().
Many tests use self.assertEqual(error.find("failed"), -1)
Use self.assertNotIn("failed", error) to provide more meaningful errors such as
AssertionError: 'Failed' not found in '' instead of 0 != -1.
Change-Id: I670acdc977b788b2cedf94cfeafc12097781463f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Diffstat (limited to 'test/test_tcp.py')
| -rw-r--r-- | test/test_tcp.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/test_tcp.py b/test/test_tcp.py index 5f2bce5ae63..b7ce596bdd9 100644 --- a/test/test_tcp.py +++ b/test/test_tcp.py @@ -66,14 +66,14 @@ class TestTCP(VppTestCase): uri) if error: self.logger.critical(error) - self.assertEqual(error.find("failed"), -1) + self.assertNotIn("failed", error) error = self.vapi.cli("test echo client mbytes 10 appns 1 " + "fifo-size 4 no-output test-bytes " + "syn-timeout 2 uri " + uri) if error: self.logger.critical(error) - self.assertEqual(error.find("failed"), -1) + self.assertNotIn("failed", error) # Delete inter-table routes ip_t01.remove_vpp_config() @@ -97,7 +97,7 @@ class TestTCPUnitTests(VppTestCase): if error: self.logger.critical(error) - self.assertEqual(error.find("failed"), -1) + self.assertNotIn("failed", error) if __name__ == '__main__': unittest.main(testRunner=VppTestRunner) |