aboutsummaryrefslogtreecommitdiffstats
path: root/vnet/vnet/l2/l2_classify.h
diff options
context:
space:
mode:
authorJean-Mickael Guerin <jean-mickael.guerin@6wind.com>2016-03-04 14:14:21 +0100
committerGerrit Code Review <gerrit@fd.io>2016-03-14 12:40:17 +0000
commit8941ec2cb4ff29dbf167e3b80e09a70c9164cc19 (patch)
tree62e64a2f5e13a2ce6257c102c5f48a074e017716 /vnet/vnet/l2/l2_classify.h
parent966a8b868b33de72d5d9edb6317418165c62661c (diff)
fix declaration of symbol of different size
I got many warnings at the link step with gcc version 5.3.1 20160225 (Ubuntu 5.3.1-10ubuntu2): /usr/bin/ld: Warning: size of symbol `cop_input_node' changed from 112 in vnet/cop/.libs/cop.o to 168 in vnet/cop/.libs/node1.o /usr/bin/ld: Warning: size of symbol `ethernet_input_node' changed from 112 in vnet/.libs/interface.o to 136 in vnet/ethernet/.libs/node.o /usr/bin/ld: Warning: size of symbol `l2output_node' changed from 112 in vnet/l2/.libs/l2_efp_filter.o to 120 in vnet/l2/.libs/l2_output.o /usr/bin/ld: Warning: size of symbol `srp_input_node' changed from 112 in vnet/srp/.libs/format.o to 136 in vnet/srp/.libs/node.o /usr/bin/ld: Warning: size of symbol `vxlan_encap_node' changed from 112 in vnet/vxlan/.libs/vxlan.o to 128 in vnet/vxlan/.libs/encap.o /usr/bin/ld: Warning: size of symbol `vxlan_input_node' changed from 112 in vnet/vxlan/.libs/vxlan.o to 144 in vnet/vxlan/.libs/decap.o ... Looking at vlib_node_registration_t, I think the reason is that the char * next_nodes[] could be bigger where the variable is defined in .c file. We should mark global variables as external in header files. Some of them can be made static. Change-Id: Ieb6961fd08180c9a69e1d884852703f3eb23f23f Signed-off-by: Jean-Mickael Guerin <jean-mickael.guerin@6wind.com>
Diffstat (limited to 'vnet/vnet/l2/l2_classify.h')
-rw-r--r--vnet/vnet/l2/l2_classify.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/vnet/vnet/l2/l2_classify.h b/vnet/vnet/l2/l2_classify.h
index 55c2fc8b00d..74e9d91c1ad 100644
--- a/vnet/vnet/l2/l2_classify.h
+++ b/vnet/vnet/l2/l2_classify.h
@@ -65,7 +65,7 @@ typedef struct {
l2_classify_main_t l2_classify_main;
-vlib_node_registration_t l2_classify_node;
+extern vlib_node_registration_t l2_classify_node;
void vnet_l2_classify_enable_disable (u32 sw_if_index,
int enable_disable);