diff options
| author |   Dave Barach <dave@barachs.net> | 2016-08-05 10:10:18 -0400 |
|---|---|---|
| committer | Dave Barach <dave@barachs.net> | 2016-08-05 10:10:38 -0400 |
| commit | f9c231ec12c2233557bfbb58feb87a1fcddf224a (patch) | |
| tree | 6ee8846be9a6c79d68d0364c00cc58b2f3547ddd /vppinfra/vppinfra/asm_x86.c | |
| parent | 56faee837281c7f9c28aa40dbf0f6e4620b76be8 (diff) | |
vpp-189 Clean up more coverity warnings
Time to make the donuts
Change-Id: I528937800f7daefce19723dda0216e58d857942c
Signed-off-by: Dave Barach <dave@barachs.net>
Diffstat (limited to 'vppinfra/vppinfra/asm_x86.c')
| -rw-r--r-- | vppinfra/vppinfra/asm_x86.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/vppinfra/vppinfra/asm_x86.c b/vppinfra/vppinfra/asm_x86.c index d89739cbd90..16e41c249b1 100644 --- a/vppinfra/vppinfra/asm_x86.c +++ b/vppinfra/vppinfra/asm_x86.c @@ -1736,6 +1736,7 @@ static u8 * format_x86_reg_operand (u8 * s, va_list * va) { default: ASSERT (0); + break; case 'x': ASSERT (reg < 16); @@ -1816,6 +1817,7 @@ static u8 * format_x86_insn_operand (u8 * s, va_list * va) /* Memory or reg field from modrm byte. */ case 'M': ASSERT (p->flags & X86_INSN_IS_ADDRESS); + /* FALLTHROUGH */ case 'E': if (p->flags & X86_INSN_IS_ADDRESS) s = format (s, "%U", format_x86_mem_operand, p); @@ -1836,7 +1838,7 @@ static u8 * format_x86_insn_operand (u8 * s, va_list * va) case 'I': { u32 l = x86_insn_log2_immediate_bytes (p, insn); - i64 mask = pow2_mask (8 << l); + i64 mask = pow2_mask (8ULL << l); s = format (s, "$0x%Lx", p->immediate & mask); } break; |