diff options
Diffstat (limited to 'src/plugins/cdp')
-rw-r--r-- | src/plugins/cdp/cdp.c | 4 | ||||
-rw-r--r-- | src/plugins/cdp/cdp.pg | 12 | ||||
-rw-r--r-- | src/plugins/cdp/cdp_input.c | 45 | ||||
-rw-r--r-- | src/plugins/cdp/cdp_node.c | 2 | ||||
-rw-r--r-- | src/plugins/cdp/cdp_periodic.c | 6 |
5 files changed, 27 insertions, 42 deletions
diff --git a/src/plugins/cdp/cdp.c b/src/plugins/cdp/cdp.c index 1fe557fe82e..00784ccd0bc 100644 --- a/src/plugins/cdp/cdp.c +++ b/src/plugins/cdp/cdp.c @@ -86,14 +86,12 @@ cdp_command_fn (vlib_main_t * vm, return 0; } -/* *INDENT-OFF* */ VLIB_CLI_COMMAND (cdp_command, static) = { .path = "cdp", .short_help = "cdp enable | disable", .function = cdp_command_fn, }; -/* *INDENT-ON* */ /* API message handler */ static void vl_api_cdp_enable_disable_t_handler @@ -124,13 +122,11 @@ cdp_init (vlib_main_t * vm) VLIB_INIT_FUNCTION (cdp_init); -/* *INDENT-OFF* */ VLIB_PLUGIN_REGISTER () = { .version = VPP_BUILD_VER, .description = "Cisco Discovery Protocol (CDP)", }; -/* *INDENT-ON* */ /* * fd.io coding-style-patch-verification: ON diff --git a/src/plugins/cdp/cdp.pg b/src/plugins/cdp/cdp.pg index b6ba18656c2..32700463ed0 100644 --- a/src/plugins/cdp/cdp.pg +++ b/src/plugins/cdp/cdp.pg @@ -1,7 +1,7 @@ -packet-generator new { - name cdp - limit 1 - node cdp-input - size 374-374 - data { hex 0x02b46b96000100096978676265000500bf436973636f20494f5320536f6674776172652c2043333735304520536f66747761726520284333373530452d554e4956455253414c2d4d292c2056657273696f6e2031322e32283335295345352c2052454c4541534520534f4654574152452028666331290a436f707972696768742028632920313938362d3230303720627920436973636f2053797374656d732c20496e632e0a436f6d70696c6564205468752031392d4a756c2d30372031363a3137206279206e616368656e00060018636973636f2057532d4333373530452d3234544400020011000000010101cc0004000000000003001b54656e4769676162697445746865726e6574312f302f3100040008000000280008002400000c011200000000ffffffff010221ff000000000000001e7a50f000ff000000090004000a00060001000b0005010012000500001300050000160011000000010101cc000400000000001a00100000000100000000ffffffff } +packet-generator new { \ + name cdp \ + limit 1 \ + node cdp-input \ + size 374-374 \ + data { hex 0x02b46b96000100096978676265000500bf436973636f20494f5320536f6674776172652c2043333735304520536f66747761726520284333373530452d554e4956455253414c2d4d292c2056657273696f6e2031322e32283335295345352c2052454c4541534520534f4654574152452028666331290a436f707972696768742028632920313938362d3230303720627920436973636f2053797374656d732c20496e632e0a436f6d70696c6564205468752031392d4a756c2d30372031363a3137206279206e616368656e00060018636973636f2057532d4333373530452d3234544400020011000000010101cc0004000000000003001b54656e4769676162697445746865726e6574312f302f3100040008000000280008002400000c011200000000ffffffff010221ff000000000000001e7a50f000ff000000090004000a00060001000b0005010012000500001300050000160011000000010101cc000400000000001a00100000000100000000ffffffff } \ } diff --git a/src/plugins/cdp/cdp_input.c b/src/plugins/cdp/cdp_input.c index 76a3d70a292..914d4dec66f 100644 --- a/src/plugins/cdp/cdp_input.c +++ b/src/plugins/cdp/cdp_input.c @@ -167,25 +167,24 @@ _(version,DEBUG_TLV_DUMP) \ _(platform,DEBUG_TLV_DUMP) \ _(port_id,DEBUG_TLV_DUMP) -#define _(z,dbg) \ -static \ -cdp_error_t process_##z##_tlv (cdp_main_t *cm, cdp_neighbor_t *n, \ - cdp_tlv_t *t) \ -{ \ - int i; \ - if (dbg) \ - fformat(stdout, "%U\n", format_text_tlv, t); \ - \ - if (n->z) \ - _vec_len(n->z) = 0; \ - \ - for (i = 0; i < (t->l - sizeof (*t)); i++) \ - vec_add1(n->z, t->v[i]); \ - \ - vec_add1(n->z, 0); \ - \ - return CDP_ERROR_NONE; \ -} +#define _(z, dbg) \ + static cdp_error_t process_##z##_tlv (cdp_main_t *cm, cdp_neighbor_t *n, \ + cdp_tlv_t *t) \ + { \ + int i; \ + if (dbg) \ + fformat (stdout, "%U\n", format_text_tlv, t); \ + \ + if (n->z) \ + vec_set_len (n->z, 0); \ + \ + for (i = 0; i < (t->l - sizeof (*t)); i++) \ + vec_add1 (n->z, t->v[i]); \ + \ + vec_add1 (n->z, 0); \ + \ + return CDP_ERROR_NONE; \ + } foreach_text_to_struct_tlv #undef _ @@ -354,7 +353,7 @@ cdp_input (vlib_main_t * vm, vlib_buffer_t * b0, u32 bi0) */ if (n->last_rx_pkt) - _vec_len (n->last_rx_pkt) = 0; + vec_set_len (n->last_rx_pkt, 0); /* cdp disabled on this interface, we're done */ if (n->disabled) @@ -417,12 +416,10 @@ cdp_input_init (vlib_main_t * vm) return 0; } -/* *INDENT-OFF* */ VLIB_INIT_FUNCTION (cdp_input_init) = { .runs_after = VLIB_INITS("cdp_periodic_init"), }; -/* *INDENT-ON* */ static u8 * @@ -438,7 +435,6 @@ format_cdp_neighbors (u8 * s, va_list * va) "%=25s %=25s %=25s %=10s\n", "Our Port", "Peer System", "Peer Port", "Last Heard"); - /* *INDENT-OFF* */ pool_foreach (n, cm->neighbors) { hw = vnet_get_sup_hw_interface (vnm, n->sw_if_index); @@ -448,7 +444,6 @@ format_cdp_neighbors (u8 * s, va_list * va) hw->name, n->device_name, n->port_id, n->last_heard); } - /* *INDENT-ON* */ return s; } @@ -466,13 +461,11 @@ show_cdp (vlib_main_t * vm, return 0; } -/* *INDENT-OFF* */ VLIB_CLI_COMMAND (show_cdp_command, static) = { .path = "show cdp", .short_help = "Show cdp command", .function = show_cdp, }; -/* *INDENT-ON* */ /* diff --git a/src/plugins/cdp/cdp_node.c b/src/plugins/cdp/cdp_node.c index f9ee251c022..49b1e3844e4 100644 --- a/src/plugins/cdp/cdp_node.c +++ b/src/plugins/cdp/cdp_node.c @@ -100,7 +100,6 @@ cdp_node_fn (vlib_main_t * vm, /* * cdp input graph node declaration */ -/* *INDENT-OFF* */ VLIB_REGISTER_NODE (cdp_input_node, static) = { .function = cdp_node_fn, .name = "cdp-input", @@ -117,7 +116,6 @@ VLIB_REGISTER_NODE (cdp_input_node, static) = { [CDP_INPUT_NEXT_NORMAL] = "error-drop", }, }; -/* *INDENT-ON* */ /* * cdp periodic function diff --git a/src/plugins/cdp/cdp_periodic.c b/src/plugins/cdp/cdp_periodic.c index c73d86be316..03a2de0d9ab 100644 --- a/src/plugins/cdp/cdp_periodic.c +++ b/src/plugins/cdp/cdp_periodic.c @@ -357,12 +357,10 @@ cdp_periodic (vlib_main_t * vm) int i; static cdp_neighbor_t **n_list = 0; - /* *INDENT-OFF* */ pool_foreach (n, cm->neighbors) { vec_add1 (n_list, n); } - /* *INDENT-ON* */ /* Across all cdp neighbors known to the system */ for (i = 0; i < vec_len (n_list); i++) @@ -394,9 +392,9 @@ cdp_periodic (vlib_main_t * vm) delete_neighbor (cm, n, 1); } if (delete_list) - _vec_len (delete_list) = 0; + vec_set_len (delete_list, 0); if (n_list) - _vec_len (n_list) = 0; + vec_set_len (n_list, 0); } static clib_error_t * |