aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJieqiang Wang <jieqiang.wang@arm.com>2022-05-05 12:33:57 +0000
committerBeno�t Ganne <bganne@cisco.com>2022-05-05 07:04:01 +0000
commit4ebcd95e620a2be1c69cce3297f31754d9aa8c88 (patch)
tree18c9cd1571e85c30c5461e82ba0b95b41224a767
parent0499d8839dccaeb176eb868dfe7bc4bd412506c9 (diff)
rdma: two small improvements for rdma interface
- fix branch prediction for checking rdma ERROR flag - add the missing right angle bracket to help message Type: improvement Signed-off-by: Jieqiang Wang <jieqiang.wang@arm.com> Reviewed-by: Lijian Zhang <lijian.zhang@arm.com> Reviewed-by: Tianyu Li <tianyu.li@arm.com> Change-Id: I2ce667631b3e3f60939069e2a16ddba0ff12a695
-rw-r--r--src/plugins/rdma/cli.c8
-rw-r--r--src/plugins/rdma/input.c2
2 files changed, 5 insertions, 5 deletions
diff --git a/src/plugins/rdma/cli.c b/src/plugins/rdma/cli.c
index 8f191e34b63..0edc83a05ce 100644
--- a/src/plugins/rdma/cli.c
+++ b/src/plugins/rdma/cli.c
@@ -48,10 +48,10 @@ rdma_create_command_fn (vlib_main_t * vm, unformat_input_t * input,
VLIB_CLI_COMMAND (rdma_create_command, static) = {
.path = "create interface rdma",
.short_help = "create interface rdma <host-if ifname> [name <name>]"
- " [rx-queue-size <size>] [tx-queue-size <size>]"
- " [num-rx-queues <size>] [mode <auto|ibv|dv]"
- " [no-multi-seg] [no-striding]"
- " [max-pktlen <size>]",
+ " [rx-queue-size <size>] [tx-queue-size <size>]"
+ " [num-rx-queues <size>] [mode <auto|ibv|dv>]"
+ " [no-multi-seg] [no-striding]"
+ " [max-pktlen <size>]",
.function = rdma_create_command_fn,
};
/* *INDENT-ON* */
diff --git a/src/plugins/rdma/input.c b/src/plugins/rdma/input.c
index f1c508affa2..2ff04a6ec46 100644
--- a/src/plugins/rdma/input.c
+++ b/src/plugins/rdma/input.c
@@ -1028,7 +1028,7 @@ VLIB_NODE_FN (rdma_input_node) (vlib_main_t * vm,
if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_ADMIN_UP) == 0)
continue;
- if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_ERROR))
+ if (PREDICT_FALSE (rd->flags & RDMA_DEVICE_F_ERROR))
continue;
if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_MLX5DV))