aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJieqiang Wang <jieqiang.wang@arm.com>2023-02-24 16:40:58 +0800
committerDamjan Marion <dmarion@0xa5.net>2023-03-06 14:24:57 +0000
commitd69233f44ea1f039e7755358c0acb20bfbec2258 (patch)
tree5a2fe8d2044fc39bd27af7a6d52b834b3362f30e
parent79687d92fe652b4b7563c3d436753ab03c395f3f (diff)
build: replace phony target with .ok file
When VPP builds its external packages from source, it will download the package, patch it, configure it, build and install it. For DPDK, it will depend on rdma-core if mlx4/mlx5 PMD is enabled. So phony target dpdk-config needs to have the prerequisites of rdma-core-install and ipsec-mb-install(x86 only), which are both phony targets. This leads to redundant behavior of recipes executing twice in dpdk-config. Replace the phony target with hidden file *.install.ok to avoid that. Type: improvement Signed-off-by: Lijian Zhang <lijian.zhang@arm.com> Signed-off-by: Jieqiang Wang <jieqiang.wang@arm.com> Change-Id: Ibf3b766ab7a4ccfcbffe08f6cdb90da72ca1ce29
-rw-r--r--build/external/packages.mk2
1 files changed, 1 insertions, 1 deletions
diff --git a/build/external/packages.mk b/build/external/packages.mk
index b969d8fc5e7..eba702222de 100644
--- a/build/external/packages.mk
+++ b/build/external/packages.mk
@@ -102,7 +102,7 @@ endef
endif
ifneq ($(filter $1,$(VPP_SKIP_EXTERNAL)), $1)
-$(B)/.$1.config.ok: $(B)/.$1.patch.ok $(addsuffix -install,$($1_depends))
+$(B)/.$1.config.ok: $(B)/.$1.patch.ok $(addprefix $(B)/.,$(addsuffix .install.ok,$($1_depends)))
$$(call h1,"configuring $1 $($1_version) - log: $$($1_config_log)")
@mkdir -p $$($1_build_dir)
$$(call $1_config_cmds)