aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
Diffstat
-rw-r--r--extras/hs-test/framework_test.go2
-rw-r--r--extras/hs-test/infra/cpu.go55
-rw-r--r--extras/hs-test/infra/hst_suite.go9
-rw-r--r--src/plugins/acl/hash_lookup.c22
-rw-r--r--src/vat2/main.c35
-rw-r--r--test/Makefile2
-rw-r--r--test/vpp_iperf.py41
7 files changed, 60 insertions, 106 deletions
diff --git a/extras/hs-test/framework_test.go b/extras/hs-test/framework_test.go
index f3bf1be56a8..be62b61a057 100644
--- a/extras/hs-test/framework_test.go
+++ b/extras/hs-test/framework_test.go
@@ -33,6 +33,8 @@ func TestHst(t *testing.T) {
TestTimeout = time.Minute * 5
}
+ RunningInCi = os.Getenv("BUILD_NUMBER") != ""
+
output, err := os.ReadFile("/sys/devices/system/node/online")
if err == nil && strings.Contains(string(output), "-") {
NumaAwareCpuAlloc = true
diff --git a/extras/hs-test/infra/cpu.go b/extras/hs-test/infra/cpu.go
index 743a4eddc67..4afc96bcee4 100644
--- a/extras/hs-test/infra/cpu.go
+++ b/extras/hs-test/infra/cpu.go
@@ -6,7 +6,6 @@ import (
"fmt"
"os"
"os/exec"
- "strconv"
"strings"
. "github.com/onsi/ginkgo/v2"
@@ -21,8 +20,6 @@ type CpuContext struct {
type CpuAllocatorT struct {
cpus []int
- runningInCi bool
- buildNumber int
maxContainerCount int
}
@@ -40,13 +37,8 @@ func (c *CpuAllocatorT) Allocate(containerCount int, nCpus int, offset int) (*Cp
// indexes, not actual cores
var minCpu, maxCpu int
- if c.runningInCi {
- minCpu = ((c.buildNumber) * c.maxContainerCount * nCpus) + offset
- maxCpu = ((c.buildNumber + 1) * c.maxContainerCount * nCpus) - 1 + offset
- } else {
- minCpu = ((GinkgoParallelProcess() - 1) * c.maxContainerCount * nCpus) + offset
- maxCpu = (GinkgoParallelProcess() * c.maxContainerCount * nCpus) - 1 + offset
- }
+ minCpu = ((GinkgoParallelProcess() - 1) * c.maxContainerCount * nCpus) + offset
+ maxCpu = (GinkgoParallelProcess() * c.maxContainerCount * nCpus) - 1 + offset
if len(c.cpus)-1 < maxCpu {
err := fmt.Errorf("could not allocate %d CPUs; available count: %d; attempted to allocate cores with index %d-%d; max index: %d;\n"+
@@ -66,33 +58,9 @@ func (c *CpuAllocatorT) Allocate(containerCount int, nCpus int, offset int) (*Cp
}
func (c *CpuAllocatorT) readCpus() error {
- var first, second, third, fourth int
- var file *os.File
- var err error
-
- if c.runningInCi {
- // non-debug build runs on node0, debug on node1
- if *IsDebugBuild {
- file, err = os.Open("/sys/devices/system/node/node1/cpulist")
- } else {
- file, err = os.Open("/sys/devices/system/node/node0/cpulist")
- }
- if err != nil {
- return err
- }
- defer file.Close()
-
- sc := bufio.NewScanner(file)
- sc.Scan()
- line := sc.Text()
- _, err = fmt.Sscanf(line, "%d-%d,%d-%d", &first, &second, &third, &fourth)
- if err != nil {
- return err
- }
+ var first, second int
- c.cpus = iterateAndAppend(first, second, c.cpus)
- c.cpus = iterateAndAppend(third, fourth, c.cpus)
- } else if NumaAwareCpuAlloc {
+ if NumaAwareCpuAlloc {
var range1, range2 int
var tmpCpus []int
@@ -124,7 +92,7 @@ func (c *CpuAllocatorT) readCpus() error {
line := sc.Text()
for _, coreRange := range strings.Split(line, ",") {
- if strings.IndexRune(coreRange, '-') != -1 {
+ if strings.ContainsRune(coreRange, '-') {
_, err = fmt.Sscanf(coreRange, "%d-%d", &range1, &range2)
if err != nil {
return err
@@ -148,7 +116,8 @@ func (c *CpuAllocatorT) readCpus() error {
// and we can use offsets
countToRemove := len(tmpCpus) % (c.maxContainerCount * *NConfiguredCpus)
if countToRemove >= len(tmpCpus) {
- return fmt.Errorf("requested too much CPUs per container (%d) should be no more than %d", *NConfiguredCpus, len(tmpCpus)/c.maxContainerCount)
+ return fmt.Errorf("requested too many CPUs per container (%d), should be no more "+
+ "than %d", *NConfiguredCpus, len(tmpCpus)/c.maxContainerCount)
}
c.cpus = append(c.cpus, tmpCpus[:len(tmpCpus)-countToRemove]...)
tmpCpus = tmpCpus[:0]
@@ -200,16 +169,6 @@ func CpuAllocator() (*CpuAllocatorT, error) {
var err error
cpuAllocator = new(CpuAllocatorT)
cpuAllocator.maxContainerCount = 4
- buildNumberStr := os.Getenv("BUILD_NUMBER")
-
- if buildNumberStr != "" {
- cpuAllocator.runningInCi = true
- // get last digit of build number
- cpuAllocator.buildNumber, err = strconv.Atoi(buildNumberStr[len(buildNumberStr)-1:])
- if err != nil {
- return nil, err
- }
- }
err = cpuAllocator.readCpus()
if err != nil {
return nil, err
diff --git a/extras/hs-test/infra/hst_suite.go b/extras/hs-test/infra/hst_suite.go
index 5ef4883ebdb..c2dfc592ebb 100644
--- a/extras/hs-test/infra/hst_suite.go
+++ b/extras/hs-test/infra/hst_suite.go
@@ -46,6 +46,7 @@ var ParallelTotal = flag.Lookup("ginkgo.parallel.total")
var DryRun = flag.Bool("dryrun", false, "set up containers but don't run tests")
var NumaAwareCpuAlloc bool
var TestTimeout time.Duration
+var RunningInCi bool
type HstSuite struct {
AllContainers map[string]*Container
@@ -443,11 +444,7 @@ func (s *HstSuite) SkipIfNotEnoughAvailableCpus() {
availableCpus++
}
- if s.CpuAllocator.runningInCi {
- maxRequestedCpu = ((s.CpuAllocator.buildNumber + 1) * s.CpuAllocator.maxContainerCount * s.CpuCount)
- } else {
- maxRequestedCpu = (GinkgoParallelProcess() * s.CpuAllocator.maxContainerCount * s.CpuCount)
- }
+ maxRequestedCpu = (GinkgoParallelProcess() * s.CpuAllocator.maxContainerCount * s.CpuCount)
if availableCpus < maxRequestedCpu {
s.Skip(fmt.Sprintf("Test case cannot allocate requested cpus "+
@@ -516,7 +513,7 @@ func (s *HstSuite) WaitForCoreDump() bool {
output, _ := exechelper.Output(cmd)
AddReportEntry("VPP Backtrace", StringerStruct{Label: string(output)})
os.WriteFile(s.getLogDirPath()+"backtrace.log", output, os.FileMode(0644))
- if s.CpuAllocator.runningInCi {
+ if RunningInCi {
err = os.Remove(corePath)
if err == nil {
s.Log("removed " + corePath)
diff --git a/src/plugins/acl/hash_lookup.c b/src/plugins/acl/hash_lookup.c
index 9c3c662a8f1..b4f86208a71 100644
--- a/src/plugins/acl/hash_lookup.c
+++ b/src/plugins/acl/hash_lookup.c
@@ -946,31 +946,15 @@ hash_acl_reapply(acl_main_t *am, u32 lc_index, int acl_index)
static void
make_ip6_address_mask(ip6_address_t *addr, u8 prefix_len)
{
+ ASSERT (prefix_len <= 128);
ip6_address_mask_from_width(addr, prefix_len);
}
-
-/* Maybe should be moved into the core somewhere */
-always_inline void
-ip4_address_mask_from_width (ip4_address_t * a, u32 width)
-{
- int i, byte, bit, bitnum;
- ASSERT (width <= 32);
- clib_memset (a, 0, sizeof (a[0]));
- for (i = 0; i < width; i++)
- {
- bitnum = (7 - (i & 7));
- byte = i / 8;
- bit = 1 << bitnum;
- a->as_u8[byte] |= bit;
- }
-}
-
-
static void
make_ip4_address_mask(ip4_address_t *addr, u8 prefix_len)
{
- ip4_address_mask_from_width(addr, prefix_len);
+ ASSERT (prefix_len <= 32);
+ ip4_preflen_to_mask (prefix_len, addr);
}
static void
diff --git a/src/vat2/main.c b/src/vat2/main.c
index bf415854db1..2949c4899aa 100644
--- a/src/vat2/main.c
+++ b/src/vat2/main.c
@@ -253,16 +253,15 @@ print_help (void)
"Send API message to VPP and print reply\n"
"\n"
"-d, --debug Print additional information\n"
- "-p, --prefix <prefix> Specify shared memory prefix to connect "
- "to a given VPP instance\n"
+ "--dump-apis List all APIs available in VAT2 (might "
+ "not reflect running VPP)\n"
"-f, --file <filename> File containing a JSON object with the "
"arguments for the message to send\n"
+ "-p, --plugin-path Plugin path\n"
+ "-s, --prefix <prefix> Specify shared memory prefix to connect "
+ "to a given VPP instance\n"
"-t, --template <message-name> Print a template JSON object for given API"
- " message\n"
- "--dump-apis List all APIs available in VAT2 (might "
- "not reflect running VPP)\n"
- "--plugin-path Pluing path"
- "\n";
+ " message\n";
printf ("%s", help_string);
}
@@ -281,38 +280,38 @@ main (int argc, char **argv)
char *msgname = 0;
static struct option long_options[] = {
{ "debug", no_argument, 0, 'd' },
- { "prefix", required_argument, 0, 's' },
- { "file", required_argument, 0, 'f' },
{ "dump-apis", no_argument, 0, 0 },
- { "template", required_argument, 0, 't' },
+ { "file", required_argument, 0, 'f' },
{ "plugin-path", required_argument, 0, 'p' },
+ { "prefix", required_argument, 0, 's' },
+ { "template", required_argument, 0, 't' },
{ 0, 0, 0, 0 }
};
- while ((c = getopt_long (argc, argv, "hdp:f:t:", long_options,
+ while ((c = getopt_long (argc, argv, "df:p:s:t:", long_options,
&option_index)) != -1)
{
switch (c)
{
case 0:
- if (option_index == 3)
+ if (option_index == 1)
dump_api = true;
break;
case 'd':
vat2_debug = true;
break;
- case 't':
- template = optarg;
- break;
- case 's':
- prefix = optarg;
- break;
case 'f':
filename = optarg;
break;
case 'p':
pluginpath = optarg;
break;
+ case 's':
+ prefix = optarg;
+ break;
+ case 't':
+ template = optarg;
+ break;
case '?':
print_help ();
return 1;
diff --git a/test/Makefile b/test/Makefile
index 37f8e2db18b..6196be80a18 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -402,7 +402,7 @@ endif
LCOV_VERSION=$(shell lcov --version | sed -E 's/^lcov: LCOV version ([0-9]+)[.].*/\1/')
LCOV_IGNORE_ERRORS=
ifeq ($(LCOV_VERSION),2)
-LCOV_IGNORE_ERRORS=--ignore-errors unused,empty,mismatch,gcov
+LCOV_IGNORE_ERRORS=--ignore-errors unused,empty,mismatch,gcov,negative
endif
.PHONY: cov-post
diff --git a/test/vpp_iperf.py b/test/vpp_iperf.py
index b325399f8e1..03ced8bf12f 100644
--- a/test/vpp_iperf.py
+++ b/test/vpp_iperf.py
@@ -5,6 +5,8 @@
import subprocess
import os
import sys
+import time
+import signal
class VppIperf:
@@ -196,20 +198,31 @@ def start_iperf(
def stop_iperf(iperf_cmd):
"""Stop the iperf process matching the iperf_cmd string."""
- args = ["pgrep", "-x", "-f", iperf_cmd]
- p = subprocess.Popen(
- args, stdout=subprocess.PIPE, stderr=subprocess.PIPE, encoding="utf-8"
- )
- stdout, _ = p.communicate()
- for pid in stdout.split():
- try:
- subprocess.run(
- f"kill -9 {pid}",
- encoding="utf-8",
- shell=True,
- )
- except Exception:
- pass
+ try:
+ result = subprocess.run(
+ ["pgrep", "-x", "-f", iperf_cmd],
+ stdout=subprocess.PIPE,
+ stderr=subprocess.PIPE,
+ encoding="utf-8",
+ )
+ pids = result.stdout.strip().split()
+ if not pids:
+ # No matching iperf3 processes found
+ return
+
+ for pid in pids:
+ try:
+ # First send SIGTERM to cleanup and notify the parent process
+ os.kill(int(pid), signal.SIGTERM)
+ time.sleep(2)
+ os.kill(int(pid), 0) # Check if still alive
+ os.kill(int(pid), signal.SIGKILL)
+ except ProcessLookupError:
+ pass # Process already exited
+ except Exception as e:
+ print(f"Error terminating iperf3 process {pid}: {e}")
+ except Exception as e:
+ print(f"Failed to run pgrep for '{iperf_cmd}': {e}")
if __name__ == "__main__":